<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>3422</bug_id>
          
          <creation_ts>2012-11-13 21:50:38 +0000</creation_ts>
          <short_desc>Correct commentary and possibly code assumptions about the existence of KMETA</short_desc>
          <delta_ts>2012-11-29 19:16:25 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>Kernel</product>
          <component>kernel-tooling</component>
          <version>1.3</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Darren Hart">dvhart</reporter>
          <assigned_to name="Bruce Ashfield">bruce.ashfield</assigned_to>
          <cc>yp.kernel.watcher</cc>
    
    <cc>yp.watcher</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>---</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>27414</commentid>
    <comment_count>0</comment_count>
    <who name="Darren Hart">dvhart</who>
    <bug_when>2012-11-13 21:50:38 +0000</bug_when>
    <thetext>The expected (and soon to be documented) behavior of the KMETA variable is that if set, the tools expect a branch of the KMETA value name to exist. If it is set to the empty string, a directory by the name of meta should exist in the machine branch and should contain a complete set of meta-data.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>27415</commentid>
    <comment_count>1</comment_count>
    <who name="Darren Hart">dvhart</who>
    <bug_when>2012-11-13 21:51:17 +0000</bug_when>
    <thetext>For example, the comments in kernel-yocto.bbclass::do_kernel_checkout() suggest that a branch is required.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>27424</commentid>
    <comment_count>2</comment_count>
    <who name="Bruce Ashfield">bruce.ashfield</who>
    <bug_when>2012-11-14 02:37:39 +0000</bug_when>
    <thetext>KMETA definitely is not required in the current code, every linux-yocto-custom
is running with an empty KMETA variable.

I&apos;m not sure what you are seeing in do_kernel_checkout(), but the only reference
to KMETA is protected:

                if [ -n &quot;${KMETA}&quot; ]; then
                        git branch -a | grep -q ${KMETA}
                        if [ $? -ne 0 ]; then
                                echo &quot;ERROR. The branch &apos;${KMETA}&apos; is required and was not&quot;
                                echo &quot;found. Ensure that the SRC_URI points to a valid linux-yocto&quot;
                                echo &quot;kernel repository&quot;
                                exit 1
                        fi
                fi


.. so if it&apos;s empty, it won&apos;t fire.

If KMETA is empty, the tools expect nothing, and meta doesn&apos;t need to exist
in directory form.

Maybe our notes are messed up on this defect, but I don&apos;t think there&apos;s anything
to document for this one with respect to branches and directories, but I could
use the defect to document how to switch/use KMETA. Does that sound ok ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>27437</commentid>
    <comment_count>3</comment_count>
    <who name="Darren Hart">dvhart</who>
    <bug_when>2012-11-14 16:52:54 +0000</bug_when>
    <thetext>Perhaps just the comment then?

		# we can fix up the kernel repository, but at the least the meta
		# branch must be present. The machine branch may be created later.

Maybe just something simple like &quot;but the meta branch must be present if KMETA is defined&quot; or similar. People coming up to speed on tooling are likely to read the above and assume a KMETA branch is required.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>27438</commentid>
    <comment_count>4</comment_count>
    <who name="Bruce Ashfield">bruce.ashfield</who>
    <bug_when>2012-11-14 16:59:43 +0000</bug_when>
    <thetext>That&apos;s reasonable .. I&apos;ve modified the comment locally and will send it out with my next merge request.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>27827</commentid>
    <comment_count>5</comment_count>
    <who name="Bruce Ashfield">bruce.ashfield</who>
    <bug_when>2012-11-29 19:16:25 +0000</bug_when>
    <thetext>merged to oe-core.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>