<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>362</bug_id>
          
          <creation_ts>2010-09-29 14:16:21 +0000</creation_ts>
          <short_desc>When do_fetch attempts to pull from a &quot;git&quot; source, a failure is not detected</short_desc>
          <delta_ts>2010-12-21 06:07:19 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>Meta-yocto</product>
          <component>meta-yocto</component>
          <version>0.9</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>High</priority>
          <bug_severity>major</bug_severity>
          <target_milestone>0.9 M4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Hatle">mark.hatle</reporter>
          <assigned_to name="Joshua Lock - Disabled">josh</assigned_to>
          <cc>jessica.zhang</cc>
    
    <cc>kevin.tian</cc>
    
    <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
    
    <cc>richard.purdie</cc>
    
    <cc>sgw</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          <cf_verified>Program Management</cf_verified>
          <cf_docchange>---</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>10047</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Hatle">mark.hatle</who>
    <bug_when>2010-09-29 14:16:21 +0000</bug_when>
    <thetext>When working on a recent package, an invalid git URI did NOT trigger a failure during the do_fetch processing.

Running the command by hand had git return a non-zero return code and an error message.... however bitbake happily continues on and pretends everything worked properly, until the unpack fails later.  (By this point the fetch stamp has been created, so subsequent tries will keep failing at unpack!)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>10081</commentid>
    <comment_count>1</comment_count>
    <who name="Joshua Lock - Disabled">josh</who>
    <bug_when>2010-09-30 09:36:19 +0000</bug_when>
    <thetext>Oh, that&apos;s not good at all. This is fairly trivial to fix by adding some special casing to runfetchcmd(), but I&apos;m not a big fan of special casing so posting a patch here while I ponder it a bit more.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>10082</commentid>
    <comment_count>2</comment_count>
      <attachid>49</attachid>
    <who name="Joshua Lock - Disabled">josh</who>
    <bug_when>2010-09-30 09:36:56 +0000</bug_when>
    <thetext>Created attachment 49
A simple patch which adds special-casing to runfetchcmd()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>10083</commentid>
    <comment_count>3</comment_count>
      <attachid>49</attachid>
    <who name="Joshua Lock - Disabled">josh</who>
    <bug_when>2010-09-30 09:54:28 +0000</bug_when>
    <thetext>Comment on attachment 49
A simple patch which adds special-casing to runfetchcmd()

This patch is bogus as I misread the bug report...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>10163</commentid>
    <comment_count>4</comment_count>
    <who name="Joshua Lock - Disabled">josh</who>
    <bug_when>2010-10-05 06:05:59 +0000</bug_when>
    <thetext>I finally figured this out; when I introduced the new mirror code to bb.fetch.go() I used an exception raised by the sources fetcher method to determine whether the mirrors should be tried, however the exception was swallowed so if the mirror fetch failed no error was triggered.

I&apos;ve implemented a patch on my branch which saves the exception and re-raises it if the mirror fetching code fails.

http://git.pokylinux.org/cgit/cgit.cgi/poky-contrib/commit/?h=josh/master&amp;id=e778a529c9ffc2daea1bdd910bffc0bb835d4775</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>10168</commentid>
    <comment_count>5</comment_count>
    <who name="Mark Hatle">mark.hatle</who>
    <bug_when>2010-10-05 08:24:54 +0000</bug_when>
    <thetext>I&apos;ve verified this DOES fix the problem I observed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>10169</commentid>
    <comment_count>6</comment_count>
    <who name="Jessica">jessica.zhang</who>
    <bug_when>2010-10-05 08:29:11 +0000</bug_when>
    <thetext>Josh fixed in his branch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>10170</commentid>
    <comment_count>7</comment_count>
    <who name="Joshua Lock - Disabled">josh</who>
    <bug_when>2010-10-05 08:57:34 +0000</bug_when>
    <thetext>I just merged a slightly modified version of the patch from my branch to master:
0ee7a9e6bdce1f3094e831b9db83087fff1dad17</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>10171</commentid>
    <comment_count>8</comment_count>
    <who name="Jessica">jessica.zhang</who>
    <bug_when>2010-10-05 09:38:33 +0000</bug_when>
    <thetext>Mark verified Josh&apos;s fix</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>49</attachid>
            <date>2010-09-30 09:36:56 +0000</date>
            <delta_ts>2010-09-30 09:54:28 +0000</delta_ts>
            <desc>A simple patch which adds special-casing to runfetchcmd()</desc>
            <filename>bb-fetch-runfetchcmd.patch</filename>
            <type>text/plain</type>
            <size>1083</size>
            <attacher name="Joshua Lock - Disabled">josh</attacher>
            
              <data encoding="base64">Y29tbWl0IGVkODBjMWZiZGYzMTU1MGM2MTBjYjg4YWY1MDllMzUwZjkzZTU4ZGEKQXV0aG9yOiBK
b3NodWEgTG9jayA8am9zaEBsaW51eC5pbnRlbC5jb20+CkRhdGU6ICAgVGh1IFNlcCAzMCAxNzoz
MjowNSAyMDEwICswMTAwCgogICAgZmV0Y2g6IGVuc3VyZSBnaXQgY2xvbmUgZmFpbHVyZXMgY2F1
c2UgcnVuZmV0Y2hjbWQoKSB0byBmYWlsCiAgICAKICAgIEdpdCBjbG9uZSBmYWlsdXJlcyByZXR1
cm4gYSBub24temVybyBleGl0IHN0YXR1cyB3aGljaCBkb2Vzbid0IHRyaWdnZXIKICAgIHJ1bmZl
dGNoY21kKCkncyBlcnJvciBoYW5kbGluZy4gSGF2ZSBydW5mZXRjaGNtZCgpIGFsc28gbG9vayBm
b3Iga2V5IHdvcmRzIGluCiAgICB0aGUgb3V0cHV0IHRvIGRldGVjdCBlcnJvcnMuCiAgICAKICAg
IEtleSB3b3JkLCAiZmF0YWwiLgogICAgCiAgICBGaXhlcyBbQlVHSUQgIzM2Ml0KICAgIAogICAg
U2lnbmVkLW9mZi1ieTogSm9zaHVhIExvY2sgPGpvc2hAbGludXguaW50ZWwuY29tPgoKZGlmZiAt
LWdpdCBhL2JpdGJha2UvbGliL2JiL2ZldGNoL19faW5pdF9fLnB5IGIvYml0YmFrZS9saWIvYmIv
ZmV0Y2gvX19pbml0X18ucHkKaW5kZXggYTc4N2NiNi4uYzhlZWI1NSAxMDA2NDQKLS0tIGEvYml0
YmFrZS9saWIvYmIvZmV0Y2gvX19pbml0X18ucHkKKysrIGIvYml0YmFrZS9saWIvYmIvZmV0Y2gv
X19pbml0X18ucHkKQEAgLTQzMyw3ICs0MzMsNyBAQCBkZWYgcnVuZmV0Y2hjbWQoY21kLCBkLCBx
dWlldCA9IEZhbHNlKToKIAogICAgIGlmIHNpZ25hbDoKICAgICAgICAgcmFpc2UgRmV0Y2hFcnJv
cigiRmV0Y2ggY29tbWFuZCAlcyBmYWlsZWQgd2l0aCBzaWduYWwgJXMsIG91dHB1dDpcbiVzIiAl
IChjbWQsIHNpZ25hbCwgb3V0cHV0KSkKLSAgICBlbGlmIHN0YXR1cyAhPSAwOgorICAgIGVsaWYg
c3RhdHVzICE9IDAgb3IgImZhdGFsIiBpbiBzdGF0dXMubG93ZXIoKToKICAgICAgICAgcmFpc2Ug
RmV0Y2hFcnJvcigiRmV0Y2ggY29tbWFuZCAlcyBmYWlsZWQgd2l0aCBleGl0IGNvZGUgJXMsIG91
dHB1dDpcbiVzIiAlIChjbWQsIHN0YXR1cywgb3V0cHV0KSkKIAogICAgIHJldHVybiBvdXRwdXQK
</data>

          </attachment>
      

    </bug>

</bugzilla>