<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>4461</bug_id>
          
          <creation_ts>2013-05-08 08:23:14 +0000</creation_ts>
          <short_desc>bb.fatal() clean up</short_desc>
          <delta_ts>2013-06-04 06:23:45 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>1.5</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.5 M1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Robert Yang">liezhi.yang</reporter>
          <assigned_to name="Robert Yang">liezhi.yang</assigned_to>
          <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>ning.zhang</cc>
    
    <cc>sgw</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>---</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>32935</commentid>
    <comment_count>0</comment_count>
    <who name="Robert Yang">liezhi.yang</who>
    <bug_when>2013-05-08 08:23:14 +0000</bug_when>
    <thetext>The bb.fatal() is defined as:

def fatal(*args):
    logger.critical(&apos;&apos;.join(args))
    sys.exit(1)

So anything after bb.fatal() in the same code block doesn&apos;t have any effect, e.g.:

    bb.fatal(&quot;%s_%s: %s&quot; % (var, pkg, e))
    raise e

The &quot;raise e&quot; should be removed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>33126</commentid>
    <comment_count>1</comment_count>
    <who name="Robert Yang">liezhi.yang</who>
    <bug_when>2013-05-17 01:54:35 +0000</bug_when>
    <thetext>Merged into master:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=51c3e9df28619bfa5a6c22a7c91c7c7093080c87</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>33530</commentid>
    <comment_count>2</comment_count>
    <who name="Ning Zhang">ning.zhang</who>
    <bug_when>2013-06-04 06:23:45 +0000</bug_when>
    <thetext>Verified with poky (master:676fd3f394a0c0576b63c77ed2184bf5f42c29b6)

All same block code under bb.fatal() have been removed.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>