4496 2013-05-15 06:33:10 +0000 [x32] dropbear key generation hangs on x32 2013-05-30 22:31:07 +0000 1 1 7 Build System, Metadata & Runtime OE-Core connectivity 1.4.1 Other x86_64 RESOLVED FIXED (autobuilder) Medium+ major 1.4.1 1 sgw nitin.a.kamble bluelightning meta.mr.watcher meta.watcher nitin.a.kamble radu.moisan ross.burton --- --- --- oldest_to_newest 33091 0 sgw 2013-05-15 06:33:10 +0000 dropbear fails to correctly generate a key during startup, it hangs the system. Initial debug shows that a value passed into the mp_div_3() function is invalid. It should be a reasonable value, but instead is a full 64bit integer. This may be due to the way this number is initially stored. I did not that the mp_int "used" value is different between x86-64 and x32, the xa86-64 value was 9 while the x32 value was 19. 33254 1 nitin.a.kamble 2013-05-23 19:46:39 +0000 I tried creating x32 qemux86-64 image. And it built booted fine. Then I tried to run this command: dropbearkey -tdss -f private and it takes forever to finish it. 33255 2 1222 hjl.tools 2013-05-23 21:48:51 +0000 Created attachment 1222 A patch to fix x32 dropbear should use unsigned long long for unsigned 64-bit integer. 33256 3 nitin.a.kamble 2013-05-23 22:20:26 +0000 I check the HJ's fix with yocto project. And it does fix the issue I was seeing before. Thanks HJ for the quick fix. I will cook a commit for posting to YP mailing list. Nitin 33419 4 nitin.a.kamble 2013-05-30 22:31:07 +0000 Fixed by this commit: commit 676fd3f394a0c0576b63c77ed2184bf5f42c29b6 Author: Nitin A Kamble <nitin.a.kamble@intel.com> Date: Thu May 23 16:09:20 2013 +0000 dropbear: a fix for hang in dropbearkey, built for x32 This commit fixes runtime hang of 'dropbearkey' utility, built for a x32 target abi system. The hang was observed while generating ssh keys, with this command: dropbearkey -t dss -f private The issue is fixed by changing the code, where 'long' in x86_64 mode is assumed as 64bit quantity. With the x32 abi, the processor is in x86_64 mode, but the 'long' is a 32bit quantity. Hence the fix uses 'long long' instead of 'long' to define/access 64bit data variables. Fixes bug: [YOCTO #4496] (From OE-Core rev: 8f5bc47729edb8cb051d81e9ff1680cb8d2eca25) Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com> Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> 1222 2013-05-23 21:48:51 +0000 2013-05-23 21:48:51 +0000 A patch to fix x32 dropbear-2013.58-x32.patch text/plain 4343 hjl.tools IyBIRyBjaGFuZ2VzZXQgcGF0Y2gKIyBVc2VyIEguSi4gTHUgPGhqbC50b29sc0BnbWFpbC5jb20+ CiMgRGF0ZSAxMzY5MzQ0MDc5IDI1MjAwCiMgTm9kZSBJRCBhMTBhMWM0NmI4NTdjYzhhMzkyM2Mz YmI2ZDE1MDRhYTI1YjYwNTJmCiMgUGFyZW50ICBlNzY2MTQxNDVhZWE2N2Y2NmU0YTQyNTc2ODVj NzcxZWZiYTIxYWExClR5cGRlZiBtcF9kaWdpdCB0byB1bnNpZ25lZCBsb25nIGxvbmcgZm9yIE1Q XzY0QklUCgpXaGVuIEdDQyBpcyB1c2VkIHdpdGggTVBfNjRCSVQsIHdlIHNob3VsZCB0eXBlZGVm IG1wX2RpZ2l0IHRvIHVuc2lnbmVkCmxvbmcgbG9uZyBpbnN0ZWFkIG9mIHVuc2lnbmVkIGxvbmcg c2luY2UgZm9yIHgzMiwgdW5zaWduZWQgbG9uZyBpcwozMi1iaXQgYW5kIHVuc2lnbmVkIGxvbmcg bG9uZyBpcyA2NC1iaXQgYW5kIGl0IGlzIHNhZmUgdG8gdXNlIHVuc2lnbmVkCmxvbmcgbG9uZyBm b3IgNjQtYml0IGludGVnZXIgd2l0aCBHQ0MuCgpkaWZmIC1yIGU3NjYxNDE0NWFlYSAtciBhMTBh MWM0NmI4NTcgbGlidG9tbWF0aC90b21tYXRoLmgKLS0tIGEvbGlidG9tbWF0aC90b21tYXRoLmgJ VGh1IEFwciAxOCAyMjo1Nzo0NyAyMDEzICswODAwCisrKyBiL2xpYnRvbW1hdGgvdG9tbWF0aC5o CVRodSBNYXkgMjMgMTQ6MjE6MTkgMjAxMyAtMDcwMApAQCAtNzMsNyArNzMsNyBAQAogICAgdHlw ZWRlZiBzaWduZWQgbG9uZyBsb25nICAgbG9uZzY0OwogI2VuZGlmCiAKLSAgIHR5cGVkZWYgdW5z aWduZWQgbG9uZyAgICAgIG1wX2RpZ2l0OworICAgdHlwZWRlZiB1bnNpZ25lZCBsb25nIGxvbmcg bXBfZGlnaXQ7CiAgICB0eXBlZGVmIHVuc2lnbmVkIGxvbmcgICAgICBtcF93b3JkIF9fYXR0cmli dXRlX18gKChtb2RlKFRJKSkpOwogCiAgICAjZGVmaW5lIERJR0lUX0JJVCAgICAgICAgICA2MAoj IEhHIGNoYW5nZXNldCBwYXRjaAojIFVzZXIgSC5KLiBMdSA8aGpsLnRvb2xzQGdtYWlsLmNvbT4K IyBEYXRlIDEzNjkzNDQyNDEgMjUyMDAKIyBOb2RlIElEIGM3NTU1YTRjYjdkZWQzYTg4NDA5YmE4 NWY0MDI3YmFhN2FmNWY1MzYKIyBQYXJlbnQgIGExMGExYzQ2Yjg1N2NjOGEzOTIzYzNiYjZkMTUw NGFhMjViNjA1MmYKQ2FzdCB0byBtcF9kaWdpdCB3aGVuIHVwZGF0aW5nICpyaG8KClRoZXJlIGlz CgppbnQKbXBfbW9udGdvbWVyeV9zZXR1cCAobXBfaW50ICogbiwgbXBfZGlnaXQgKiByaG8pCgpX ZSBzaG91bGQgY2FzdCB0byBtcF9kaWdpdCBpbnN0ZWFkIG9mIHVuc2lnbmVkIGxvbmcgd2hlbiB1 cGRhdGluZwoqcmhvIHNpbmNlIG1wX2RpZ2l0IG1heSBiZSB1bnNpZ25lZCBsb25nIGxvbmcgYW5k IHVuc2lnbmVkIGxvbmcgbG9uZwptYXkgYmUgZGlmZmVyZW50IGZyb20gdW5zaWduZWQgbG9uZywg bGlrZSBpbiB4MzIuCgpkaWZmIC1yIGExMGExYzQ2Yjg1NyAtciBjNzU1NWE0Y2I3ZGUgbGlidG9t bWF0aC9ibl9tcF9tb250Z29tZXJ5X3NldHVwLmMKLS0tIGEvbGlidG9tbWF0aC9ibl9tcF9tb250 Z29tZXJ5X3NldHVwLmMJVGh1IE1heSAyMyAxNDoyMToxOSAyMDEzIC0wNzAwCisrKyBiL2xpYnRv bW1hdGgvYm5fbXBfbW9udGdvbWVyeV9zZXR1cC5jCVRodSBNYXkgMjMgMTQ6MjQ6MDEgMjAxMyAt MDcwMApAQCAtNDgsNyArNDgsNyBAQAogI2VuZGlmCiAKICAgLyogcmhvID0gLTEvbSBtb2QgYiAq LwotICAqcmhvID0gKHVuc2lnbmVkIGxvbmcpKCgobXBfd29yZCkxIDw8ICgobXBfd29yZCkgRElH SVRfQklUKSkgLSB4KSAmIE1QX01BU0s7CisgICpyaG8gPSAobXBfZGlnaXQpKCgobXBfd29yZCkx IDw8ICgobXBfd29yZCkgRElHSVRfQklUKSkgLSB4KSAmIE1QX01BU0s7CiAKICAgcmV0dXJuIE1Q X09LQVk7CiB9CiMgSEcgY2hhbmdlc2V0IHBhdGNoCiMgVXNlciBILkouIEx1IDxoamwudG9vbHNA Z21haWwuY29tPgojIERhdGUgMTM2OTM0NDU0MSAyNTIwMAojIE5vZGUgSUQgN2M2NTZlNzA3MWE2 NDEyNjg4YjJmMzBhNTI5YTlhZmFjNmM3YmY1YQojIFBhcmVudCAgYzc1NTVhNGNiN2RlZDNhODg0 MDliYTg1ZjQwMjdiYWE3YWY1ZjUzNgpEZWZpbmUgTFRDX0ZBU1RfVFlQRSB0byB1bnNpZ25lZCBs b25nIGxvbmcgZm9yIF9feDg2XzY0X18KCldlIHNob3VsZCBkZWZpbmUgTFRDX0ZBU1RfVFlQRSB0 byB1bnNpZ25lZCBsb25nIGxvbmcgaW5zdGVhZCBvZiB1bnNpZ25lZApsb25nIGlmIF9feDg2XzY0 X18gdG8gc3VwcG9ydCB4MzIgd2hlcmUgdW5zaWduZWQgbG9uZyBsb25nIGlzIDY0LWJpdAphbmQg dW5zaWduZWQgbG9uZyBpcyAzMi1iaXQuCgpkaWZmIC1yIGM3NTU1YTRjYjdkZSAtciA3YzY1NmU3 MDcxYTYgbGlidG9tY3J5cHQvc3JjL2hlYWRlcnMvdG9tY3J5cHRfY2ZnLmgKLS0tIGEvbGlidG9t Y3J5cHQvc3JjL2hlYWRlcnMvdG9tY3J5cHRfY2ZnLmgJVGh1IE1heSAyMyAxNDoyNDowMSAyMDEz IC0wNzAwCisrKyBiL2xpYnRvbWNyeXB0L3NyYy9oZWFkZXJzL3RvbWNyeXB0X2NmZy5oCVRodSBN YXkgMjMgMTQ6Mjk6MDEgMjAxMyAtMDcwMApAQCAtNzQsNyArNzQsNyBAQAogICAgI2RlZmluZSBF TkRJQU5fTElUVExFCiAgICAjZGVmaW5lIEVORElBTl82NEJJVFdPUkQKICAgICNkZWZpbmUgTFRD X0ZBU1QKLSAgICNkZWZpbmUgTFRDX0ZBU1RfVFlQRSAgICB1bnNpZ25lZCBsb25nCisgICAjZGVm aW5lIExUQ19GQVNUX1RZUEUgICAgdW5zaWduZWQgbG9uZyBsb25nCiAjZW5kaWYKIAogLyogZGV0 ZWN0IFBQQzMyICovCiMgSEcgY2hhbmdlc2V0IHBhdGNoCiMgVXNlciBILkouIEx1IDxoamwudG9v bHNAZ21haWwuY29tPgojIERhdGUgMTM2OTM0NDczMCAyNTIwMAojIE5vZGUgSUQgYTdkNDY5MDE1 OGZhZTRlZGUyYzRlNWI1NjIzM2U4MzczMGJmMzhlZQojIFBhcmVudCAgN2M2NTZlNzA3MWE2NDEy Njg4YjJmMzBhNTI5YTlhZmFjNmM3YmY1YQpVc2UgdW5zaWduZWQgbG9uZyBsb25nIGFhcyB1bnNp Z25lZCA2NC1iaXQgaW50ZWdlciBmb3IgeDg2LTY0IEdDQwoKV2Ugc2hvdWxkIHVzZSB1bnNpZ25l ZCBsb25nIGxvbmcgaW5zdGVhZCBvZiB1bnNpZ25lZCBsb25nIGFzIHVuc2lnbmVkCjY0LWJpdCBp bnRlZ2VyIGZvciB4ODYtNjQgR0NDIHRvIHN1cHBvcnQgeDMyIHdoZXJlIHVuc2lnbmVkIGxvbmcg aXMKMzItYml0LgoKZGlmZiAtciA3YzY1NmU3MDcxYTYgLXIgYTdkNDY5MDE1OGZhIGxpYnRvbWNy eXB0L3NyYy9oZWFkZXJzL3RvbWNyeXB0X21hY3Jvcy5oCi0tLSBhL2xpYnRvbWNyeXB0L3NyYy9o ZWFkZXJzL3RvbWNyeXB0X21hY3Jvcy5oCVRodSBNYXkgMjMgMTQ6Mjk6MDEgMjAxMyAtMDcwMAor KysgYi9saWJ0b21jcnlwdC9zcmMvaGVhZGVycy90b21jcnlwdF9tYWNyb3MuaAlUaHUgTWF5IDIz IDE0OjMyOjEwIDIwMTMgLTA3MDAKQEAgLTM0Myw3ICszNDMsNyBAQAogLyogNjQtYml0IFJvdGF0 ZXMgKi8KICNpZiAhZGVmaW5lZChfX1NUUklDVF9BTlNJX18pICYmIGRlZmluZWQoX19HTlVDX18p ICYmIGRlZmluZWQoX194ODZfNjRfXykgJiYgIWRlZmluZWQoTFRDX05PX0FTTSkKIAotc3RhdGlj IGlubGluZSB1bnNpZ25lZCBsb25nIFJPTDY0KHVuc2lnbmVkIGxvbmcgd29yZCwgaW50IGkpCitz dGF0aWMgaW5saW5lIHVuc2lnbmVkIGxvbmcgbG9uZyBST0w2NCh1bnNpZ25lZCBsb25nIGxvbmcg d29yZCwgaW50IGkpCiB7CiAgICBhc20oInJvbHEgJSVjbCwlMCIKICAgICAgIDoiPXIiICh3b3Jk KQpAQCAtMzUxLDcgKzM1MSw3IEBACiAgICByZXR1cm4gd29yZDsKIH0KIAotc3RhdGljIGlubGlu ZSB1bnNpZ25lZCBsb25nIFJPUjY0KHVuc2lnbmVkIGxvbmcgd29yZCwgaW50IGkpCitzdGF0aWMg aW5saW5lIHVuc2lnbmVkIGxvbmcgbG9uZyBST1I2NCh1bnNpZ25lZCBsb25nIGxvbmcgd29yZCwg aW50IGkpCiB7CiAgICBhc20oInJvcnEgJSVjbCwlMCIKICAgICAgIDoiPXIiICh3b3JkKQpAQCAt MzYxLDcgKzM2MSw3IEBACiAKICNpZm5kZWYgTFRDX05PX1JPTEMKIAotc3RhdGljIGlubGluZSB1 bnNpZ25lZCBsb25nIFJPTDY0Yyh1bnNpZ25lZCBsb25nIHdvcmQsIGNvbnN0IGludCBpKQorc3Rh dGljIGlubGluZSB1bnNpZ25lZCBsb25nIGxvbmcgUk9MNjRjKHVuc2lnbmVkIGxvbmcgbG9uZyB3 b3JkLCBjb25zdCBpbnQgaSkKIHsKICAgIGFzbSgicm9scSAlMiwlMCIKICAgICAgIDoiPXIiICh3 b3JkKQpAQCAtMzY5LDcgKzM2OSw3IEBACiAgICByZXR1cm4gd29yZDsKIH0KIAotc3RhdGljIGlu bGluZSB1bnNpZ25lZCBsb25nIFJPUjY0Yyh1bnNpZ25lZCBsb25nIHdvcmQsIGNvbnN0IGludCBp KQorc3RhdGljIGlubGluZSB1bnNpZ25lZCBsb25nIGxvbmcgUk9SNjRjKHVuc2lnbmVkIGxvbmcg bG9uZyB3b3JkLCBjb25zdCBpbnQgaSkKIHsKICAgIGFzbSgicm9ycSAlMiwlMCIKICAgICAgIDoi PXIiICh3b3JkKQo=