<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>4636</bug_id>
          
          <creation_ts>2013-06-11 12:47:27 +0000</creation_ts>
          <short_desc>Hob should make sure comments are added on the next line</short_desc>
          <delta_ts>2013-06-27 11:39:00 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>Hob</product>
          <component>hob</component>
          <version>1.5</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.5</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Stoicescu Cornel">corneliux.stoicescu</reporter>
          <assigned_to name="Cristiana Voicu">cristiana.voicu</assigned_to>
          <cc>belen.barros.pena</cc>
    
    <cc>cristian.iorga</cc>
    
    <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
    
    <cc>valentin.popa</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>---</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>33754</commentid>
    <comment_count>0</comment_count>
    <who name="Stoicescu Cornel">corneliux.stoicescu</who>
    <bug_when>2013-06-11 12:47:27 +0000</bug_when>
    <thetext>1) clone poky
2) checkout master:a62aed41f2d8f874f7ae24d0e5be5dbc66ea2199
3) source oe-init-build-env
4) edit local.conf and add a new line of configuration (ex: LICENSE_FLAGS_WHITELIST = &quot;license_emgd-driver-bin&quot;)
NOTE: -use a text editor that does not add &quot;\n&quot; as default last character (ex: mc)
      -make sure the last character of the file is on the quotation mark from the above line
5) launch hob
6) add a new layer
Notice parse error (see bug 4635 ). It says bitbake cannot parse LICENSE_FLAGS_WHITELIST = &quot;license_emgd-driver-bin&quot;#added by bitbake

7) close hob and open local.conf
Notice that HOB added the comment inline with the last statement while all other such comments are on a new line:

LICENSE_FLAGS_WHITELIST = &quot;license_emgd-driver-bin&quot;#added by bitbake
DL_DIR = &quot;/home/lserban/work/poky/build/downloads&quot;
#added by bitbake
SSTATE_DIR = &quot;/home/lserban/work/poky/build/sstate-cache&quot;
#added by bitbake
SSTATE_MIRRORS = &quot;&quot;

Expected outcome:
1) HOB should add all &quot;#added by bitbake&quot; comments the same way, on a new line
2) If the above expectation is not valid, it should add comments according to the resolution of bug 4635 so that it will not give off parse errors.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>34175</commentid>
    <comment_count>1</comment_count>
    <who name="Cristiana Voicu">cristiana.voicu</who>
    <bug_when>2013-06-27 10:59:22 +0000</bug_when>
    <thetext>merged to master
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=4852c4f6a109e64a0b3e342db733eb588389afcc</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>34178</commentid>
    <comment_count>2</comment_count>
    <who name="Stoicescu Cornel">corneliux.stoicescu</who>
    <bug_when>2013-06-27 11:39:00 +0000</bug_when>
    <thetext>Verified in master:4852c4f6a109e64a0b3e342db733eb588389afcc</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>