<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>4841</bug_id>
          
          <creation_ts>2013-07-11 06:10:42 +0000</creation_ts>
          <short_desc>meta/conf/machine/include/tune-ppce300c3.inc: should be fpu-hard</short_desc>
          <delta_ts>2014-10-17 11:39:50 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>BSPs</product>
          <component>bsps-oe-core</component>
          <version>1.4.1</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.7 M4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Roderick">myopiate</reporter>
          <assigned_to name="Bruce Ashfield">bruce.ashfield</assigned_to>
          <cc>alexandru.c.georgescu</cc>
    
    <cc>bluelightning</cc>
    
    <cc>kexin.hao</cc>
    
    <cc>richard.purdie</cc>
          
          <qa_contact name="Mihail Stanciu">stanciux.mihail</qa_contact>
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>34496</commentid>
    <comment_count>0</comment_count>
    <who name="Roderick">myopiate</who>
    <bug_when>2013-07-11 06:10:42 +0000</bug_when>
    <thetext>The e300c3 cores has an fpu and supports floating point instructions.  I&apos;ve confirmed that -mhard-float compiles and boots core-image-minimal with no floating point related issue.  I&apos;ve also compiled a program generating a floating point instruction and run it on the core I have in front of me (mpc8314e) 

The e300c2 does not have an fpu.  Maybe it is just a copy and past error.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>34515</commentid>
    <comment_count>1</comment_count>
    <who name="Darren Hart">dvhart</who>
    <bug_when>2013-07-11 13:59:20 +0000</bug_when>
    <thetext>When you say copy and paste error - where? Which document/file?

What are you looking for as a resolution here? For a new machine definition with a tune file using -mhard-float?

My ppc hardware is broken currently. Perhaps you would care to provide a patch and test results?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>34523</commentid>
    <comment_count>2</comment_count>
      <attachid>1324</attachid>
    <who name="Roderick">myopiate</who>
    <bug_when>2013-07-11 22:52:22 +0000</bug_when>
    <thetext>Created attachment 1324
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>34524</commentid>
    <comment_count>3</comment_count>
    <who name="Roderick">myopiate</who>
    <bug_when>2013-07-11 23:04:56 +0000</bug_when>
    <thetext>(In reply to comment #1)

I apologize that my report wasn&apos;t detailed enough.

&gt; When you say copy and paste error - where? Which document/file?

meta/conf/machine/include/tune-ppce300c2.inc .  As I explained, the e300c2 core does not have an fpu, the e300c3 does.

http://www.freescale.com/files/32bit/doc/ref_manual/e300coreRM.pdf

&gt; What are you looking for as a resolution here? For a new machine definition
&gt; with a tune file using -mhard-float?

To help ;-).  If it has an fpu, it would be nice to use it.

&gt; My ppc hardware is broken currently. Perhaps you would care to provide a
&gt; patch and test results?

I do not have MPC8315rdb, but a board based on the MPC8314e Soc, which also has an  e300c3 core.   Patch proposed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>45848</commentid>
    <comment_count>4</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2014-09-25 15:15:52 +0000</bug_when>
    <thetext>This seems to have slipped through the cracks. Kevin is this something you could check into?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>45914</commentid>
    <comment_count>5</comment_count>
    <who name="Kevin Hao">kexin.hao</who>
    <bug_when>2014-09-28 05:47:48 +0000</bug_when>
    <thetext>This issue has been fixed in 1.7 by the following commit:
commit 3e528d3e4bc542ca2f654c54363c56af0fb9f61b
Author: Mats Kärrman &lt;Mats.Karrman@tritech.se&gt;
Date:   Tue Apr 1 16:20:34 2014 +0000

    Make ppce300c3 tune hard-float by default
    
    The tuning file for PowerPC e300c3 is soft-float. In OE-classic it was hard-
    float and it should be as the c3 has an fpu. I have modified the tuning file
    to include both a hard-float version (using the existing ppce300c3 name) and
    an optional soft-float version (called ppce300c3-nf).
    
    The following patch also passes a &quot;--with-cpu=e300c3&quot; argument to GLIBC.
    For this to have any effect the sqrt/sqrtf implementations added by the
    &quot;glibc.fix_sqrt2.patch&quot; are required and also an additional &quot;Implies&quot; file
    (added to the mentioned patch as a separate patch for eglibc_2.19).
    
    Tested with eglibc 2.19 on PowerPC MPC5125.
    
    (From OE-Core rev: 9d502ca8551fd461f869395b1b7e62d6dcf59a84)
    
    Signed-off-by: Mats Karrman &lt;mats.karrman@tritech.se&gt;
    Signed-off-by: Richard Purdie &lt;richard.purdie@linuxfoundation.org&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>46250</commentid>
    <comment_count>6</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2014-10-09 15:39:08 +0000</bug_when>
    <thetext>http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=3e528d3e4bc542ca2f654c54363c56af0fb9f61b</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>46412</commentid>
    <comment_count>7</comment_count>
    <who name="Mihail Stanciu">stanciux.mihail</who>
    <bug_when>2014-10-17 11:39:50 +0000</bug_when>
    <thetext>Verified on master: ccf5a4d2342c4fd40e4e0b332ea7e34e0bf175d4</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>1324</attachid>
            <date>2013-07-11 22:52:22 +0000</date>
            <delta_ts>2013-07-11 22:52:22 +0000</delta_ts>
            <desc>proposed patch</desc>
            <filename>tune-ppce300c3.patch</filename>
            <type>application/octet-stream</type>
            <size>697</size>
            <attacher name="Roderick">myopiate</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL21ldGEvY29uZi9tYWNoaW5lL2luY2x1ZGUvdHVuZS1wcGNlMzAwYzMuaW5j
IGIvbWV0YS9jb25mL21hY2hpbmUvaW5jbHVkZS90dW5lLXBwY2UzMDBjMy5pbmMKaW5kZXggOTQz
MTIyMi4uNzAyMWJhNyAxMDA2NDQKLS0tIGEvbWV0YS9jb25mL21hY2hpbmUvaW5jbHVkZS90dW5l
LXBwY2UzMDBjMy5pbmMKKysrIGIvbWV0YS9jb25mL21hY2hpbmUvaW5jbHVkZS90dW5lLXBwY2Uz
MDBjMy5pbmMKQEAgLTYsNiArNiw2IEBAIFRVTkVWQUxJRFtwcGNlMzAwYzNdID0gIkVuYWJsZSBw
cGNlMzAwYzMgc3BlY2lmaWMgcHJvY2Vzc29yIG9wdGltaXphdGlvbnMiCiBUVU5FX0NDQVJHUyAu
PSAiJHtAYmIudXRpbHMuY29udGFpbnMoIlRVTkVfRkVBVFVSRVMiLCAicHBjZTMwMGMzIiwgIiAt
bWNwdT1lMzAwYzMiLCAiIiwgZCl9IgogCiBBVkFJTFRVTkVTICs9ICJwcGNlMzAwYzMiCi1UVU5F
X0ZFQVRVUkVTX3R1bmUtcHBjZTMwMGMzID0gIm0zMiBmcHUtc29mdCBwcGNlMzAwYzMiCitUVU5F
X0ZFQVRVUkVTX3R1bmUtcHBjZTMwMGMzID0gIm0zMiBmcHUtaGFyZCBwcGNlMzAwYzMiCiBUVU5F
X1BLR0FSQ0hfdHVuZS1wcGNlMzAwYzMgPSAicHBjZTMwMGMzIgogUEFDS0FHRV9FWFRSQV9BUkNI
U190dW5lLXBwY2UzMDBjMyA9ICIke1BBQ0tBR0VfRVhUUkFfQVJDSFNfdHVuZS1wb3dlcnBjLW5m
fSBwcGNlMzAwYzMiCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>