4877 2013-07-19 11:01:54 +0000 'bitbake -C' does not throw error for invalid task 2013-10-01 14:23:04 +0000 1 1 7 Build System, Metadata & Runtime BitBake bitbake 1.5 x86 Multiple VERIFIED FIXED Low normal 1.5 1 corneliux.stoicescu petter bluelightning petter poky.bs.watcher poky.watcher sgw --- --- No (bug/feature does not impact docs) oldest_to_newest 34701 0 1340 corneliux.stoicescu 2013-07-19 11:01:54 +0000 Created attachment 1340 cooker log Poky configuration: Build Configuration: BB_VERSION = "1.19.1" BUILD_SYS = "x86_64-linux" NATIVELSBSTRING = "Ubuntu-12.04" TARGET_SYS = "x86_64-poky-linux" MACHINE = "qemux86-64" DISTRO = "poky" DISTRO_VERSION = "1.4+snapshot-20130719" TUNE_FEATURES = "m64" TARGET_FPU = "" meta meta-yocto meta-yocto-bsp = "master:31e6eee860b5f9f4ac9ef0889bcff5648de6e3f9" Steps to reproduce: " lserban@computer1:~/work/poky/build$ bitbake man lserban@computer1:~/work/poky/build$ bitbake -C invalid_task man NOTE: Resolving any missing task queue dependencies NOTE: Preparing runqueue NOTE: Tainting hash to force rebuild of task /home/lserban/work/poky/meta/recipes-extended/man/man_1.6g.bb, do_invalid_task NOTE: Executing SetScene Tasks NOTE: Executing RunQueue Tasks NOTE: Tasks Summary: Attempted 782 tasks of which 782 didn't need to be rerun and all succeeded. lserban@computer1:~/work/poky/build$ bitbake -cclean man lserban@computer1:~/work/poky/build$ bitbake -C invalid_task man NOTE: Resolving any missing task queue dependencies NOTE: Preparing runqueue NOTE: Tainting hash to force rebuild of task /home/lserban/work/poky/meta/recipes-extended/man/man_1.6g.bb, do_invalid_task NOTE: Executing SetScene Tasks NOTE: Executing RunQueue Tasks NOTE: Tasks Summary: Attempted 782 tasks of which 780 didn't need to be rerun and all succeeded. " See attached the cooker log for the last command. Even though the task does not exist, the man package is built. EXPECTED OUTCOME: Error should be presented for invalid task. 34793 1 petter 2013-07-23 21:54:52 +0000 I might be wrong, but I don't think this is a fault (perhapes It could be a warning or note). I think it's supposed to work like this. If for example 'bitbake -c invalid_task man' was successful (and no addtask for do_invalid_task exists..), it should have been a fault. But when giving bitbake '-C' it will only remove a stamp file and if the stamp file don't exists nothing bad happens except that no task has a dependency to 'invalid_task' so nothing needs to be rebuild.. So except if you specify that a task is 'nostamp', I think it's OK that no error occurs. For example do_listtasks (when it should be a fault) $ bitbake -C listtasks man ... ERROR: Task do_listtasks is marked nostamp, cannot invalidate this task Perhapes a notification could be added e.g. "this task don't exist, so it will not have any effect". Comments about this? 34796 2 corneliux.stoicescu 2013-07-24 08:02:29 +0000 A notification sounds good to me as long as the user understands why it's not an error or a warning from it. 34800 3 petter 2013-07-24 08:58:00 +0000 (In reply to comment #2) > A notification sounds good to me as long as the user understands why it's > not an error or a warning from it. After some thoughts I think a warning is more correct after all. Maybe something like: ---- NOTE: Preparing runqueue WARNING: Task do_invalid_task does not exist, invalidate this ta sk will have no effect NOTE: Tainting hash to force rebuild of task... ... ---- 34802 4 petter 2013-07-24 10:11:51 +0000 Change to accepted since this is clearly a bug. Even if error might be a little bit to hard, at least a warning or note should be displayed to the user. 34803 5 petter 2013-07-24 10:20:36 +0000 Started with a solution that adds a check in 'bitbake/lib/bb/runqueue.py' and displays a warning if the task does not exists for the target/recipe. Suggestion (as in my previous comment). ---- NOTE: Preparing runqueue WARNING: Task do_invalid_task does not exist, invalidate this ta sk will have no effect NOTE: Tainting hash to force rebuild of task... ... ---- 35066 6 petter 2013-07-29 09:26:38 +0000 Send for review: The following changes since commit 67864ca79da08df752487a3a4e1a975546da123d: systemd: Remove systemd_unitdir if systemd is not in distro features (2013-07-24 11:35:39 +0100) are available in the git repository at: git://git.yoctoproject.org/poky-contrib petmab/bug/4877 http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=petmab/bug/4877 35568 7 petter 2013-08-10 13:06:20 +0000 Fixed in commit: http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=bd1c441a210cae03fb6006c996227211cc29056b 37419 8 corneliux.stoicescu 2013-10-01 14:23:04 +0000 When issuing the command in step 2) from description, the user receives a coherent warning message: WARNING: Task do_invalid_task does not exist, invalidating this task will have no effect Setting to VERIFIED for: poky master:2f64fae60b3f61a2c45dc9e5314d2d16b1e64605 1340 2013-07-19 11:01:54 +0000 2013-07-19 11:01:54 +0000 cooker log cooker_log application/octet-stream 2342 corneliux.stoicescu CkJ1aWxkIENvbmZpZ3VyYXRpb246CkJCX1ZFUlNJT04gICAgICAgID0gIjEuMTkuMSIKQlVJTERf U1lTICAgICAgICAgPSAieDg2XzY0LWxpbnV4IgpOQVRJVkVMU0JTVFJJTkcgICA9ICJVYnVudHUt MTIuMDQiClRBUkdFVF9TWVMgICAgICAgID0gIng4Nl82NC1wb2t5LWxpbnV4IgpNQUNISU5FICAg ICAgICAgICA9ICJxZW11eDg2LTY0IgpESVNUUk8gICAgICAgICAgICA9ICJwb2t5IgpESVNUUk9f VkVSU0lPTiAgICA9ICIxLjQrc25hcHNob3QtMjAxMzA3MTkiClRVTkVfRkVBVFVSRVMgICAgID0g Im02NCIKVEFSR0VUX0ZQVSAgICAgICAgPSAiIgptZXRhICAgICAgICAgICAgICAKbWV0YS15b2N0 byAgICAgICAgCm1ldGEteW9jdG8tYnNwICAgID0gIm1hc3RlcjozMWU2ZWVlODYwYjVmOWY0YWM5 ZWYwODg5YmNmZjU2NDhkZTZlM2Y5IgoKTk9URTogUmVzb2x2aW5nIGFueSBtaXNzaW5nIHRhc2sg cXVldWUgZGVwZW5kZW5jaWVzCk5PVEU6IFByZXBhcmluZyBydW5xdWV1ZQpOT1RFOiBUYWludGlu ZyBoYXNoIHRvIGZvcmNlIHJlYnVpbGQgb2YgdGFzayAvaG9tZS9sc2VyYmFuL3dvcmsvcG9reS9t ZXRhL3JlY2lwZXMtZXh0ZW5kZWQvbWFuL21hbl8xLjZnLmJiLCBkb19pbnZhbGlkX3Rhc2sKTk9U RTogRXhlY3V0aW5nIFNldFNjZW5lIFRhc2tzCk5PVEU6IFJ1bm5pbmcgc2V0c2NlbmUgdGFzayAy NzYgb2YgMjgwICgvaG9tZS9sc2VyYmFuL3dvcmsvcG9reS9tZXRhL3JlY2lwZXMtZXh0ZW5kZWQv bWFuL21hbl8xLjZnLmJiLCBkb19wb3B1bGF0ZV9zeXNyb290X3NldHNjZW5lKQpOT1RFOiBSdW5u aW5nIHNldHNjZW5lIHRhc2sgMjc3IG9mIDI4MCAoL2hvbWUvbHNlcmJhbi93b3JrL3Bva3kvbWV0 YS9yZWNpcGVzLWV4dGVuZGVkL21hbi9tYW5fMS42Zy5iYiwgZG9fcG9wdWxhdGVfbGljX3NldHNj ZW5lKQpOT1RFOiBSdW5uaW5nIHNldHNjZW5lIHRhc2sgMjc4IG9mIDI4MCAoL2hvbWUvbHNlcmJh bi93b3JrL3Bva3kvbWV0YS9yZWNpcGVzLWV4dGVuZGVkL21hbi9tYW5fMS42Zy5iYiwgZG9fcGFj a2FnZV93cml0ZV9ycG1fc2V0c2NlbmUpCk5PVEU6IHJlY2lwZSBtYW4tMS42Zy1yMTogdGFzayBk b19wb3B1bGF0ZV9zeXNyb290X3NldHNjZW5lOiBTdGFydGVkCk5PVEU6IHJlY2lwZSBtYW4tMS42 Zy1yMTogdGFzayBkb19wb3B1bGF0ZV9saWNfc2V0c2NlbmU6IFN0YXJ0ZWQKTk9URTogcmVjaXBl IG1hbi0xLjZnLXIxOiB0YXNrIGRvX3BhY2thZ2Vfd3JpdGVfcnBtX3NldHNjZW5lOiBTdGFydGVk Ck5PVEU6IHJlY2lwZSBtYW4tMS42Zy1yMTogdGFzayBkb19wb3B1bGF0ZV9zeXNyb290X3NldHNj ZW5lOiBTdWNjZWVkZWQKTk9URTogcmVjaXBlIG1hbi0xLjZnLXIxOiB0YXNrIGRvX3BhY2thZ2Vf d3JpdGVfcnBtX3NldHNjZW5lOiBTdWNjZWVkZWQKTk9URTogcmVjaXBlIG1hbi0xLjZnLXIxOiB0 YXNrIGRvX3BvcHVsYXRlX2xpY19zZXRzY2VuZTogU3VjY2VlZGVkCk5PVEU6IFJ1bm5pbmcgc2V0 c2NlbmUgdGFzayAyNzkgb2YgMjgwICgvaG9tZS9sc2VyYmFuL3dvcmsvcG9reS9tZXRhL3JlY2lw ZXMtZXh0ZW5kZWQvbWFuL21hbl8xLjZnLmJiLCBkb19wYWNrYWdlZGF0YV9zZXRzY2VuZSkKTk9U RTogcmVjaXBlIG1hbi0xLjZnLXIxOiB0YXNrIGRvX3BhY2thZ2VkYXRhX3NldHNjZW5lOiBTdGFy dGVkCk5PVEU6IHJlY2lwZSBtYW4tMS42Zy1yMTogdGFzayBkb19wYWNrYWdlZGF0YV9zZXRzY2Vu ZTogU3VjY2VlZGVkCk5PVEU6IFJ1bm5pbmcgc2V0c2NlbmUgdGFzayAyODAgb2YgMjgwICgvaG9t ZS9sc2VyYmFuL3dvcmsvcG9reS9tZXRhL3JlY2lwZXMtZXh0ZW5kZWQvbWFuL21hbl8xLjZnLmJi LCBkb19wYWNrYWdlX3NldHNjZW5lKQpOT1RFOiByZWNpcGUgbWFuLTEuNmctcjE6IHRhc2sgZG9f cGFja2FnZV9zZXRzY2VuZTogU3RhcnRlZApOT1RFOiByZWNpcGUgbWFuLTEuNmctcjE6IHRhc2sg ZG9fcGFja2FnZV9zZXRzY2VuZTogU3VjY2VlZGVkCk5PVEU6IEV4ZWN1dGluZyBSdW5RdWV1ZSBU YXNrcwpOT1RFOiBSdW5uaW5nIG5vZXhlYyB0YXNrIDc3OSBvZiA3ODIgKElEOiA4LCAvaG9tZS9s c2VyYmFuL3dvcmsvcG9reS9tZXRhL3JlY2lwZXMtZXh0ZW5kZWQvbWFuL21hbl8xLjZnLmJiLCBk b19wYWNrYWdlX3dyaXRlKQpOT1RFOiBSdW5uaW5nIG5vZXhlYyB0YXNrIDc4MiBvZiA3ODIgKElE OiAxMSwgL2hvbWUvbHNlcmJhbi93b3JrL3Bva3kvbWV0YS9yZWNpcGVzLWV4dGVuZGVkL21hbi9t YW5fMS42Zy5iYiwgZG9fYnVpbGQpCk5PVEU6IFRhc2tzIFN1bW1hcnk6IEF0dGVtcHRlZCA3ODIg dGFza3Mgb2Ygd2hpY2ggNzgwIGRpZG4ndCBuZWVkIHRvIGJlIHJlcnVuIGFuZCBhbGwgc3VjY2Vl ZGVkLgo=