<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>5100</bug_id>
          
          <creation_ts>2013-09-03 07:07:11 +0000</creation_ts>
          <short_desc>Use &quot;yocto-kernel patch add&quot; added a patch, then core-image-sato build hangs.</short_desc>
          <delta_ts>2013-10-04 10:58:50 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>Meta-yocto</product>
          <component>meta-yocto</component>
          <version>1.5</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.5 M5</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ning Zhang">ning.zhang</reporter>
          <assigned_to name="Bruce Ashfield">bruce.ashfield</assigned_to>
          <cc>alexandrux.palalau</cc>
    
    <cc>bruce.ashfield</cc>
    
    <cc>ke.zou</cc>
    
    <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
    
    <cc>sgw</cc>
    
    <cc>tom.zanussi</cc>
    
    <cc>yi.zhao</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Don&apos;t know</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>36170</commentid>
    <comment_count>0</comment_count>
      <attachid>1453</attachid>
    <who name="Ning Zhang">ning.zhang</who>
    <bug_when>2013-09-03 07:07:11 +0000</bug_when>
    <thetext>Created attachment 1453
patch file

Poky: master: 5745e45b18e5099e94b4d5a73bc97dc6d4cdc91f

Steps:
1. Create a new bsp with cli &quot;yocto-bsp create myqemux86 qemu&quot;, keep all options as default.
2. Modify conf/bblayers.conf, added &quot;meta-myqemux86&quot; to BBlayers
3. MOdify conf/local.conf, modify machine to &quot;myqemux86&quot;
4. bitbake core-image-sato. This could build success.
5. Download patch file from: https://wiki.yoctoproject.org/wiki/images/c/c9/Yocto-testmod.patch. Or download from attachment.
6. Install the patch with cli: yocto-kernel patch add myqemux86 ~/Yocto-testmod.patch
7. Add some kernel config with cli: yocto-kernel config add myqemux86 CONFIG_MISC_DEVICES=y CONFIG_YOCTO_TESTMOD=y CONFIG_FTRACE_SYSCALLS=y CONFIG_SCHED_TRACER=y CONFIG_IRQSOFF_TRACER=y CONFIG_PREEMPT_TRACER=y
8. Rebuild image:  bitbake core-image-sato

The build hangs at task &quot;linux-yocto-3.8.13+gitAUTOINC+e7f42a416a_f20047520a-r4.2.3&quot;, even more than 17 hours still not complete.

Check log file, tmp/work/myqemux86-poky-linux/linux-yocto/3.8.13+gitAUTOINC+e7f42a416a_f20047520a-r4.2.3/temp/log.do_patch, it has lots of &quot;No author found in&quot; lines. And the line number still increasing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36206</commentid>
    <comment_count>1</comment_count>
    <who name="Tom Zanussi">tom.zanussi</who>
    <bug_when>2013-09-03 17:55:31 +0000</bug_when>
    <thetext>It looks like this might be a regression in the kernel tools.

From linux-yocto log.do_patch, this goes on forever:

No author found in 
No author found in 
No author found in 
No author found in 
No author found in 
No author found in 
.
.
.

Possibly an infinite loop in git-s2q introduced by the following commit?

commit f9e85358bd9d6e583253523c9182268f64bafc27
Author: Paul Gortmaker &lt;paul.gortmaker@windriver.com&gt;
Date:   Thu Aug 22 15:14:57 2013 -0400

    kgit-s2q: continue if git-am returns zero


Let&apos;s check with Bruce and see if this could be the problem before digging further..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36207</commentid>
    <comment_count>2</comment_count>
    <who name="Bruce Ashfield">bruce.ashfield</who>
    <bug_when>2013-09-03 18:04:05 +0000</bug_when>
    <thetext>The tools have changed a lot .. badly formatted patches are always
a challenge. I&apos;ll take care of testing this out and coming up with a fix. 

We don&apos;t want to regress the rest of the cases, fixing this!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36208</commentid>
    <comment_count>3</comment_count>
    <who name="Tom Zanussi">tom.zanussi</who>
    <bug_when>2013-09-03 18:06:38 +0000</bug_when>
    <thetext>I think the patch is good, I&apos;m not sure what could be badly formatted about it, but anyway yeah, it&apos;s never caused a blip before..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36210</commentid>
    <comment_count>4</comment_count>
    <who name="Paul Gortmaker">paulg</who>
    <bug_when>2013-09-03 18:38:59 +0000</bug_when>
    <thetext>Some comments:

1) My commit f9e85358bd9d6e was a code relocation block, and not a functional change, so it is irrelevant here.

2) The &quot;No author found in &lt;missing text&gt;&quot; is because there is a left over, unassigned &quot;patch_name&quot; variable that has been in existence since this code originally borrowed the same block of code from git quilt-import.

3) The block of code above is only ever entered when the system is fed a garbage commit that has no date, no author and/or no subject, in an attempt to get that info interactively.

4) We&apos;ll want to delete that possibility of an interactive step, since it doesn&apos;t bode well with automated builds.

5) Finally, the patch posted here is just that -- a patch and not a commit.  Hence it does not have the required fields of date/author/subject and is destined to fail since it is invalid input.

We&apos;ll want to fix (i.e. remove) the possibility of going into an interactive phase, but that does not change the fact the patch in question here is invalid.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36211</commentid>
    <comment_count>5</comment_count>
    <who name="Tom Zanussi">tom.zanussi</who>
    <bug_when>2013-09-03 18:52:18 +0000</bug_when>
    <thetext>I didn&apos;t blame that commit, just a possibility pointed out by git blame.

I didn&apos;t realize that all patches in Yocto needed to have Author, Date and Subject in order to apply.

I&apos;ll have to verify, but I&apos;m pretty sure this test case passed before.  QA should be able confirm or not.  If not, they should be using a &apos;valid patch&apos;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36222</commentid>
    <comment_count>6</comment_count>
    <who name="Bruce Ashfield">bruce.ashfield</who>
    <bug_when>2013-09-04 01:50:54 +0000</bug_when>
    <thetext>I have a fix, will send the pull request shortly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36306</commentid>
    <comment_count>7</comment_count>
    <who name="Bruce Ashfield">bruce.ashfield</who>
    <bug_when>2013-09-05 01:29:39 +0000</bug_when>
    <thetext>This is fixed, but I&apos;m waiting for the rc build to be done, before submitting the
fix, since it&apos;ll just wait.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>37614</commentid>
    <comment_count>8</comment_count>
    <who name="Alexandru Palalau">alexandrux.palalau</who>
    <bug_when>2013-10-04 10:58:50 +0000</bug_when>
    <thetext>Verified it on master branch.
Commit ID: e7a20238dc73bb449f15feaf0dead51daf796184
3.10 kernel, though</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>1453</attachid>
            <date>2013-09-03 07:07:11 +0000</date>
            <delta_ts>2013-09-03 07:07:11 +0000</delta_ts>
            <desc>patch file</desc>
            <filename>Yocto-testmod.patch</filename>
            <type>text/plain</type>
            <size>2319</size>
            <attacher name="Ning Zhang">ning.zhang</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWlzYy9LY29uZmlnIGIvZHJpdmVycy9taXNjL0tjb25maWcK
aW5kZXggYjE1MWI3Yy4uYWMyNTk0NCAxMDA2NDQKLS0tIGEvZHJpdmVycy9taXNjL0tjb25maWcK
KysrIGIvZHJpdmVycy9taXNjL0tjb25maWcKQEAgLTM3Myw2ICszNzMsMTEgQEAgY29uZmlnIEhN
QzYzNTIKIAkgIFRoaXMgZHJpdmVyIHByb3ZpZGVzIHN1cHBvcnQgZm9yIHRoZSBIb25leXdlbGwg
SE1DNjM1MiBjb21wYXNzLAogCSAgcHJvdmlkaW5nIGNvbmZpZ3VyYXRpb24gYW5kIGhlYWRpbmcg
ZGF0YSB2aWEgc3lzZnMuCiAKK2NvbmZpZyBZT0NUT19URVNUTU9ECisJdHJpc3RhdGUgIllvY3Rv
IFRlc3QgRHJpdmVyIgorCWhlbHAKKwkgIFRoaXMgZHJpdmVyIHByb3ZpZGVzIGEgc2lsbHkgbWVz
c2FnZSBmb3IgdGVzdGluZyBZb2N0by4KKwogY29uZmlnIEVQOTNYWF9QV00KIAl0cmlzdGF0ZSAi
RVA5M3h4IFBXTSBzdXBwb3J0IgogCWRlcGVuZHMgb24gQVJDSF9FUDkzWFgKZGlmZiAtLWdpdCBh
L2RyaXZlcnMvbWlzYy9NYWtlZmlsZSBiL2RyaXZlcnMvbWlzYy9NYWtlZmlsZQppbmRleCAyMTI5
Mzc3Li42MmUxOTMwIDEwMDY0NAotLS0gYS9kcml2ZXJzL21pc2MvTWFrZWZpbGUKKysrIGIvZHJp
dmVycy9taXNjL01ha2VmaWxlCkBAIC0zNyw2ICszNyw3IEBAIG9iai0kKENPTkZJR19EUzE2ODIp
CQkrPSBkczE2ODIubwogb2JqLSQoQ09ORklHX1RJX0RBQzc1MTIpCSs9IHRpX2RhYzc1MTIubwog
b2JqLSQoQ09ORklHX0MyUE9SVCkJCSs9IGMycG9ydC8KIG9iai0kKENPTkZJR19ITUM2MzUyKQkJ
Kz0gaG1jNjM1Mi5vCitvYmotJChDT05GSUdfWU9DVE9fVEVTVE1PRCkJKz0geW9jdG8tdGVzdG1v
ZC5vCiBvYmoteQkJCQkrPSBlZXByb20vCiBvYmoteQkJCQkrPSBjYjcxMC8KIG9iai0kKENPTkZJ
R19TUEVBUjEzWFhfUENJRV9HQURHRVQpCSs9IHNwZWFyMTN4eF9wY2llX2dhZGdldC5vCmRpZmYg
LS1naXQgYS9kcml2ZXJzL21pc2MveW9jdG8tdGVzdG1vZC5jIGIvZHJpdmVycy9taXNjL3lvY3Rv
LXRlc3Rtb2QuYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4xZTA5ZDM1Ci0t
LSAvZGV2L251bGwKKysrIGIvZHJpdmVycy9taXNjL3lvY3RvLXRlc3Rtb2QuYwpAQCAtMCwwICsx
LDM2IEBACisvKgorICogQ29weXJpZ2h0IDIwMTIgSW50ZWwgQ29ycG9yYXRpb24KKyAqIEF1dGhv
cmVkLWJ5OiAgVG9tIFphbnVzc2kgPHRvbS56YW51c3NpQGludGVsLmNvbT4KKyAqCisgKiBUaGlz
IHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29y
IG1vZGlmeQorICogaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMg
TGljZW5zZSB2ZXJzaW9uIDIgYXMKKyAqIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBG
b3VuZGF0aW9uLgorICoKKyAqIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9w
ZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3
aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqIE1FUkNIQU5UQUJJTElUWSBv
ciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKKyAqIEdOVSBHZW5l
cmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisgKgorICogWW91IHNob3VsZCBo
YXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYWxv
bmcKKyAqIHdpdGggdGhpcyBwcm9ncmFtOyBpZiBub3QsIHdyaXRlIHRvIHRoZSBGcmVlIFNvZnR3
YXJlIEZvdW5kYXRpb24sIEluYy4sCisgKiA1MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZsb29y
LCBCb3N0b24sIE1BIDAyMTEwLTEzMDEgVVNBLgorICovCisKKyNpbmNsdWRlIDxsaW51eC9tb2R1
bGUuaD4KKworc3RhdGljIGludCBfX2luaXQgeW9jdG9fdGVzdG1vZF9pbml0KHZvaWQpCit7CisJ
cHJpbnRrKCJLaWxyb3kgd2FzIGhlcmUhIF9fbV8oT3VPKV9tX18iKTsKK30KKworc3RhdGljIHZv
aWQgX19leGl0IHlvY3RvX3Rlc3Rtb2RfZXhpdCh2b2lkKQoreworCXByaW50aygiS2lscm95IHdh
cyBub3QgaGVyZSEiKTsKK30KKworbW9kdWxlX2luaXQoeW9jdG9fdGVzdG1vZF9pbml0KTsKK21v
ZHVsZV9leGl0KHlvY3RvX3Rlc3Rtb2RfZXhpdCk7CisKK01PRFVMRV9BVVRIT1IoIlRvbSBaYW51
c3NpIDx0b20uemFudXNzaUBpbnRlbC5jb20iKTsKK01PRFVMRV9ERVNDUklQVElPTigiWW9jdG8g
VGVzdCBEcml2ZXIiKTsKK01PRFVMRV9MSUNFTlNFKCJHUEwiKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>