5192 2013-09-13 14:20:43 +0000 non-existent URLs listed in the "Layer index URL" column 2015-12-04 14:01:31 +0000 1 1 7 Build System, Metadata & Runtime Toaster toaster 1.5 All Multiple VERIFIED OBSOLETE simple Medium minor Future 1 belen.barros.pena elliot.smith alexandru.costinx.roman alexandru.damian belen.barros.pena bluelightning jessica.zhang alexandru.costinx.roman --- --- No (bug/feature does not impact docs) oldest_to_newest 36690 0 belen.barros.pena 2013-09-13 14:20:43 +0000 In the "All layers" table, we are not checking if the "Layer Index URL" exists. For example: http://layers.openembedded.org/layerindex/branch/master/layer/meta-hob/ returns 404, because the meta-hob layer is not in the OpenEmbedded metadata index. We might not have to fix this right now, but the interface should not list URLs that return 404. 36704 1 belen.barros.pena 2013-09-13 14:43:00 +0000 webhob-poky/master:aa7bec2e9dffd6901ebe3accf748ce458d1481a3 37576 2 alexandru.damian 2013-10-03 15:21:58 +0000 The layers don't have URLs specified anywhere. So it's a guessed URL. Not sure what options we have here. 37617 3 belen.barros.pena 2013-10-04 11:17:35 +0000 Well, I guess we should be checking for a 404 before displaying the URL, bearing in mind that we cannot condition the display of other content in the page to obtaining a response. I am cc'ing PaulE: hopefully he has some suggestions for us. 37622 4 alexandru.damian 2013-10-04 13:14:10 +0000 Generally speaking, the way to do this would be a XMLHttpRequest. Unfortunately, cross origin requests using XMLHttpRequest are being denied by the browser under the Same Origin Policy. This means that we can't check if the target link is a 404 at runtime. Maybe we can solve this in the layerindex application in the presentation level, i.e. a nicer 404 ? 37630 5 belen.barros.pena 2013-10-04 14:17:51 +0000 (In reply to comment #4) > Generally speaking, the way to do this would be a XMLHttpRequest. > Unfortunately, cross origin requests using XMLHttpRequest are being denied > by the browser under the Same Origin Policy. > This means that we can't check if the target link is a 404 at runtime. Cross-Origin Resource Sharing seems to be well supported http://caniuse.com/#feat=cors Is this something we could consider? If not supported by the browser, we consider the check as failed and don't provide the link. > Maybe we can solve this in the layerindex application in the presentation > level, i.e. a nicer 404 ? The alternative is not providing links to the layer index: you should not be showing non-existent URLs to people. The issue I have is that right now this is about the layer index, but the idea is to integrate our web tools (that's why we are moving to this platform), and in order to do so effectively we need to be able to solve this problem. 37634 6 alexandru.damian 2013-10-04 15:04:35 +0000 If the layerindex server sends back the header ''Access-Control-Allow-Origin: *' I can verify non-404 of the destination URL and not show invalid links. 37638 7 belen.barros.pena 2013-10-04 15:28:32 +0000 (In reply to comment #6) > If the layerindex server sends back the header > > ''Access-Control-Allow-Origin: *' > > I can verify non-404 of the destination URL and not show invalid links. Sounds good :) Now we just need Paul / Michael to confirm if the server can be set up that way. 39214 8 alexandru.damian 2013-12-03 18:55:25 +0000 Moved to WaitForUpstream until the layer index application supports this functionality. 39223 9 bluelightning 2013-12-04 11:35:27 +0000 I'm confused - why do we need the browser to do this via an XMLHttpRequest? Why not just do it on the server side as we're sending the page to the user? 39237 10 alexandru.damian 2013-12-05 11:10:26 +0000 Conceptually, this is a presentation issue, so it should be solved at the presentation layer. Generally speaking, I am totally against implementing this policy, because: * it drives up the load on the layer-index application, getting lots of hits for content that is not seen by a user * it raises a privacy problem, as the system will make external network calls to a 3rd party web application without user consent; The privacy issue would be alleviated somewhat if the calls are made through a system where there is reasonable expectations of such calls happening, i.e. a browser, instead making calls from the backend itself. Maybe we should handle this problem somehow else, like embedding URLs into layer git branch descriptions ? 53623 11 elliot.smith 2015-09-02 11:15:42 +0000 As we now show the layer index directly, we don't need the layer index URL any more (the user used to be able to visit the URL to get more info. about the layer). 57047 12 alexandru.costinx.roman 2015-12-04 14:01:31 +0000 Verified.