<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>5373</bug_id>
          
          <creation_ts>2013-10-22 10:00:08 +0000</creation_ts>
          <short_desc>kernel-yocto::do_validate_kernel test for machine branch broken</short_desc>
          <delta_ts>2013-10-28 11:51:48 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>Kernel</product>
          <component>linux-yocto</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.5.1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ola Nilsson">ola.x.nilsson</reporter>
          <assigned_to name="Bruce Ashfield">bruce.ashfield</assigned_to>
          <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
    
    <cc>sgw</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>38126</commentid>
    <comment_count>0</comment_count>
    <who name="Ola Nilsson">ola.x.nilsson</who>
    <bug_when>2013-10-22 10:00:08 +0000</bug_when>
    <thetext>In do_validate_kernel there is a test for whether the machine_branch exists. 
The test is whether the return value of git show-ref --verify is exactly one.
At least on my machine the return value is 128 when the branch does not exist.
Maybe the test should be whether the return value is not 0?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38196</commentid>
    <comment_count>1</comment_count>
    <who name="Darren Hart">dvhart</who>
    <bug_when>2013-10-28 10:34:04 +0000</bug_when>
    <thetext>Bruce, this looks like a valid report to me. Giving this one to you for the tooling.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38199</commentid>
    <comment_count>2</comment_count>
    <who name="Bruce Ashfield">bruce.ashfield</who>
    <bug_when>2013-10-28 11:50:54 +0000</bug_when>
    <thetext>No we really want to check for 1:

       --verify
           Enable stricter reference checking by requiring an exact ref path. Aside from returning an error code of 1, it will also print an error
           message if --quiet was not specified.


We can&apos;t target all versions of git at once, so I&apos;m continuing to go with
the man page and recent sources.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38200</commentid>
    <comment_count>3</comment_count>
    <who name="Bruce Ashfield">bruce.ashfield</who>
    <bug_when>2013-10-28 11:51:48 +0000</bug_when>
    <thetext>I should add that if we can show a real tree, where this fails, and
either a cryptic error message comes out, or another check doesn&apos;t
catch the problem later, I&apos;ll revisit.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>