<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>5378</bug_id>
          
          <creation_ts>2013-10-23 10:12:57 +0000</creation_ts>
          <short_desc>Illegal Argument exception when no project is selected in Profile Menu contribution</short_desc>
          <delta_ts>2013-10-31 23:02:35 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>Eclipse Plugin</product>
          <component>eclipse-plugin</component>
          <version>1.5</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.5.1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Johann Draschwandtner">johann.draschwandtner</reporter>
          <assigned_to name="Jessica">jessica.zhang</assigned_to>
          <cc>ioanax.grigoropol</cc>
    
    <cc>yp.ep.watcher</cc>
    
    <cc>yp.watcher</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>38139</commentid>
    <comment_count>0</comment_count>
      <attachid>1573</attachid>
    <who name="Johann Draschwandtner">johann.draschwandtner</who>
    <bug_when>2013-10-23 10:12:57 +0000</bug_when>
    <thetext>Created attachment 1573
Proposed patch

I&apos;ve installed the yocto sdk profile in an eclipse based IDE that updates the menu handlers when opening a perspective.

When there is no project yet created or no project selected an Illegal Argument exception is thrown.
Relevant code is found in:
ProjectSpecificContributionItem and
TargetProfileContributionItem
of package org.yocto.sdk.ide.

The assumption that the selection will always contain a Project is not correct, therfore a simple check for null will fix the issue.

Please refer to the proposed patch attached.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38407</commentid>
    <comment_count>1</comment_count>
    <who name="Jessica">jessica.zhang</who>
    <bug_when>2013-10-31 23:02:35 +0000</bug_when>
    <thetext>http://git.yoctoproject.org/cgit.cgi/eclipse-poky-kepler/commit/?id=a0aaede42772a12a5c5b368a40cc13d3da608c6b
http://git.yoctoproject.org/cgit.cgi/eclipse-poky-juno/commit/?id=2fe348f87ccedf30a26261cb51442b579d3fdb6a</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>1573</attachid>
            <date>2013-10-23 10:12:57 +0000</date>
            <delta_ts>2013-10-23 10:12:57 +0000</delta_ts>
            <desc>Proposed patch</desc>
            <filename>eclipse-poky-juno.patch</filename>
            <type>text/plain</type>
            <size>1584</size>
            <attacher name="Johann Draschwandtner">johann.draschwandtner</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL3BsdWdpbnMvb3JnLnlvY3RvLnNkay5pZGUvc3JjL29yZy95b2N0by9zZGsv
aWRlL1Byb2plY3RTcGVjaWZpY0NvbnRyaWJ1dGlvbkl0ZW0uamF2YSBiL3BsdWdpbnMvb3JnLnlv
Y3RvLnNkay5pZGUvc3JjL29yZy95b2N0by9zZGsvaWRlL1Byb2plY3RTcGVjaWZpY0NvbnRyaWJ1
dGlvbkl0ZW0uamF2YQppbmRleCBjMjlkMjc4Li45OGQ1YjIzIDEwMDY0NAotLS0gYS9wbHVnaW5z
L29yZy55b2N0by5zZGsuaWRlL3NyYy9vcmcveW9jdG8vc2RrL2lkZS9Qcm9qZWN0U3BlY2lmaWND
b250cmlidXRpb25JdGVtLmphdmEKKysrIGIvcGx1Z2lucy9vcmcueW9jdG8uc2RrLmlkZS9zcmMv
b3JnL3lvY3RvL3Nkay9pZGUvUHJvamVjdFNwZWNpZmljQ29udHJpYnV0aW9uSXRlbS5qYXZhCkBA
IC00MCw2ICs0MCw5IEBACiAJCUFycmF5TGlzdDxJQ29udHJpYnV0aW9uSXRlbT4gaXRlbXMgPSBu
ZXcgQXJyYXlMaXN0PElDb250cmlidXRpb25JdGVtPigpOwogCiAJCUlQcm9qZWN0IHByb2plY3Qg
PSBnZXRTZWxlY3RlZFByb2plY3Qoc2VydmljZUxvY2F0b3IpOworCQlpZihwcm9qZWN0ID09IG51
bGwpIHsKKwkJCXJldHVybiBpdGVtcy50b0FycmF5KG5ldyBJQ29udHJpYnV0aW9uSXRlbVtpdGVt
cy5zaXplKCldKTsKKwkJfQogCQlZb2N0b1VJRWxlbWVudCB5b2N0b1VJRWxlbWVudCA9IFByb2pl
Y3RQcmVmZXJlbmNlVXRpbHMuZ2V0RWxlbShwcm9qZWN0KTsKIAkJU0RLQ2hlY2tSZXN1bHRzIHJl
c3VsdCA9IFlvY3RvU0RLQ2hlY2tlci5jaGVja1lvY3RvU0RLKHlvY3RvVUlFbGVtZW50KTsKIApk
aWZmIC0tZ2l0IGEvcGx1Z2lucy9vcmcueW9jdG8uc2RrLmlkZS9zcmMvb3JnL3lvY3RvL3Nkay9p
ZGUvVGFyZ2V0UHJvZmlsZUNvbnRyaWJ1dGlvbkl0ZW0uamF2YSBiL3BsdWdpbnMvb3JnLnlvY3Rv
LnNkay5pZGUvc3JjL29yZy95b2N0by9zZGsvaWRlL1RhcmdldFByb2ZpbGVDb250cmlidXRpb25J
dGVtLmphdmEKaW5kZXggOTVkODIyOS4uYjUwMTY4OCAxMDA2NDQKLS0tIGEvcGx1Z2lucy9vcmcu
eW9jdG8uc2RrLmlkZS9zcmMvb3JnL3lvY3RvL3Nkay9pZGUvVGFyZ2V0UHJvZmlsZUNvbnRyaWJ1
dGlvbkl0ZW0uamF2YQorKysgYi9wbHVnaW5zL29yZy55b2N0by5zZGsuaWRlL3NyYy9vcmcveW9j
dG8vc2RrL2lkZS9UYXJnZXRQcm9maWxlQ29udHJpYnV0aW9uSXRlbS5qYXZhCkBAIC0xMTAsNiAr
MTEwLDkgQEAKIAkJSUNvbW1hbmRTZXJ2aWNlIGNvbW1hbmRTZXJ2aWNlID0gKElDb21tYW5kU2Vy
dmljZSkgc2VydmljZUxvY2F0b3IuZ2V0U2VydmljZShJQ29tbWFuZFNlcnZpY2UuY2xhc3MpOwog
CQlDb21tYW5kIGNvbW1hbmQgPSBjb21tYW5kU2VydmljZS5nZXRDb21tYW5kKFByb2ZpbGVTd2l0
Y2hIYW5kbGVyLlBST0ZJTEVfU1dJVENIX0NPTU1BTkQpOwogCQlJUHJvamVjdCBwcm9qZWN0ID0g
Z2V0U2VsZWN0ZWRQcm9qZWN0KHNlcnZpY2VMb2NhdG9yKTsKKwkJaWYocHJvamVjdCA9PSBudWxs
KSB7CisJCQlyZXR1cm47CisJCX0KIAogCQl0cnkgewogCQkJaWYgKFByb2plY3RQcmVmZXJlbmNl
VXRpbHMuZ2V0VXNlUHJvamVjdFNwZWNpZmljT3B0aW9uKHByb2plY3QpKSB7
</data>

          </attachment>
      

    </bug>

</bugzilla>