<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>5407</bug_id>
          
          <creation_ts>2013-10-29 11:38:44 +0000</creation_ts>
          <short_desc>Create standard method for adding package feeds</short_desc>
          <delta_ts>2015-12-17 16:17:29 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>1.6</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>2.1 M1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Paul Eggleton">bluelightning</reporter>
          <assigned_to name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</assigned_to>
          <cc>alexander.kanevskiy</cc>
    
    <cc>anibal.limon</cc>
    
    <cc>benjamin.esquivel</cc>
    
    <cc>hongxu.jia</cc>
    
    <cc>jessica.zhang</cc>
    
    <cc>mark.hatle</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>ross.burton</cc>
    
    <cc>twoerner</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Yes (doc changes required)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>38242</commentid>
    <comment_count>0</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2013-10-29 11:38:44 +0000</bug_when>
    <thetext>Create a standard way of adding feeds to be written into the package manager configuration in the final image (when package-management is in IMAGE_FEATURES).  We have IPK_FEED_URIS, but that is specific to ipk - we should probably add counterparts for RPM and DEB.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38243</commentid>
    <comment_count>1</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2013-10-29 11:40:25 +0000</bug_when>
    <thetext>Also, there is some ipk-specific code for a FEED_URIS variable in image.bbclass in addition to IPK_FEED_URIS handling in rootfs_ipk.bbclass; this should be tidied up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38244</commentid>
    <comment_count>2</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2013-10-29 11:47:15 +0000</bug_when>
    <thetext>Also worth referring to is distro-feed-configs.bb in meta-oe.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>40524</commentid>
    <comment_count>3</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2014-02-20 17:53:12 +0000</bug_when>
    <thetext>And poky-feed-config-opkg in oe-core.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>40856</commentid>
    <comment_count>4</comment_count>
    <who name="Hongxu Jia">hongxu.jia</who>
    <bug_when>2014-03-04 12:42:12 +0000</bug_when>
    <thetext>*** Bug 5435 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>43751</commentid>
    <comment_count>5</comment_count>
    <who name="Hongxu Jia">hongxu.jia</who>
    <bug_when>2014-06-04 07:43:44 +0000</bug_when>
    <thetext>The deb/rpm/ipkg all supported by the following patch:

Author: David Nyström &lt;david.c.nystrom@gmail.com&gt;
Date:   Thu Feb 27 21:20:37 2014 +0100

    do_rootfs: Added PACKAGE_FEED_URIS functionality
    
    Adding a common interface to add predefined package manager
    channels to prebuilt rootfs:es.
    
    Adding PACKAGE_FEED_URIS = &quot;http://myre.po/repo/, will
    assume repo directories named (rpm,ipk,deb) as subdirectories
    and statically add them to the rootfs, using the same PKG_ARCHs
    as the build which produced the images.
    
    Tested with RPM, IPK and DEB.
    
    deb feed functionality seem broken, is anyone using this ?
    
    (From OE-Core rev: 9b8811045546ad67b4695d980f09636d5506e50c)

We should clean up the duplicated configs: IPK_FEED_URIS/ PACKAGE_FEED_URIS/ BUILD_IMAGES_FROM_FEEDS/ FEED_URIS/ FEED_DEPLOYDIR_BASE_URI

//Hongxu</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>51415</commentid>
    <comment_count>6</comment_count>
    <who name="Hongxu Jia">hongxu.jia</who>
    <bug_when>2015-06-02 02:21:44 +0000</bug_when>
    <thetext>The deb/rpm/ipkg all supported by the following patch:

Author: David Nyström &lt;david.c.nystrom@gmail.com&gt;
Date:   Thu Feb 27 21:20:37 2014 +0100

    do_rootfs: Added PACKAGE_FEED_URIS functionality
    
    Adding a common interface to add predefined package manager
    channels to prebuilt rootfs:es.
    
    Adding PACKAGE_FEED_URIS = &quot;http://myre.po/repo/, will
    assume repo directories named (rpm,ipk,deb) as subdirectories
    and statically add them to the rootfs, using the same PKG_ARCHs
    as the build which produced the images.
    
    Tested with RPM, IPK and DEB.
    
    deb feed functionality seem broken, is anyone using this ?
    
    (From OE-Core rev: 9b8811045546ad67b4695d980f09636d5506e50c)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>51732</commentid>
    <comment_count>7</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2015-06-16 11:02:03 +0000</bug_when>
    <thetext>It&apos;s taken me far too long to respond to this - sorry about that.

I think PACKAGE_FEED_URIS is definitely a start, however I think it has some limitations that make it difficult to use in the general case - for example, it hardcodes that the feed will be under /rpm/ or /ipk/ under the specified URI, and that the feed will be split by architecture and nothing else - that&apos;s all well and good if all you care about is testing directly pointing to the output of tmp/deploy, but otherwise you might not be prepared to live with those limitations.

Whatever mechanism we have, it ought to be able to replace the existing ones. We still have IPK_FEED_URIS and distro-feed-configs in meta-oe for example, I&apos;d like to think we can have something in OE-Core so both of those can be removed.

Reopening and assigning to me for now - if someone else wants to take it then I&apos;d be happy for that to happen.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>52974</commentid>
    <comment_count>8</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2015-08-10 23:05:43 +0000</bug_when>
    <thetext>(In reply to comment #7)
&gt; It&apos;s taken me far too long to respond to this - sorry about that.
&gt; 
&gt; I think PACKAGE_FEED_URIS is definitely a start, however I think it has some
&gt; limitations that make it difficult to use in the general case - for example,
&gt; it hardcodes that the feed will be under /rpm/ or /ipk/ under the specified
&gt; URI, and that the feed will be split by architecture and nothing else -
&gt; that&apos;s all well and good if all you care about is testing directly pointing
&gt; to the output of tmp/deploy, but otherwise you might not be prepared to live
&gt; with those limitations.
&gt; 
&gt; Whatever mechanism we have, it ought to be able to replace the existing
&gt; ones. We still have IPK_FEED_URIS and distro-feed-configs in meta-oe for
&gt; example, I&apos;d like to think we can have something in OE-Core so both of those
&gt; can be removed.
&gt; 
&gt; Reopening and assigning to me for now - if someone else wants to take it
&gt; then I&apos;d be happy for that to happen.

I got a patch (locally, not sent yet to the ML) which uses PACKAGE_FEED_URIS AND a new variable called PACKAGE_FEED_PREFIX to create a full URI. Also, I removed all the hard-coded /rpm/, /ipk/ and /deb/ sub-strings on the links mentioned in your comment. 

Should I remove the IPK_FEED_URIS feature completely? I think we should, and just have one way to include package feeds no matter what the package manager is.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>53002</commentid>
    <comment_count>9</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2015-08-11 21:29:49 +0000</bug_when>
    <thetext>Patch sent to the ML.

From: Leonardo Sandoval &lt;leonardo.sandoval.gonzalez@linux.intel.com&gt;

Subject: [PATCH] lib/oe/package_manager: Include PACKAGE_FEED_PREFIX instead of hardcode paths

Instead of hardcode paths (/rpm/, /ipk/, /deb/), use a user-defined prefix
when creating the URI feeds. URIs now will have the following syntax:

    PACKAGE_FEED_URIS_1/PACKAGE_FEED_PREFIX
    PACKAGE_FEED_URIS_2/PACKAGE_FEED_PREFIX
    .

where PACKAGE_FEED_URIS = &quot;PACKAGE_FEED_URIS_1 PACKAGE_FEED_URIS_2 ....&quot;

[YOCTO #5407]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>54088</commentid>
    <comment_count>10</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2015-09-15 14:32:47 +0000</bug_when>
    <thetext>Patch merged on master 338c325:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=338c3257f60e99c1fd101d5010daea4099eb1d0e</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>54089</commentid>
    <comment_count>11</comment_count>
    <who name="Alexander Kanevskiy">alexander.kanevskiy</who>
    <bug_when>2015-09-15 14:36:35 +0000</bug_when>
    <thetext>Patch includes code changes. what about documentation changes to document that new behaviour in developer manual ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>54099</commentid>
    <comment_count>12</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2015-09-15 15:16:54 +0000</bug_when>
    <thetext>(In reply to comment #11)
&gt; Patch includes code changes. what about documentation changes to document
&gt; that new behaviour in developer manual ?

You are completely right. I will file a bug about it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>54102</commentid>
    <comment_count>13</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2015-09-15 15:51:43 +0000</bug_when>
    <thetext>(In reply to comment #11)
&gt; Patch includes code changes. what about documentation changes to document
&gt; that new behaviour in developer manual ?

There is now a bug about documenting the feature

https://bugzilla.yoctoproject.org/show_bug.cgi?id=8301</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>54227</commentid>
    <comment_count>14</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2015-09-17 17:19:06 +0000</bug_when>
    <thetext>The patch did not solve the problem completely: there are two more points to consider. 1) instead of a single PREFIX variable, we should have something like
PACKAGE_FEED_PREFIXES = &quot;/rpm/core2_64 /rpm/all ...&quot; so there is a bit more flexibility to the user (with current implementation ALL URL share the same PREFIX) 2) PREFIX(S) name should be reconsider: SUFFIX(S) can be a better name, because it is actually a suffix inside the FEED.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>54976</commentid>
    <comment_count>15</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2015-10-05 21:24:31 +0000</bug_when>
    <thetext>New patch sent to the ML: 

http://lists.openembedded.org/pipermail/openembedded-core/2015-October/111297.html

In resume: FEED_PREFIX was rename to FEED_BASE_PATHS and FEED_ARCHS new variable created. More info on patch&apos;s description.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>57353</commentid>
    <comment_count>16</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2015-12-17 16:17:29 +0000</bug_when>
    <thetext>Merge into master branch (6650357)</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>