5442 2013-11-01 06:40:06 +0000 sanity.bbclass: check TMPDIR is not on nfs 2014-03-26 14:29:21 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core 1.6 x86 Multiple RESOLVED FIXED 26 March 2014: Setting documentation flag to "Done." Medium enhancement 1.6 M1 1 liezhi.yang liezhi.yang mark.hatle mcrapet meta.mr.watcher meta.watcher richard.purdie sgw srifenbark tudor.florea --- --- Done (doc changes complete) oldest_to_newest 38412 0 liezhi.yang 2013-11-01 06:40:06 +0000 From RP: Only specific directories are expected to work on nfs, not the whole tmpdir, basically SSTATE_DIR and DL_DIR. There is an argument for making DEPLOY_DIR work on nfs too but it currently doesn't. Then we will add a check in sanity.bbclass to check TMPDIR is not on nfs. 39928 1 1738 mcrapet 2014-01-20 13:18:41 +0000 Created attachment 1738 v1 39929 2 mcrapet 2014-01-20 13:19:38 +0000 Here is my proposal. I chose to use oe.utils.getstatusoutput instead of subprocess.Popen for more portability. 39967 3 liezhi.yang 2014-01-21 14:53:51 +0000 (In reply to comment #2) > Here is my proposal. I chose to use oe.utils.getstatusoutput instead of > subprocess.Popen for more portability. Hi Matthieu, Thank you very much for taking care of this, it seems that the "stat -f -c" is a little better to check the nfs, I had sent a patch for it on Nov. 1st, 2013, but it had been pending because of where to put the checking, I will update it a little and re-send it again. http://lists.openembedded.org/pipermail/openembedded-core/2013-November/085833.html Thank you very much again. 39972 4 mcrapet 2014-01-21 15:11:15 +0000 Hi Robert, stat is indeed better. But I was wondering if NFS was the only network filesystem with troubles (for example Coda or CIFS?). 39977 5 mark.hatle 2014-01-21 15:27:34 +0000 It's not actually "NFS" that the problem occurs. It's any filesystem that doesn't have consistent inodes and/or doesn't honor all of the locking and related items that POSIX dictates for a Unix-like filesystem. NFS just seems to be the biggest offender as it usually violates both locking and inode consistency. I'm not sure if any of the other network filesystems have a similar problem or not, but until someone has a problem -- it's not easy to check for. (The old reiserfs had the inode issue as well, at least original versions of it did..) 40224 6 liezhi.yang 2014-02-07 06:08:58 +0000 Merged into master: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=47208175027686339dd18df52b60ec2c43594918 41525 7 tudor.florea 2014-03-20 13:51:21 +0000 I'm having a hard time understanding what was the initial problem that was solved by checking nfs is not used for TMPDIR. I've created various poky based images on tnf without apparent issue so far. Thank you. Tudor 41530 8 mark.hatle 2014-03-20 14:23:03 +0000 (In reply to comment #7) Most NFS systems have significant issues with inode number re-use as well as issues with POSIX locking. When doing a build where the TMPDIR is on NFS, pseudo (the fake root user wrapper) can fail to properly identify the files being used and their faked permissions, owners and groups. This will lead to the file itself being properly created, but when packaged the permissions can be incorrect. If you inspect the logs, you will find that various pseudo diagnostic warnings will occur where it was unable to identify the initial creator of the file, so it has to assume something based on either the inode number or the file path. (Since inode numbers are reused, this doesn't always work.) Locking is a similar issue in that RPM, bitbake, pseudo and other components require functional POSIX locking. Some NFS systems appear to work, while others don't work reliably. There does not appear to be any way to reliably detect if the locking is working before it simply fails. Thus you can run your builds with your configured 'build' directory on NFS, but the TMPDIR -must- be on a filesystem with proper 41578 9 srifenbark 2014-03-21 14:57:51 +0000 Hi, I dropped in a note in the insane.bbclass section of the reference manual stating that the class did not support tests on TMPDIR when it is on NFS. I don't know if this note is sufficient or not to take care of the documentation part of this issue. Mark.. could you review the note and see if I need to add any more detail or clarity to what is going on? For one thing, I don't know the consequences if TMPDIR is on NFS. Do the tests just not get run? I would like to state something about that in the note. See the change here - http://www.yoctoproject.org/docs/1.6/ref-manual/ref-manual.html#ref-classes-insane Thanks, Scott 41581 10 mark.hatle 2014-03-21 16:40:15 +0000 (In reply to comment #9) > See the change here - > http://www.yoctoproject.org/docs/1.6/ref-manual/ref-manual.html#ref-classes- > insane Thats not correct.. It's actually the sanity class that this change affects. Specifically: sanity.bbclass: + # Check that TMPDIR isn't located on nfs + status.addresult(check_not_nfs(tmpdir, "TMPDIR")) So I think you should revert your documentation change. Instead make reference somewhere in the docs (1.3 maybe? or maybe 3.1) that the TMPDIR must reside on a local disk as NFS isn't supported. This is due to limitations and bugs within the NFS protocol and many NFS implementations. 41720 11 srifenbark 2014-03-25 18:43:54 +0000 Mark, Thanks for the correction. I took the change out of the insane class but left an explanation in the TMPDIR variable in the glossary at http://www.yoctoproject.org/docs/1.6/ref-manual/ref-manual.html#var-TMPDIR. Regarding another important place where we might like this note I was thinking of where we define the term "Build Directory" since that is where TMPDIR will ultimately be. Throughout the YP manual set, the term "Build Directory" is linked liberally back to this definition. http://www.yoctoproject.org/docs/1.6/dev-manual/dev-manual.html#build-directory How does this sound? Scott 41721 12 mark.hatle 2014-03-25 19:00:48 +0000 (In reply to comment #11) > Mark, > > Thanks for the correction. I took the change out of the insane class but > left an explanation in the TMPDIR variable in the glossary at > http://www.yoctoproject.org/docs/1.6/ref-manual/ref-manual.html#var-TMPDIR. > > Regarding another important place where we might like this note I was > thinking of where we define the term "Build Directory" since that is where > TMPDIR will ultimately be. Throughout the YP manual set, the term "Build > Directory" is linked liberally back to this definition. > > http://www.yoctoproject.org/docs/1.6/dev-manual/dev-manual.html#build- > directory I think that is correct. The on caveat is that the TMPDIR is by default within the build-directory -- but does not have to be. This is where the notion of setting the TMPDIR to a local disk, and using NFS for the build-directory comes into play. --Mark 41722 13 srifenbark 2014-03-25 19:08:58 +0000 Mark, Good point on TMPDIR purposely getting set outside the build directory. I will bring that caveat up in the explanation... probably both in the term and in the TMPDIR glossary entry. When I get the changes in I will comment with some links for review. thanks, Scott 41769 14 srifenbark 2014-03-26 13:35:06 +0000 Mark, Please look at these two areas now and see if we are good for this doc part of the bug: http://www.yoctoproject.org/docs/1.6/ref-manual/ref-manual.html#var-TMPDIR http://www.yoctoproject.org/docs/1.6/dev-manual/dev-manual.html#build-directory Thanks, Scott 41772 15 mark.hatle 2014-03-26 14:24:47 +0000 (In reply to comment #14) > Please look at these two areas now and see if we are good for this doc part > of the bug: > > http://www.yoctoproject.org/docs/1.6/ref-manual/ref-manual.html#var-TMPDIR > > http://www.yoctoproject.org/docs/1.6/dev-manual/dev-manual.html#build- > directory I think the above properly explains the issue. New users may still be a bit confused -- but I don't see an easier way of explaining things. 41774 16 srifenbark 2014-03-26 14:29:21 +0000 Thanks Mark, New users in a state of confusion is a constant :) I am resetting the doc flag to "Done." Scott 1738 2014-01-20 13:18:41 +0000 2014-01-20 13:18:41 +0000 v1 0001-sanity.bbclass-check-TMPDIR-is-not-on-nfs.patch text/plain 2076 mcrapet RnJvbSA4MjQ1OGRkMzE4ZjFjYWU4ZTZjNjA5ZDFiOTg3OTNmOTc2YjBhNTc4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXR0aGlldSBDcmFwZXQgPE1hdHRoaWV1LkNyYXBldEBpbmdl bmljby5jb20+CkRhdGU6IE1vbiwgMjAgSmFuIDIwMTQgMTU6MTA6MzEgKzAxMDAKU3ViamVjdDog W1BBVENIXSBzYW5pdHkuYmJjbGFzczogY2hlY2sgVE1QRElSIGlzIG5vdCBvbiBuZnMKCltZT0NU TyAjNTQ0Ml0KClNpZ25lZC1vZmYtYnk6IE1hdHRoaWV1IENyYXBldCA8TWF0dGhpZXUuQ3JhcGV0 QGluZ2VuaWNvLmNvbT4KLS0tCiBtZXRhL2NsYXNzZXMvc2FuaXR5LmJiY2xhc3MgfCAxNiArKysr KysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdp dCBhL21ldGEvY2xhc3Nlcy9zYW5pdHkuYmJjbGFzcyBiL21ldGEvY2xhc3Nlcy9zYW5pdHkuYmJj bGFzcwppbmRleCA4NTMxZGYxLi5iY2JlODgzIDEwMDY0NAotLS0gYS9tZXRhL2NsYXNzZXMvc2Fu aXR5LmJiY2xhc3MKKysrIGIvbWV0YS9jbGFzc2VzL3Nhbml0eS5iYmNsYXNzCkBAIC0xOTUsNiAr MTk1LDIxIEBAIGRlZiBjaGVja19jcmVhdGVfbG9uZ19maWxlbmFtZShmaWxlcGF0aCwgcGF0aG5h bWUpOgogICAgICAgICByZXR1cm4gIkZhaWxlZCB0byBjcmVhdGUgJXMgZGlyZWN0b3J5IGluIHdo aWNoIHRvIHJ1biBsb25nIG5hbWUgc2FuaXR5IGNoZWNrOiAlcy5cbiIgJSAocGF0aG5hbWUsIHN0 cmVycm9yKQogICAgIHJldHVybiAiIgogCitkZWYgY2hlY2tfZmlsZXN5c3RlbV90eXBlKGZpbGVw YXRoLCBwYXRobmFtZSwgYmxhY2tsaXN0KToKKyAgICBzdGF0dXMsIHJlc3VsdCA9IG9lLnV0aWxz LmdldHN0YXR1c291dHB1dCgiZGYgLVQgJXMiICUgZmlsZXBhdGgpCisgICAgaWYgc3RhdHVzICE9 IDA6CisgICAgICAgIHJldHVybiAiVW5hYmxlIHRvIGV4ZWN1dGUgZGYgLVQgJXMsIGV4aXQgY29k ZSAlc1xuIiAlIChmaWxlcGF0aCwgc3RhdHVzKQorCisgICAgIyAtVC8tLXByaW50LXR5cGUgc3dp dGNoIGlzIGF2YWlsYWJsZSBpbiBHTlUgY29yZXV0aWxzIGRmCisgICAgaWYgbm90IHJlc3VsdDoK KyAgICAgICAgYmIud2FybigiRmFpbGVkIHRvIGdldCAlcyBmaWxlc3lzdGVtIHR5cGUuIElnbm9y aW5nLiIgJSBwYXRobmFtZSkKKyAgICBlbHNlOgorICAgICAgICB0eXBlID0gcmVzdWx0LnNwbGl0 bGluZXMoKVstMV0uc3BsaXQoKVsxXQorICAgICAgICBpZiB0eXBlIGluIGJsYWNrbGlzdDoKKyAg ICAgICAgICAgIHJldHVybiAiRXJyb3IsICVzIGlzIG1vdW50ZWQgb24gYSAlcyBmaWxlc3lzdGVt LCB5b3UgbWF5IHBvc3NpYmx5IGV4cGVyaWVuY2UgdW5leHBlY3RlZCBmYWlsdXJlcy5cbiIgJSAo cGF0aG5hbWUsIHR5cGUudXBwZXIoKSkKKworICAgIHJldHVybiAiIgorCiBkZWYgY2hlY2tfcGF0 aF9sZW5ndGgoZmlsZXBhdGgsIHBhdGhuYW1lLCBsaW1pdCk6CiAgICAgaWYgbGVuKGZpbGVwYXRo KSA+IGxpbWl0OgogICAgICAgICByZXR1cm4gIlRoZSBsZW5ndGggb2YgJXMgaXMgbG9uZ2VyIHRo YW4gNDEwLCB0aGlzIHdvdWxkIGNhdXNlIHVuZXhwZWN0ZWQgZXJyb3JzLCBwbGVhc2UgdXNlIGEg c2hvcnRlciBwYXRoLlxuIiAlIHBhdGhuYW1lCkBAIC01MzEsNiArNTQ2LDcgQEAgZGVmIGNoZWNr X3Nhbml0eV92ZXJzaW9uX2NoYW5nZShzdGF0dXMsIGQpOgogICAgICMgQ2hlY2sgdGhhdCBUTVBE SVIgaXNuJ3Qgb24gYSBmaWxlc3lzdGVtIHdpdGggbGltaXRlZCBmaWxlbmFtZSBsZW5ndGggKGVn LiBlQ3J5cHRGUykKICAgICB0bXBkaXIgPSBkLmdldFZhcignVE1QRElSJywgVHJ1ZSkKICAgICBz dGF0dXMuYWRkcmVzdWx0KGNoZWNrX2NyZWF0ZV9sb25nX2ZpbGVuYW1lKHRtcGRpciwgIlRNUERJ UiIpKQorICAgIHN0YXR1cy5hZGRyZXN1bHQoY2hlY2tfZmlsZXN5c3RlbV90eXBlKHRtcGRpciwg IlRNUERJUiIsIFsnbmZzJ10pKQogCiAgICAgIyBTb21lIHRoaXJkLXBhcnR5IHNvZnR3YXJlIGFw cGFyZW50bHkgcmVsaWVzIG9uIGNobW9kIGV0Yy4gYmVpbmcgc3VpZCByb290ICghISkKICAgICBp bXBvcnQgc3RhdAotLSAKMS44LjIuMQoK