<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>5453</bug_id>
          
          <creation_ts>2013-11-04 14:35:34 +0000</creation_ts>
          <short_desc>Remove the image_fstypes field from the builds table</short_desc>
          <delta_ts>2014-03-18 13:05:41 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>Toaster</product>
          <component>toaster</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard>needs test fixtures update</status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>1.6 M4</target_milestone>
          <dependson>5189</dependson>
          <blocked>5947</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Belen Barros Pena">belen.barros.pena</reporter>
          <assigned_to name="Cristiana Voicu">cristiana.voicu</assigned_to>
          <cc>alexandru.damian</cc>
    
    <cc>andreea.b.proca</cc>
    
    <cc>belen.barros.pena</cc>
    
    <cc>cristiana.voicu</cc>
    
    <cc>jessica.zhang</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>38468</commentid>
    <comment_count>0</comment_count>
    <who name="Belen Barros Pena">belen.barros.pena</who>
    <bug_when>2013-11-04 14:35:34 +0000</bug_when>
    <thetext>The image_fstypes field in the orm_build table was supposed to store information about a build&apos;s output (i.e. the extensions of the rootfs files created during the build, if any). But in its current implementation, the field stores the value of the IMAGE_FSTYPES variable instead. The build output information is provided only via the simple UI, and there is no way to obtain it via the API. To fix this, we should:

* Rename the image_fstypes field to &apos;output&apos;

* Make sure that it is populated only if build.outcome == 0 and target.is_image == true

* Change the simple interface to display the new &apos;output&apos; field</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38542</commentid>
    <comment_count>1</comment_count>
    <who name="Belen Barros Pena">belen.barros.pena</who>
    <bug_when>2013-11-05 13:59:43 +0000</bug_when>
    <thetext>The information the image_fstypes field was supposed to provide is stored by file_name in the target table. People can check the values stored in the IMAGE_FSTYPES variable using the configuration information. Therefore we don&apos;t need image_fstypes

We can use file_name to generate the &apos;output&apos; information in the simple interface.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38722</commentid>
    <comment_count>2</comment_count>
    <who name="Cristiana Voicu">cristiana.voicu</who>
    <bug_when>2013-11-12 14:02:25 +0000</bug_when>
    <thetext>I will implement this after we have a patch for 5189, in order to obtain the file_name.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>40491</commentid>
    <comment_count>3</comment_count>
    <who name="Alexandru Damian">alexandru.damian</who>
    <bug_when>2014-02-20 12:19:43 +0000</bug_when>
    <thetext>I am removing the image_fstypes field with the addition of Target_Image_File table that will hold generated image files information.

Fixtures needs updating.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>40884</commentid>
    <comment_count>4</comment_count>
    <who name="Andreea Brandusa Proca">andreea.b.proca</who>
    <bug_when>2014-03-05 13:50:48 +0000</bug_when>
    <thetext>This field is nor removed in master:f03955041d0e44d377ca1c4def630982f24f1e8b.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>40885</commentid>
    <comment_count>5</comment_count>
    <who name="Alexandru Damian">alexandru.damian</who>
    <bug_when>2014-03-05 14:05:23 +0000</bug_when>
    <thetext>Well, the patch is not merged into master, as the status says :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41066</commentid>
    <comment_count>6</comment_count>
    <who name="Alexandru Damian">alexandru.damian</who>
    <bug_when>2014-03-11 12:45:24 +0000</bug_when>
    <thetext>Database schema merged into origin/master</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41241</commentid>
    <comment_count>7</comment_count>
    <who name="Cristiana Voicu">cristiana.voicu</who>
    <bug_when>2014-03-14 14:35:15 +0000</bug_when>
    <thetext>The image_fstypes field was removed from the build table, so this bug is resolved. The changes needed to replace it is the purpose of bug 5947, so this one can be closed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>41364</commentid>
    <comment_count>8</comment_count>
    <who name="Belen Barros Pena">belen.barros.pena</who>
    <bug_when>2014-03-18 13:05:41 +0000</bug_when>
    <thetext>Verified in 

master:e58089b9d708ba176594a758580cc52c23725a5b</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>