5476 2013-11-05 15:14:38 +0000 [yocto-bsp] find_bblayers fails with Python error if bitbake_env_cmd fails 2013-12-18 16:47:32 +0000 1 1 7 Build System, Metadata & Runtime Meta-yocto configuration unspecified x86 Multiple RESOLVED FIXED Medium normal 1.6 1 bastien.jauny tom.zanussi poky.bs.watcher poky.watcher --- --- Don't know oldest_to_newest 38544 0 bastien.jauny 2013-11-05 15:14:38 +0000 In scripts/lib/bsp/kernel.py, find_bblayers() fails in case bitbake_env_cmd doesn't output BBLAYERS. This is due to a bad Python formatted string on line 66. To reproduce: 1)In your build directory, set up an unexisting layer in conf/bblayers.conf (that will make 'bitbake -e' fail) 2)Call yocto-bsp create with any target arch. Actual results: The script fails with a TypeError. Expected results: The script fails with an error message describing the cause. Here's a proposed patch: --- /home/bjauny/yocto/poky-dora/scripts/lib/bsp/kernel.py 2013-11-05 16:13:38.250129173 +0100 +++ /home/bjauny/yocto/poky-dora/scripts/lib/bsp/kernel.py.new 2013-11-05 16:13:17.042128497 +0100 @@ -62,7 +62,7 @@ break if not bblayers: - print "Couldn't find BBLAYERS in 'bitbake -e' output, exiting." % \ + print "Couldn't find BBLAYERS in %s output, exiting." % \ bitbake_env_cmd sys.exit(1) Seen on dora head revision. 38545 1 1608 bastien.jauny 2013-11-05 15:16:53 +0000 Created attachment 1608 Proposed patch Attached proposed patch. 38737 2 tom.zanussi 2013-11-13 14:34:43 +0000 Hi, I've verified the problem and the patch looks good - feel free to submit it to the poky mailing list, or if you'd rather, I can do that (and give you credit). 38740 3 bastien.jauny 2013-11-13 15:08:05 +0000 Hi Tom, I'm not used to the mailing list process. Should I just post a new thread describing this bug or do I also need to commit my patch? Sorry if these are noob questions but I'm brand new to this, even if I used yocto intensively the last months. (In reply to comment #2) > Hi, I've verified the problem and the patch looks good - feel free to submit > it to the poky mailing list, or if you'd rather, I can do that (and give you > credit). 38741 4 tom.zanussi 2013-11-13 15:31:23 +0000 (In reply to comment #3) > Hi Tom, > I'm not used to the mailing list process. Should I just post a new thread > describing this bug or do I also need to commit my patch? Sorry if these are > noob questions but I'm brand new to this, even if I used yocto intensively > the last months. > > (In reply to comment #2) > > Hi, I've verified the problem and the patch looks good - feel free to submit > > it to the poky mailing list, or if you'd rather, I can do that (and give you > > credit). You can just submit the patch to the poky mailing list - the patch itself should describe teh problem and what you did to fix it. Here are some basic instructions on how you can do that - let me know if you need help with any of it. https://wiki.yoctoproject.org/wiki/Poky_Contributions If you don't want to go to the trouble of getting poky-contrib access, since this is such a simple patch, you could just send the patch in e-mail only e.g. make your change in git, 'tit commit -s' the change, then do 'git format-patch -1' and send that patch to the list. 38750 5 bastien.jauny 2013-11-13 18:07:36 +0000 (In reply to comment #4) > (In reply to comment #3) > > Hi Tom, > > I'm not used to the mailing list process. Should I just post a new thread > > describing this bug or do I also need to commit my patch? Sorry if these are > > noob questions but I'm brand new to this, even if I used yocto intensively > > the last months. > > > > (In reply to comment #2) > > > Hi, I've verified the problem and the patch looks good - feel free to submit > > > it to the poky mailing list, or if you'd rather, I can do that (and give you > > > credit). > > You can just submit the patch to the poky mailing list - the patch itself > should describe teh problem and what you did to fix it. Here are some basic > instructions on how you can do that - let me know if you need help with any > of it. > > https://wiki.yoctoproject.org/wiki/Poky_Contributions > > If you don't want to go to the trouble of getting poky-contrib access, since > this is such a simple patch, you could just send the patch in e-mail only > e.g. make your change in git, 'tit commit -s' the change, then do 'git > format-patch -1' and send that patch to the list. Just did your latest suggestion. Screwed up a little bit my mail, but I'll correct that. Thanks! 39478 6 tom.zanussi 2013-12-18 16:47:32 +0000 Fixed by poky/master commit: d60b4ff3517487bd111c6d7e1410882280229377 1608 2013-11-05 15:16:53 +0000 2013-11-05 15:16:53 +0000 Proposed patch kernel.py.patch text/plain 451 bastien.jauny LS0tIC9ob21lL2JqYXVueS95b2N0by9wb2t5LWRvcmEvc2NyaXB0cy9saWIvYnNwL2tlcm5lbC5w eQkyMDEzLTExLTA1IDE2OjEzOjM4LjI1MDEyOTE3MyArMDEwMAorKysgL2hvbWUvYmphdW55L3lv Y3RvL3Bva3ktZG9yYS9zY3JpcHRzL2xpYi9ic3Ava2VybmVsLnB5Lm5ldwkyMDEzLTExLTA1IDE2 OjEzOjE3LjA0MjEyODQ5NyArMDEwMApAQCAtNjIsNyArNjIsNyBAQAogICAgICAgICAgICAgYnJl YWsKIAogICAgIGlmIG5vdCBiYmxheWVyczoKLSAgICAgICAgcHJpbnQgIkNvdWxkbid0IGZpbmQg QkJMQVlFUlMgaW4gJ2JpdGJha2UgLWUnIG91dHB1dCwgZXhpdGluZy4iICUgXAorICAgICAgICBw cmludCAiQ291bGRuJ3QgZmluZCBCQkxBWUVSUyBpbiAlcyBvdXRwdXQsIGV4aXRpbmcuIiAlIFwK ICAgICAgICAgICAgIGJpdGJha2VfZW52X2NtZAogICAgICAgICBzeXMuZXhpdCgxKQogCg==