<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>5571</bug_id>
          
          <creation_ts>2013-11-20 09:39:08 +0000</creation_ts>
          <short_desc>Re-validate checksums in do_unpack</short_desc>
          <delta_ts>2015-03-10 14:15:48 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>BitBake</product>
          <component>bitbake</component>
          <version>1.4</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>1.8</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ross Burton">ross.burton</reporter>
          <assigned_to name="Alejandro Hernandez">alejandro.hernandez</assigned_to>
          <cc>alejandro.hernandez</cc>
    
    <cc>clemens.lang</cc>
    
    <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
    
    <cc>sgw</cc>
    
    <cc>yi.zhao</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>38920</commentid>
    <comment_count>0</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2013-11-20 09:39:08 +0000</bug_when>
    <thetext>If I have a recipe with correct checksums in, fetch the tarballs, and then change the checksums (either deliberately or accidentally) subsequent rebuilds of that recipe won&apos;t re-validate the tarballs.  This can result in recipes being submitted that don&apos;t actually build.

I think that do_extract() should also verify checksums, ideally with a fast-path for the common case where the metadata doesn&apos;t change between do_fetch and do_extract.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38941</commentid>
    <comment_count>1</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2013-11-20 14:28:00 +0000</bug_when>
    <thetext>Its fetcher design that checksums get checked after the file is downloaded. If the file is already present with the &quot;done&quot; stamp, its assumed the checksums were checked and are right.

Checksumming the files at do_unpack adds significant overhead unfortunately.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38944</commentid>
    <comment_count>2</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2013-11-20 14:36:39 +0000</bug_when>
    <thetext>Thinking a bit further there is a half way house on this. We should write the checksum into the .done file and where we already have an existing file, we can just verify the checksum in the file matches. This would prevent the common case of errors.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>45748</commentid>
    <comment_count>3</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2014-09-22 16:19:22 +0000</bug_when>
    <thetext>A post to yocto@ spoke about a related problem: disk corruption.  I&apos;m not convinced we should cater for failing disks as the problems won&apos;t be restricted to the source cache, but everything that gets written to disk.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>46743</commentid>
    <comment_count>4</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2014-11-04 09:44:08 +0000</bug_when>
    <thetext>*** Bug 6923 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>49329</commentid>
    <comment_count>5</comment_count>
    <who name="Clemens Lang">clemens.lang</who>
    <bug_when>2015-03-10 14:15:48 +0000</bug_when>
    <thetext>This has been fixed in http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=36e47a99ae6668cb9a601f137f56011b7de13512.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>