<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>5627</bug_id>
          
          <creation_ts>2013-12-04 13:56:52 +0000</creation_ts>
          <short_desc>Detect and fail when S has been set incorrectly</short_desc>
          <delta_ts>2015-01-24 15:17:07 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>1.6</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Low</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>Future</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Paul Eggleton">bluelightning</reporter>
          <assigned_to name="Petter">petter</assigned_to>
          <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>petter</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>39225</commentid>
    <comment_count>0</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2013-12-04 13:56:52 +0000</bug_when>
    <thetext>At the moment we end up creating S if it&apos;s not created by unpacking an archive or fetching a repository; this is not really ideal in the case where S hasn&apos;t been properly set to match where the source actually has been unpacked. Ideally, we should avoid creating S, and then we can know when S hasn&apos;t been set correctly because it won&apos;t exist, and then we can fail immediately with an appropriate error message telling the user they need to set S, rather than failing with odd errors in later tasks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>47718</commentid>
    <comment_count>1</comment_count>
    <who name="Petter">petter</who>
    <bug_when>2015-01-02 23:42:04 +0000</bug_when>
    <thetext>After discussion with Paul the conclusion is that the fix probably should result in a warning (at least to start with). Since I already have found around 10 recipes with faulty $S (for example S=WORKDIR/$PN (default) instead of S=WORKDIR) in oe-core, you might assume that a lot of external layers have recipes with this problem as well and display an error and abort might be a bit to hard. At least until people have had the chance to clean this up.

Will try to fix faulty &apos;S&apos; within the scope of this bug as well..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>47758</commentid>
    <comment_count>2</comment_count>
    <who name="Petter">petter</who>
    <bug_when>2015-01-06 21:34:20 +0000</bug_when>
    <thetext>WIP commits:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=petmab/bug5627</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>48012</commentid>
    <comment_count>3</comment_count>
    <who name="Petter">petter</who>
    <bug_when>2015-01-16 22:19:07 +0000</bug_when>
    <thetext>Send for upstream approval.

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=petmab/bug5627 (oe-core)

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=petmab/bug5627_m-y (meta-yocto)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>48013</commentid>
    <comment_count>4</comment_count>
    <who name="Petter">petter</who>
    <bug_when>2015-01-16 22:22:53 +0000</bug_when>
    <thetext>Verified by running:

$ bitbake world (with and without sstate)
$ bitbake world + archiver enabled
$ Manually build + rebuild of affected (changed S value) recipes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>48272</commentid>
    <comment_count>5</comment_count>
    <who name="Petter">petter</who>
    <bug_when>2015-01-24 15:17:07 +0000</bug_when>
    <thetext>Fixed in cf72ede74d35746a10d0708942287548f9c72f30 (poky).

Removed Bug 4634 (https://bugzilla.yoctoproject.org/show_bug.cgi?id=4634) as a depend to this bug, since it&apos;s more &apos;related&apos; than a depend..</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>