<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>5717</bug_id>
          
          <creation_ts>2014-01-13 01:43:23 +0000</creation_ts>
          <short_desc>GITSM fetcher should use ud.basecmd</short_desc>
          <delta_ts>2014-01-28 11:58:58 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>BitBake</product>
          <component>bitbake</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>1.6</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Rudolf J Streif">rudolf.streif</reporter>
          <assigned_to name="Richard Purdie">richard.purdie</assigned_to>
          <cc>bluelightning</cc>
    
    <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>39758</commentid>
    <comment_count>0</comment_count>
    <who name="Rudolf J Streif">rudolf.streif</who>
    <bug_when>2014-01-13 01:43:23 +0000</bug_when>
    <thetext>The gitsm fetcher inherits from the git fetcher but it does hardcodes git into the runfetchcmd() calls in update_submodules():

def update_submodules(self, u, ud, d):
...
        runfetchcmd(&quot;git reset --hard&quot;, d)
        runfetchcmd(&quot;git submodule init&quot;, d)
        runfetchcmd(&quot;git submodule update&quot;, d)
...

It should use ud.basecmd instead. (Interestingly enough it does so in uses_submodules()). That is merely an inconsistency. However, it also does not allow for FETCHCMD_git to be used to override the command.

Proposed fix:

        runfetchcmd(&quot;%s reset --hard&quot; % (ud.basecmd), d)
        runfetchcmd(&quot;%s submodule init&quot; % (ud.basecmd), d)
        runfetchcmd(&quot;%s submodule update&quot; % (ud.basecmd), d)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>40056</commentid>
    <comment_count>1</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2014-01-28 11:58:58 +0000</bug_when>
    <thetext>Fixed in master http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=7b580cd25c09f178515282ad7b74de7e8672374e</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>