5863 2014-02-21 14:43:40 +0000 Do not duplicate the same conf notes from oe-core 2014-02-25 10:37:38 +0000 1 1 7 Build System, Metadata & Runtime Meta-yocto meta-yocto unspecified x86 Multiple RESOLVED WONTFIX Low normal 1.6 M4 1 lpapp richard.purdie ndec13 poky.bs.watcher poky.watcher --- --- Don't know oldest_to_newest 40593 0 lpapp 2014-02-21 14:43:40 +0000 ./meta-yocto/conf/conf-notes.txt and ./meta/conf/conf-notes.txt are identical. It should be possible to inherit the file from oe-core in my opinion if the desired content is the same. This can cause sync overhead, et cetera. If one likes to customize it, it is possible by having that file with a different content, but for the same content, it looks a bit strange a duplication. 40661 1 richard.purdie 2014-02-25 10:07:52 +0000 The TEMPLATECONF directory is used to contain conf-notes.txt and things like local.conf.sample. It can only be set to one directory so if you change it, you take copies of the set of files. We could add a ton of complexity for fallbacks and so on to remove the file duplication however I think the duplicate file isn't a big issue in this case. In most cases you would want to customise *all* the files. So basically, it doesn't make sense to change this. 40662 2 lpapp 2014-02-25 10:11:03 +0000 > We could add a ton of complexity for fallbacks. It would be literally a few lines in the bash script where it is set up. I am assume it could be done in less than five, eventually. Please let me know why it would not be that simple. 40663 3 richard.purdie 2014-02-25 10:19:11 +0000 Its adding complexity into a location where I don't believe we want or need it. We try to keep the init scripts as simple and clean as possible. The "poky" case is one of the few cases where a copy of that file makes sense, nearly every other user would modify it. So my answer remains as stated, I don't believe we need or want this. 40667 4 lpapp 2014-02-25 10:32:30 +0000 In fact, this "complexity" is already in there: http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/scripts/oe-setup-builddir#n121 So, there would be no any need for the meta-yocto layer to keep it. So, you could either remove that "complexity" (IMHO bad idea), or remove the complexity from the meta-yocto layer. 40669 5 lpapp 2014-02-25 10:35:42 +0000 I was not probably clear, so most of the complexity is already in there, and adding one line allow to remove a whole file in meta-yocto and elsewhere where the users are happy with the default. The required change is basically a one-liner in here: OECORENOTESCONF="$TEMPLATECONF/conf-notes.txt" to: if ! (test -r ""$TEMPLATECONF/conf-notes.txt"); then OECORENOTESCONF="$TEMPLATECONF/conf-notes.txt" or something like that. 40670 6 lpapp 2014-02-25 10:37:38 +0000 Hmm, I cannot still edit comment on bugzilla, so I made a mistake about the negation, so that would not even be needed, so it would be even simpler than my previous one-liner. :-)