<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>6349</bug_id>
          
          <creation_ts>2014-05-20 13:29:16 +0000</creation_ts>
          <short_desc>distro_features_check.bbclass never fails</short_desc>
          <delta_ts>2014-05-22 13:38:41 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.7</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sebastian Wiegand">sebastian.wiegand</reporter>
          <assigned_to name="Saul Wold">sgw</assigned_to>
          <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>43422</commentid>
    <comment_count>0</comment_count>
      <attachid>1968</attachid>
    <who name="Sebastian Wiegand">sebastian.wiegand</who>
    <bug_when>2014-05-20 13:29:16 +0000</bug_when>
    <thetext>Created attachment 1968
Patch for wrong indentation

The check for REQUIRED_DISTRO_FEATURES in distro_features_check.bbclass never fails as the indentation is not correct.
Python needs right indentation, and the else case for the if is in wrong indentation level.
That way &quot;else&quot; is never called an never fails.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>43495</commentid>
    <comment_count>1</comment_count>
    <who name="Saul Wold">sgw</who>
    <bug_when>2014-05-22 13:38:41 +0000</bug_when>
    <thetext>http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=1532ea067d084e1659a0cb9a6374da1e6c86ba1f</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>1968</attachid>
            <date>2014-05-20 13:29:16 +0000</date>
            <delta_ts>2014-05-20 13:29:16 +0000</delta_ts>
            <desc>Patch for wrong indentation</desc>
            <filename>file_6349.txt</filename>
            <type>text/plain</type>
            <size>1229</size>
            <attacher name="Sebastian Wiegand">sebastian.wiegand</attacher>
            
              <data encoding="base64">RnJvbSBlMTdkNmJlZGIzZDViOGJiOGVjNGJjNGYxYmZlM2I1MWJjOGVkNjQzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQ0KRnJvbTogU2ViYXN0aWFuIFdpZWdhbmQgPHNlYmFzdGlhbi53aWVnYW5k
QGdlcnN5cy5kZT4NCkRhdGU6IFR1ZSwgMjAgTWF5IDIwMTQgMTU6MjI6NDEgKzAyMDANClN1Ympl
Y3Q6IFtQQVRDSF0gZGlzdHJvX2ZlYXR1cmVzX2NoZWNrLmJiY2xhc3M6IGZpeCB3cm9uZyBpbmRl
bnRhdGlvbg0KDQpUbyBmaXggY2hlY2sgb2YgUkVRVUlSRURfRElTVFJPX0ZFQVRVUkVTIGZpeCBp
bmRlbnRhdGlvbiBpbiBweXRob24gY29kZS4NCi0tLQ0KIG1ldGEvY2xhc3Nlcy9kaXN0cm9fZmVh
dHVyZXNfY2hlY2suYmJjbGFzcyB8ICAgIDQgKystLQ0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy
dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9tZXRhL2NsYXNzZXMvZGlz
dHJvX2ZlYXR1cmVzX2NoZWNrLmJiY2xhc3MgYi9tZXRhL2NsYXNzZXMvZGlzdHJvX2ZlYXR1cmVz
X2NoZWNrLmJiY2xhc3MNCmluZGV4IDYxYjExYjcuLjhhMGVjYjcgMTAwNjQ0DQotLS0gYS9tZXRh
L2NsYXNzZXMvZGlzdHJvX2ZlYXR1cmVzX2NoZWNrLmJiY2xhc3MNCisrKyBiL21ldGEvY2xhc3Nl
cy9kaXN0cm9fZmVhdHVyZXNfY2hlY2suYmJjbGFzcw0KQEAgLTE1LDggKzE1LDggQEAgcHl0aG9u
ICgpIHsNCiAgICAgICAgIGZvciBmIGluIHJlcXVpcmVkX2Rpc3Ryb19mZWF0dXJlczoNCiAgICAg
ICAgICAgICBpZiBmIGluIGRpc3Ryb19mZWF0dXJlczoNCiAgICAgICAgICAgICAgICAgYnJlYWsN
Ci0gICAgICAgIGVsc2U6DQotICAgICAgICAgICAgcmFpc2UgYmIucGFyc2UuU2tpcFBhY2thZ2Uo
Im1pc3NpbmcgcmVxdWlyZWQgZGlzdHJvIGZlYXR1cmUgJXMgKG5vdCBpbiBESVNUUk9fRkVBVFVS
RVMpIiAlIHJlcXVpcmVkX2Rpc3Ryb19mZWF0dXJlcykNCisgICAgICAgICAgICBlbHNlOg0KKyAg
ICAgICAgICAgICAgICByYWlzZSBiYi5wYXJzZS5Ta2lwUGFja2FnZSgibWlzc2luZyByZXF1aXJl
ZCBkaXN0cm8gZmVhdHVyZSAlcyAobm90IGluIERJU1RST19GRUFUVVJFUykiICUgcmVxdWlyZWRf
ZGlzdHJvX2ZlYXR1cmVzKQ0KIA0KICAgICBjb25mbGljdF9kaXN0cm9fZmVhdHVyZXMgPSBkLmdl
dFZhcignQ09ORkxJQ1RfRElTVFJPX0ZFQVRVUkVTJywgVHJ1ZSkNCiAgICAgaWYgY29uZmxpY3Rf
ZGlzdHJvX2ZlYXR1cmVzOg0KLS0gDQoxLjcuOS41DQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>