<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>6378</bug_id>
          
          <creation_ts>2014-05-28 10:03:27 +0000</creation_ts>
          <short_desc>libfakekey patch to allow shift-ed version of symbol not already in keymap</short_desc>
          <delta_ts>2017-07-17 13:51:35 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>Matchbox</product>
          <component>matchbox</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Finn">finn</reporter>
          <assigned_to name="Jussi Kukkonen">jku</assigned_to>
          <cc>richard.purdie</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>43613</commentid>
    <comment_count>0</comment_count>
      <attachid>1981</attachid>
    <who name="Finn">finn</who>
    <bug_when>2014-05-28 10:03:27 +0000</bug_when>
    <thetext>Created attachment 1981
patch

Sorry if this is the wrong place to offer a fakekey patch, I couldn&apos;t find anywhere better but I&apos;d be happy to be redirected.

If my keymap is set to US and I use fakekey_press_keysym to send a Ó the character isn&apos;t already in my keymap so fakekey adds it but then sends ó instead. My patch now does the same check if a shift modifier is required that&apos;s done in the code path for keys that are already in the keymap.

The code has some comments that make me think this check may be dodgy but it fixes the problem for me on fedora 18.

Note &quot;Ó&quot; is just an example any character that uses a shift modifier and isn&apos;t already in your keymap suffers this problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>67126</commentid>
    <comment_count>1</comment_count>
    <who name="Jussi Kukkonen">jku</who>
    <bug_when>2016-10-11 07:51:34 +0000</bug_when>
    <thetext>Did not have time to look at fakekey at all so I&apos;ll have to push this forward once more.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73277</commentid>
    <comment_count>2</comment_count>
    <who name="Jussi Kukkonen">jku</who>
    <bug_when>2017-05-16 09:02:19 +0000</bug_when>
    <thetext>Ahh, I&apos;ve completely forgotten this. Partly because I dread modifying ancient code with comments like this:

       * There&apos;s no way whatsoever that this could ever possibly
       * be guaranteed to work (ever), but it does.


...but I&apos;m going to do this now: I&apos;ll do some whitespace modifications and probably remove the &quot;code = 0&quot; line in the error case (just to keep changes to a minimum) but otherwise this seems good to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73293</commentid>
    <comment_count>3</comment_count>
    <who name="Jussi Kukkonen">jku</who>
    <bug_when>2017-05-17 11:51:46 +0000</bug_when>
    <thetext>Committed to libfakekey master.

I&apos;ll keep this issue open until I&apos;ve integrated into oe-core as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75065</commentid>
    <comment_count>4</comment_count>
    <who name="Jussi Kukkonen">jku</who>
    <bug_when>2017-07-17 13:51:35 +0000</bug_when>
    <thetext>commit 8656af385666802ba5d4ee5f42780386b13e3cb0
Author: Alexander Kanavin &lt;alexander.kanavin@linux.intel.com&gt;
Date:   Mon Jun 19 14:44:43 2017 +0300

    libfakekey: upgrade to 0.3+gitAUTOINC+7ad885912e
    
    (From OE-Core rev: 9adc1baf815ee06c3317b51f459dbb921e0e6de5)
    
    Signed-off-by: Alexander Kanavin &lt;alexander.kanavin@linux.intel.com&gt;
    Signed-off-by: Richard Purdie &lt;richard.purdie@linuxfoundation.org&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>1981</attachid>
            <date>2014-05-28 10:03:27 +0000</date>
            <delta_ts>2014-05-28 10:03:27 +0000</delta_ts>
            <desc>patch</desc>
            <filename>apply-shift-to-keys-added-to-map.patch</filename>
            <type>text/plain</type>
            <size>791</size>
            <attacher name="Finn">finn</attacher>
            
              <data encoding="base64">ZGlmZiAtdU5yIGxpYmZha2VrZXktMC4xL3NyYy9saWJmYWtla2V5LmMgbGliZmFrZWtleS0wLjEu
bmV3L3NyYy9saWJmYWtla2V5LmMKLS0tIGxpYmZha2VrZXktMC4xL3NyYy9saWJmYWtla2V5LmMJ
MjAwNS0xMC0wMiAyMzowNzozNC4wMDAwMDAwMDAgKzAxMDAKKysrIGxpYmZha2VrZXktMC4xLm5l
dy9zcmMvbGliZmFrZWtleS5jCTIwMTQtMDUtMjggMDk6MjU6NTguMTIyNzgyNjMxICswMTAwCkBA
IC0zNTIsNiArMzUyLDE4IEBACiAgICAgICAgKiBQcm9iYWJseSBiZXR0ZXIgdG8gdHJ5IGFuZCBn
cmFiIHRoZSBtYXBwaW5nIG5vdGlmeSAqaGVyZSogPwogICAgICAgICovCiAgIAorICAgICAgaWYg
KFhLZXljb2RlVG9LZXlzeW0oZmstPnhkcHksIGNvZGUsIDApICE9IGtleXN5bSkKKwkgIHsKKwkg
ICAgREJHKCJkb2VzIG5vdCBlcXVhbCBjb2RlIGZvciBpbmRleCBvLCBuZWVkcyBzaGlmdD9cbiIp
OworCSAgICAvKiBUT0RPOiBBc3N1bWVzIDFzdCBtb2RpZmllciBpcyBzaGlmdGVkICAqLworCSAg
ICBpZiAoWEtleWNvZGVUb0tleXN5bShmay0+eGRweSwgY29kZSwgMSkgPT0ga2V5c3ltKQorCSAg
ICAgIGZsYWdzIHw9IEZBS0VLRVlNT0RfU0hJRlQ7IAkvKiBjYW4gZ2V0IGF0IGl0IHZpYSBzaGlm
dCAqLworICAgICAgICBlbHNlCisgICAgICAgIHsKKyAgICAgICAgICBEQkcoImF0dGVtcHRlZCB0
byBhZGQga2V5Y29kZSB0byBrZXltYXAgYnV0IGZhaWxlZCIpOworICAgICAgICAgIGNvZGUgPSAw
OworICAgICAgICB9CisgICAgICB9CiAgICAgfQogCiAgIGlmIChjb2RlICE9IDApIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>