<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>6461</bug_id>
          
          <creation_ts>2014-06-18 04:41:22 +0000</creation_ts>
          <short_desc>split_kernel_module_packages fails for meta-intel BSPs</short_desc>
          <delta_ts>2014-06-18 16:02:32 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>kernel</component>
          <version>1.7</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Undecided</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Nitin Kamble">nitin.a.kamble</reporter>
          <assigned_to name="Darren Hart">dvhart</assigned_to>
          <cc>bruce.ashfield</cc>
    
    <cc>tom.zanussi</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>44049</commentid>
    <comment_count>0</comment_count>
    <who name="Nitin Kamble">nitin.a.kamble</who>
    <bug_when>2014-06-18 04:41:22 +0000</bug_when>
    <thetext>ERROR: Error executing a python function in /home/nitin/build-test-bsps/poky.git/meta/recipes-kernel/linux/linux-yocto_3.14.bb:

The stack trace of python calls that resulted in this exception/failure was:
File: &apos;split_kernel_module_packages&apos;, lineno: 164, function: &lt;module&gt;
     0160:        if len(os.listdir(dir)) == 0:
     0161:            os.rmdir(dir)
     0162:
     0163:
 *** 0164:split_kernel_module_packages(d)
     0165:
File: &apos;split_kernel_module_packages&apos;, lineno: 150, function: split_kernel_module_packages
     0146:
     0147:    postinst = d.getVar(&apos;pkg_postinst_modules&apos;, True)
     0148:    postrm = d.getVar(&apos;pkg_postrm_modules&apos;, True)
     0149:
 *** 0150:    modules = do_split_packages(d, root=&apos;/lib/modules&apos;, file_regex=module_regex, output_pattern=module_pattern, description=&apos;%s kernel module&apos;, postinst=postinst, postrm=postrm, recursive=True, hook=frob_metadata, extra_depends=&apos;kernel-%s&apos; % (d.getVar(&quot;KERNEL_VERSION&quot;, True)))
     0151:    if modules:
     0152:        metapkg = d.getVar(&apos;KERNEL_MODULES_META_PACKAGE&apos;, True)
     0153:        d.appendVar(&apos;RDEPENDS_&apos; + metapkg, &apos; &apos;+&apos; &apos;.join(modules))
     0154:
File: &apos;package.bbclass&apos;, lineno: 148, function: do_split_packages
     0144:                d.setVar(&apos;pkg_postrm_&apos; + pkg, postrm)
     0145:        else:
     0146:            d.setVar(&apos;FILES_&apos; + pkg, oldfiles + &quot; &quot; + newfile)
     0147:        if callable(hook):
 *** 0148:            hook(f, pkg, file_regex, output_pattern, m.group(1))
     0149:
     0150:    d.setVar(&apos;PACKAGES&apos;, &apos; &apos;.join(packages))
     0151:    return split_packages
     0152:
File: &apos;split_kernel_module_packages&apos;, lineno: 109, function: frob_metadata
  File &quot;split_kernel_module_packages&quot;, line 109, in frob_metadata

Exception: AttributeError: &apos;NoneType&apos; object has no attribute &apos;split&apos;

ERROR: Function failed: split_kernel_module_packages
ERROR: Logfile of failure stored in: /srv/home/nitin/build-test-bsps/build-common/tmp/work/corei7-64-intel-common-poky-linux/linux-yocto/3.14.4+gitAUTOINC+62f236c734_cb22733185-r0/temp/log.do_package.67449
ERROR: Task 18 (/home/nitin/build-test-bsps/poky.git/meta/recipes-kernel/linux/linux-yocto_3.14.bb, do_package) failed with exit code &apos;1&apos;
NOTE: Tasks Summary: Attempted 401 tasks of which 400 didn&apos;t need to be rerun and 1 failed.
No currently running tasks (390 of 404)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>44050</commentid>
    <comment_count>1</comment_count>
    <who name="Nitin Kamble">nitin.a.kamble</who>
    <bug_when>2014-06-18 04:50:15 +0000</bug_when>
    <thetext>&apos;bitbake -e virtual/kernel&apos; shows this:
KERNEL_MODULE_AUTOLOAD=&quot; uio iwlwif&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>44051</commentid>
    <comment_count>2</comment_count>
    <who name="Nitin Kamble">nitin.a.kamble</who>
    <bug_when>2014-06-18 04:51:36 +0000</bug_when>
    <thetext>And the kernel recipe has these lines:

# For Crystalforest and Romley
KERNEL_MODULE_AUTOLOAD += &quot;uio&quot;

# For FRI2, NUC
KERNEL_MODULE_AUTOLOAD += &quot;iwlwifi&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>44052</commentid>
    <comment_count>3</comment_count>
    <who name="Nitin Kamble">nitin.a.kamble</who>
    <bug_when>2014-06-18 05:44:16 +0000</bug_when>
    <thetext>for me this is fixing the build issue:

RP, is this the right fix?

diff --git a/meta/classes/kernel-module-split.bbclass b/meta/classes/kernel-module-split.bbclass
index e38a6f6..088de5f 100644
--- a/meta/classes/kernel-module-split.bbclass
+++ b/meta/classes/kernel-module-split.bbclass
@@ -137,7 +137,7 @@ python split_kernel_module_packages () {
         if basename in autoloadlist:
             name = &apos;%s/etc/modules-load.d/%s.conf&apos; % (dvar, basename)
             f = open(name, &apos;w&apos;)
-            for m in autoload.split():
+            for m in autoloadlist:
                 f.write(&apos;%s\n&apos; % m)
             f.close()
             postinst = d.getVar(&apos;pkg_postinst_%s&apos; % pkg, True)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>44061</commentid>
    <comment_count>4</comment_count>
    <who name="Nitin Kamble">nitin.a.kamble</who>
    <bug_when>2014-06-18 16:02:32 +0000</bug_when>
    <thetext>Richard commited a corrected version of my attempted of fix.


commit dae258afc85431169ff17f0a50061fc3a3ef6526
Author: Richard Purdie &lt;richard.purdie@linuxfoundation.org&gt;
Date:   Wed Jun 18 10:39:39 2014 +0100

    kernel-module-split: Fix KERNEL_MODULE_AUTOLOAD handling
    
    Addresses the problem:
    
    The stack trace of python calls that resulted in this exception/failure was:
    File: &apos;split_kernel_module_packages&apos;, lineno: 164, function: &lt;module&gt;
         0160:        if len(os.listdir(dir)) == 0:
         0161:            os.rmdir(dir)
         0162:
         0163:
     *** 0164:split_kernel_module_packages(d)
         0165:
    File: &apos;split_kernel_module_packages&apos;, lineno: 150, function: split_kernel_module_packages
         0146:     0147:    postinst = d.getVar(&apos;pkg_postinst_modules&apos;, True)
         0148:    postrm = d.getVar(&apos;pkg_postrm_modules&apos;, True)
         0149:
     *** 0150:    modules = do_split_packages(d, root=&apos;/lib/modules&apos;, file_regex=module_regex, output_pattern=module_pattern, description=&apos;%s kernel module&apos;, postinst=postinst, postrm=postrm, recursive=True, hook=frob_metadata, extra_depends=&apos;kernel-%s&apos; % (d.getVar(&quot;KERNEL_VERSION&quot;, True)))
         0151:    if modules:
         0152:        metapkg = d.getVar(&apos;KERNEL_MODULES_META_PACKAGE&apos;, True)
         0153:        d.appendVar(&apos;RDEPENDS_&apos; + metapkg, &apos; &apos;+&apos; &apos;.join(modules))
         0154:
    File: &apos;package.bbclass&apos;, lineno: 148, function: do_split_packages
         0144:                d.setVar(&apos;pkg_postrm_&apos; + pkg, postrm)
         0145:        else:
         0146:            d.setVar(&apos;FILES_&apos; + pkg, oldfiles + &quot; &quot; + newfile)
         0147:        if callable(hook):
     *** 0148:            hook(f, pkg, file_regex, output_pattern, m.group(1))
         0149:
         0150:    d.setVar(&apos;PACKAGES&apos;, &apos; &apos;.join(packages))
         0151:    return split_packages
         0152:
    File: &apos;split_kernel_module_packages&apos;, lineno: 109, function: frob_metadata
    File &quot;split_kernel_module_packages&quot;, line 109, in frob_metadata
    
    Exception: AttributeError: &apos;NoneType&apos; object has no attribute &apos;split&apos;
    
    ERROR: Function failed: split_kernel_module_packages
    
    [YOCTO #6461]
    
    [a revised version of a patch from Nitin Kamble]
    
    (From OE-Core rev: f30d12b4fbfe7d6b581598efa9ceca69dcfb4294)
    
    Signed-off-by: Richard Purdie &lt;richard.purdie@linuxfoundation.org&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>