6711 2014-09-11 17:28:41 +0000 SendErrorReport has codepath to a None command 2014-09-16 23:14:22 +0000 1 1 5 Infrastructure AutoBuilder autobuilder unspecified Other other RESOLVED FIXED Undecided normal --- 1 eantelman elizabeth.flanagan eantelman elizabeth.flanagan infras.ab.watcher Infras.watcher --- --- No (bug/feature does not impact docs) oldest_to_newest 45545 0 eantelman 2014-09-11 17:28:41 +0000 If ERROR_REPORT_COLLECT is not defined, it will abort the build by finding a none command. In master/HEAD at dc75c7eefba00dac I think what you want is.... diff --git a/lib/python2.7/site-packages/autobuilder/buildsteps/SendErrorReport.py b/lib/python2.7/site-packages/autobuilder/buildsteps/SendErrorReport.py index 159c33a..5441f31 100644 --- a/lib/python2.7/site-packages/autobuilder/buildsteps/SendErrorReport.py +++ b/lib/python2.7/site-packages/autobuilder/buildsteps/SendErrorReport.py @@ -50,6 +50,8 @@ class SendErrorReport(ShellCommand): self.errorreportserver = "" self.command = "if [ ! -f ~/.oe-send-error ]; then host=`hostname`; echo \"yocto-autobuilder-autogenerated-$host\" > ~/.oe-send-error; fi ; " self.command += ". ./oe-init-build-env; if [ -d " + self.errordir +"/$x" + " ]; then for x in `ls " + self.errordir +" | grep error_report_`; do send-error-report " + sel + else: + self.command = "echo environment var ERROR_REPORT_COLLECT not set - Step is noop" self.description = ["Sending error reports"] ShellCommand.start(self) 45546 1 elizabeth.flanagan 2014-09-11 18:38:21 +0000 Yes, this is the exact fix. Can you send me a signed-off-by patch so I can apply your work? Thanks! 45547 2 2123 eantelman 2014-09-11 19:43:57 +0000 Created attachment 2123 Signed-off-by formated patch 45639 3 elizabeth.flanagan 2014-09-16 23:14:22 +0000 http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?id=2bce1599a49725e154c0b092b7f41731827b9283 Thank you for your commit. Pulled into master and production. 2123 2014-09-11 19:43:57 +0000 2014-09-11 19:43:57 +0000 Signed-off-by formated patch 0001-If-ERROR_REPORT_COLLECT-is-not-defined-it-will-abort.patch text/plain 1510 eantelman RnJvbSA4NzQyMjc4YWFjZGVjMGI3YTI2YzkwMDM2MjE3ZjZlZDlmYjZkNDRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFcmlrIEFudGVsbWFuIDxldGE0MjY5QGRyYXBlci5jb20+CkRh dGU6IFRodSwgMTEgU2VwIDIwMTQgMTU6Mzc6NTMgLTA0MDAKU3ViamVjdDogW1BBVENIXSBJZiBF UlJPUl9SRVBPUlRfQ09MTEVDVCBpcyBub3QgZGVmaW5lZCwgaXQgd2lsbCBhYm9ydCB0aGUKIGJ1 aWxkIGJ5IHRyeWluZyB0byBydW4gYSBTaGVsbENvbWFuZCB3aXRoIGEgLmNvbW1hbmQgb2YKIE5v bmUuCgpTaWduZWQtb2ZmLWJ5OiBFcmlrIEFudGVsbWFuIDxldGE0MjY5QGRyYXBlci5jb20+Ci0t LQogLi4uL2F1dG9idWlsZGVyL2J1aWxkc3RlcHMvU2VuZEVycm9yUmVwb3J0LnB5ICAgICAgfCAg ICAyICsrCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbGli L3B5dGhvbjIuNy9zaXRlLXBhY2thZ2VzL2F1dG9idWlsZGVyL2J1aWxkc3RlcHMvU2VuZEVycm9y UmVwb3J0LnB5IGIvbGliL3B5dGhvbjIuNy9zaXRlLXBhY2thZ2VzL2F1dG9idWlsZGVyL2J1aWxk c3RlcHMvU2VuZEVycm9yUmVwb3J0LnB5CmluZGV4IDE1OWMzM2EuLjU0NDFmMzEgMTAwNjQ0Ci0t LSBhL2xpYi9weXRob24yLjcvc2l0ZS1wYWNrYWdlcy9hdXRvYnVpbGRlci9idWlsZHN0ZXBzL1Nl bmRFcnJvclJlcG9ydC5weQorKysgYi9saWIvcHl0aG9uMi43L3NpdGUtcGFja2FnZXMvYXV0b2J1 aWxkZXIvYnVpbGRzdGVwcy9TZW5kRXJyb3JSZXBvcnQucHkKQEAgLTUwLDYgKzUwLDggQEAgY2xh c3MgU2VuZEVycm9yUmVwb3J0KFNoZWxsQ29tbWFuZCk6CiAgICAgICAgICAgICAgICAgICAgIHNl bGYuZXJyb3JyZXBvcnRzZXJ2ZXIgPSAiIgogICAgICAgICAgICAgICAgIHNlbGYuY29tbWFuZCA9 ICJpZiBbICEgLWYgfi8ub2Utc2VuZC1lcnJvciBdOyB0aGVuIGhvc3Q9YGhvc3RuYW1lYDsgZWNo byBcInlvY3RvLWF1dG9idWlsZGVyLWF1dG9nZW5lcmF0ZWQtJGhvc3RcIiA+IH4vLm9lLXNlbmQt ZXJyb3I7IGZpIDsgIgogICAgICAgICAgICAgICAgIHNlbGYuY29tbWFuZCArPSAiLiAuL29lLWlu aXQtYnVpbGQtZW52OyBpZiBbIC1kICIgKyBzZWxmLmVycm9yZGlyICsiLyR4IiArICIgXTsgdGhl biBmb3IgeCBpbiBgbHMgIiArIHNlbGYuZXJyb3JkaXIgKyIgfCBncmVwIGVycm9yX3JlcG9ydF9g OyBkbyBzZW5kLWVycm9yLXJlcG9ydCAiICsgc2VsZi5lcnJvcmRpciArIi8keCIrIHNlbGYuZXJy b3JyZXBvcnRzZXJ2ZXIgKyAiOyBkb25lOyBmaSIgCisgICAgICAgICAgICBlbHNlOgorICAgICAg ICAgICAgICAgIHNlbGYuY29tbWFuZCA9ICJlY2hvIGVudmlyb25tZW50IHZhciBFUlJPUl9SRVBP UlRfQ09MTEVDVCBub3Qgc2V0IC0gU3RlcCBpcyBub29wIgogICAgICAgICAgICAgc2VsZi5kZXNj cmlwdGlvbiA9IFsiU2VuZGluZyBlcnJvciByZXBvcnRzIl0KICAgICAgICAgU2hlbGxDb21tYW5k LnN0YXJ0KHNlbGYpCiAKLS0gCjEuNy45LjUKCg==