7018 2014-12-03 07:54:29 +0000 archiver missing tasks between do_unpack and do_patch 2020-03-25 01:44:53 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core 1.8 x86 Multiple RESOLVED FIXED Backport to 2.6.1 Medium normal 3.2 1 hongxu.jia hongxu.jia liezhi.yang meta.mr.watcher meta.watcher randy.macleod richard.purdie ross.burton sgw --- --- Don't know oldest_to_newest 47315 0 hongxu.jia 2014-12-03 07:54:29 +0000 While archiver inherited, we edit a recipe (such as gzip) to insert four tasks between do_patch and do_unpack: ... addtask test1 after do_unpack before do_patch addtask test2 after do_unpack before do_test1 addtask test3 after do_test2 before do_test1 addtask test4 after do_test2 before do_test1 ... While building the recipe, the archiver will missing these four task in do_unpack_and_patch. Because it is hardcoded to execute do_unpach and do_patch, did not consider the probable tasks between them. ... # The kernel source is ready after do_validate_branches if bb.data.inherits_class('kernel-yocto', d): bb.build.exec_func('do_unpack', d) bb.build.exec_func('do_kernel_checkout', d) bb.build.exec_func('do_validate_branches', d) else: bb.build.exec_func('do_unpack', d) # Save the original source for creating the patches if d.getVarFlag('ARCHIVER_MODE', 'diff', True) == '1': src = d.getVar('S', True).rstrip('/') src_orig = '%s.orig' % src oe.path.copytree(src, src_orig) bb.build.exec_func('do_patch', d) ... 55076 1 ross.burton 2015-10-08 15:45:52 +0000 Hongxu, I have memories of this patch but cant find it. Did this get merged or was the patch rejected? 55096 2 liezhi.yang 2015-10-09 02:32:36 +0000 (In reply to comment #1) > Hongxu, I have memories of this patch but cant find it. Did this get merged > or was the patch rejected? Hongxu is blocked by other things recently, here is his patch: http://lists.openembedded.org/pipermail/openembedded-core/2014-December/099559.html 82250 3 richard.purdie 2018-11-15 16:38:16 +0000 The patch: http://lists.openembedded.org/pipermail/openembedded-core/2014-December/099560.html but this wasn't merged for some reason 85447 4 randy.macleod 2019-10-25 15:46:07 +0000 Move to M3 since M4 is for bug fixes.