7371 2015-02-26 15:16:46 +0000 Toaster managed mode: configuration variables page allows empty inputs into database 2015-11-26 13:25:52 +0000 1 1 7 Build System, Metadata & Runtime Toaster toaster 1.8 x86 Multiple VERIFIED FIXED Medium major 1.8 M4 1 ionutx.chisanovici david.reyna alexandru.costinx.roman alexandru.damian belen.barros.pena bluelightning cristiana.voicu jessica.zhang alexandru.costinx.roman --- New (Never tested) No (bug/feature does not impact docs) oldest_to_newest 49087 0 ionutx.chisanovici 2015-02-26 15:16:46 +0000 Hi, For 1.8_M3.RC1, commit: 40d80f9e019118ac7bcd268f21e350bc154a4a63 but with git revert for cb23e3043bf5c07f111787287a321df0ece647dd, in project configuration variable page, user can add empty records into orm_projectvariable which is causing toaster to return errors. To reproduce this: 1. Create a new project 2. Click on "Edit configuration variables" 3. Add a new var name and value 4. Click on the "Add variable" button 5. Click once again the "Add variable" button (the button remains active) sqlite> select * from orm_projectvariable; id = 1 project_id = 1 name = IMAGE_INSTALL_append value = id = 2 project_id = 1 name = PACKAGE_CLASSES value = package_rpm id = 3 project_id = 1 name = MACHINE value = qemux86 id = 4 project_id = 1 name = SDKMACHINE value = x86_64 id = 5 project_id = 1 name = DISTRO value = poky id = 6 project_id = 1 name = IMAGE_FSTYPES value = ext3 jffs2 tar.bz2 id = 7 project_id = 2 name = IMAGE_INSTALL_append value = id = 8 project_id = 2 name = PACKAGE_CLASSES value = package_rpm id = 9 project_id = 2 name = MACHINE value = qemux86 id = 10 project_id = 2 name = SDKMACHINE value = x86_64 id = 11 project_id = 2 name = DISTRO value = poky id = 12 project_id = 2 name = IMAGE_FSTYPES value = ext3 jffs2 tar.bz2 sqlite> select * from orm_projectvariable; id = 1 project_id = 1 name = IMAGE_INSTALL_append value = id = 2 project_id = 1 name = PACKAGE_CLASSES value = package_rpm id = 3 project_id = 1 name = MACHINE value = qemux86 id = 4 project_id = 1 name = SDKMACHINE value = x86_64 id = 5 project_id = 1 name = DISTRO value = poky id = 6 project_id = 1 name = IMAGE_FSTYPES value = ext3 jffs2 tar.bz2 id = 7 project_id = 2 name = IMAGE_INSTALL_append value = id = 8 project_id = 2 name = PACKAGE_CLASSES value = package_rpm id = 9 project_id = 2 name = MACHINE value = qemux86 id = 10 project_id = 2 name = SDKMACHINE value = x86_64 id = 11 project_id = 2 name = DISTRO value = poky id = 12 project_id = 2 name = IMAGE_FSTYPES value = ext3 jffs2 tar.bz2 id = 13 project_id = 1 name = MACHINE value = genericx86 id = 14 project_id = 1 name = value = Cheers, Ionut C 49109 1 david.reyna 2015-02-27 04:10:33 +0000 Here are the fix details: * When you add a variable, the “Add” button does now disable itself. * After testing, I also added code to disable “Add” when the variable name is set to empty. * Finally, I added/fixed code to enforced the blocking of the variables that are managed outside this page, specifically BBLAYERS and MACHINE which are handled by the project detail page. 56806 2 alexandru.costinx.roman 2015-11-26 13:25:52 +0000 Verified.