7427 2015-03-09 09:38:31 +0000 Image manifest file lacking newline char in last line 2016-01-29 17:39:19 +0000 1 1 7 Build System, Metadata & Runtime Meta-yocto meta-yocto unspecified x86 Multiple RESOLVED FIXED Medium enhancement 2.1 M2 1 pespin.shar mariano.lopez benjamin.esquivel poky.bs.watcher poky.watcher richard.purdie --- --- No (bug/feature does not impact docs) oldest_to_newest 49286 0 2438 pespin.shar 2015-03-09 09:38:31 +0000 Created attachment 2438 Patch which fixes the issue for me I was having problems to generate automatically some information from the manifest file because a package was missing, until I discovered that it was actually the last package in the list and I noticed that that last line in that file doesn't have a newline character, which in my opinion is the usual case in most text files. So I open this bug report in order to get that fixed, and I propose a patch I did which solves the issue for me at least. I am using deb packaging system, but I guess similar patches ar needed in the same file for other packaging system too. 49300 1 pespin.shar 2015-03-09 14:42:43 +0000 Forget about the patch, I found out it breaks other code which gets the package list with "arch" parameter. Easiest solution is to implement it in image.bbclass by writing an newline at the end: python write_image_manifest () { from oe.rootfs import image_list_installed_packages with open(d.getVar('IMAGE_MANIFEST', True), 'w+') as image_manifest: image_manifest.write(image_list_installed_packages(d, 'ver')) image_manifest.write("\n") } However, I feel the way the list is generated in image_list_installed_packages and how the code that uses it is kind of bad... imho or you use same output in all lines (meaning last one has also a newline char), or you convert those to python lists already inside image_list_installed_packages, but I wouldn't pass the current format and then go splitting in all the places this function is used. What do you think about that? 49685 2 richard.purdie 2015-03-24 10:56:01 +0000 For what its worth I agree that the way the data is currently being passed around is horrible, we should use some better data structure. At this point I'll merge a patch as you propose adding the newline character and then in 1.9 we should consider rewriting the structure of the code as an enhancement/cleanup. 57252 3 richard.purdie 2015-12-14 15:59:05 +0000 To be clear about the problems here, the format parameter to image_list_installed_packages() is ugly and we shouldn't be passing around several different formats of this data. A better solution would be to have one return data format which encompasses all the types and doesn't need string splitting in the callers. Having a function called "list", a python keyword is also horrible. 57257 4 mariano.lopez 2015-12-14 20:41:08 +0000 I was checking where the image_list_installed_packages() is used and it seems it is only in OE-Core. Regarding the output it is very different based on the format, so a one size fits all solution won't work. What can be done is to return a list or dictionary to the callers and they can format the output as desired. Currently there are 5 defined formats and here is the sample output: arch: adwaita-icon-theme all alsa-conf core2-64 alsa-conf-base core2-64 alsa-plugins-pulseaudio-conf core2-64 deps: adwaita-icon-theme|hicolor-icon-theme adwaita-icon-theme|hicolor-icon-theme adwaita-icon-theme|hicolor-icon-theme adwaita-icon-theme|busybox adwaita-icon-theme|busybox alsa-plugins-pulseaudio-conf|libasound-module-conf-pulse alsa-plugins-pulseaudio-conf|libasound-module-ctl-pulse alsa-plugins-pulseaudio-conf|libasound-module-pcm-pulse file: adwaita-icon-theme /path/to/tmp/deploy/rpm/all/adwaita-icon-theme-3.18.0-r0.all.rpm all alsa-conf /path/to/tmp/deploy/rpm/core2_64/alsa-conf-1.0.29-r0.core2_64.rpm core2-64alsa-conf-base /home/mlopezva/repo/poky/bug7427/tmp/deploy/rpm/core2_64/alsa-conf-base-1.0.29-r0.core2_64.rpm core2-64 alsa-plugins-pulseaudio-conf /path/to/tmp/deploy/rpm/core2_64/alsa-plugins-pulseaudio-conf-1.0.29-r0.core2_64.rpm core2-64 ver: adwaita-icon-theme all 3.18.0 alsa-conf core2-64 1.0.29 alsa-conf-base core2-64 1.0.29 default: adwaita-icon-theme alsa-conf alsa-conf-base alsa-plugins-pulseaudio-conf 57679 5 mariano.lopez 2016-01-08 15:11:38 +0000 Sent patch for review: http://lists.openembedded.org/pipermail/openembedded-core/2016-January/115006.html 58350 6 mariano.lopez 2016-01-29 17:39:19 +0000 This has been integrated in master: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=c708411f20f8944eaabce40121b61e17d26e8a15 http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=03075f671c5425f08669f10f30330c4880c0d60a http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=6ebda8e659f678a0f4fe1e970d6f38e5e273f5f7 http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=571289df7b2b59a3f00c267824931e3efaaabc3b 2438 2015-03-09 09:38:31 +0000 2015-03-09 09:38:31 +0000 Patch which fixes the issue for me 0001-package_manager.py-Add-missing-final-newline-char-to.patch text/plain 847 pespin.shar RnJvbSBlNWU1MjAzNTlkNWYzZWFlMzdmNDI2MjBiN2MwOWQzMmFjNWM0NzY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXUgRXNwaW4gUGVkcm9sIDxwYXUuZXNwaW5AZXNzZW5zaXVt LmNvbT4KRGF0ZTogTW9uLCA5IE1hciAyMDE1IDEwOjM1OjMyICswMTAwClN1YmplY3Q6IFtQQVRD SF0gcGFja2FnZV9tYW5hZ2VyLnB5OiBBZGQgbWlzc2luZyBmaW5hbCBuZXdsaW5lIGNoYXIgdG8g c29tZQogRHBrZ1BrZ3NMaXN0Lmxpc3QoKSBvdXRwdXRzCgpTaWduZWQtb2ZmLWJ5OiBQYXUgRXNw aW4gUGVkcm9sIDxwYXUuZXNwaW5AZXNzZW5zaXVtLmNvbT4KLS0tCiBwb2t5L21ldGEvbGliL29l L3BhY2thZ2VfbWFuYWdlci5weSB8IDIgKysKIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KykKCmRpZmYgLS1naXQgYS9wb2t5L21ldGEvbGliL29lL3BhY2thZ2VfbWFuYWdlci5weSBiL3Bv a3kvbWV0YS9saWIvb2UvcGFja2FnZV9tYW5hZ2VyLnB5CmluZGV4IDFjNjQyMDUuLmU5NzZjOWIg MTAwNjQ0Ci0tLSBhL3Bva3kvbWV0YS9saWIvb2UvcGFja2FnZV9tYW5hZ2VyLnB5CisrKyBiL3Bv a3kvbWV0YS9saWIvb2UvcGFja2FnZV9tYW5hZ2VyLnB5CkBAIC00MjcsNiArNDI3LDggQEAgY2xh c3MgRHBrZ1BrZ3NMaXN0KFBrZ3NMaXN0KToKICAgICAgICAgICAgICAgICAgICAgICAgICAicmV0 dXJuZWQgJWQ6XG4lcyIgJSAoZS5jbWQsIGUucmV0dXJuY29kZSwgZS5vdXRwdXQpKQogCiAgICAg ICAgICAgICBmaWxlX291dC5jbG9zZSgpCisgICAgICAgIGVsc2U6CisgICAgICAgICAgICBvdXRw dXQgKz0gIlxuIgogCiAgICAgICAgIHJldHVybiBvdXRwdXQKIAotLSAKMS45LjEKCg==