7558 2015-04-02 12:48:37 +0000 Wrong URL in git fetcher's checkstatus method 2015-10-13 13:18:46 +0000 1 1 7 Build System, Metadata & Runtime BitBake bitbake unspecified x86 Multiple VERIFIED FIXED Medium normal 1.9 1 smoczynski.marcin richard.purdie bogdanx.a.voiculescu poky.bs.watcher poky.watcher bogdanx.a.voiculescu --- --- No (bug/feature does not impact docs) oldest_to_newest 50036 0 2464 smoczynski.marcin 2015-04-02 12:48:37 +0000 Created attachment 2464 Proposed patch Executing checkuri on a rule with git repository in SRC_URI does not report errors when working offline because wrong repository url is passed to the ls-remote command. For example "bitbake -c checkuri glibc" command executes: "git -c core.fsyncobjectfiles=0 ls-remote git://sourceware.org/git/glibc.git;branch=release/2.21/master" command in a shell subprocess to determine if url is valid. Shell subprocess executes in fact 2 commands: "git -c core.fsyncobjectfiles=0 ls-remote git://sourceware.org/git/glibc.git" and "branch=release/2.21/master" First one returns 127 or 128 depending on error but second one returns 0 because it is just env variable setup. Therefore we're not catching connection error. To reproduce: Go offline and execute bitbake -c checkuri glibc no error will be reported To fix: pass proper repository url without arguments after a semicolon. Proposed patch in an attachment. 51199 1 richard.purdie 2015-05-21 14:27:25 +0000 Thanks for the patch, http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=7310c3c925282e52b44351a5dfd7f7d882d2dcc4 55255 2 bogdanx.a.voiculescu 2015-10-13 13:18:46 +0000 Verified on master d302c98822efe2cb78a63b620aed1b94b4ed4a68 using this command with network enabled and disabled: bitbake -c checkuri m4 2464 2015-04-02 12:48:37 +0000 2015-04-02 12:48:37 +0000 Proposed patch 0001-bitbake-fetch2-fix-uri-in-git-checkstatus.patch text/plain 886 smoczynski.marcin RnJvbSBjYjUxZjkwMzFhZTRhZjMzMTE5MWMyYjI1ODA2NTQ4ZGRmMjQ2Y2ZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/TWFyY2luPTIwU21vY3p5PUM1PTg0c2tpPz0g PG1hcmNpbi5zbW9jenluc2tpQGVuaWdtYS5jb20ucGw+CkRhdGU6IFRodSwgMiBBcHIgMjAxNSAx NDoyNDo1MSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGJpdGJha2U6IGZldGNoMjogZml4IHVyaSBp biBnaXQgY2hlY2tzdGF0dXMKCi0tLQogYml0YmFrZS9saWIvYmIvZmV0Y2gyL2dpdC5weSB8ICAg IDMgKy0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDIgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvYml0YmFrZS9saWIvYmIvZmV0Y2gyL2dpdC5weSBiL2JpdGJha2UvbGliL2Ji L2ZldGNoMi9naXQucHkKaW5kZXggNDRmYzI3MS4uNTBjZTk1NSAxMDA2NDQKLS0tIGEvYml0YmFr ZS9saWIvYmIvZmV0Y2gyL2dpdC5weQorKysgYi9iaXRiYWtlL2xpYi9iYi9mZXRjaDIvZ2l0LnB5 CkBAIC0zOTUsOSArMzk1LDggQEAgY2xhc3MgR2l0KEZldGNoTWV0aG9kKToKICAgICAgICAgcmV0 dXJuIHVkLnJldmlzaW9uc1tuYW1lXQogCiAgICAgZGVmIGNoZWNrc3RhdHVzKHNlbGYsIHVkLCBk KToKLSAgICAgICAgZmV0Y2hjbWQgPSAiJXMgbHMtcmVtb3RlICVzIiAlICh1ZC5iYXNlY21kLCB1 ZC51cmwpCiAgICAgICAgIHRyeToKLSAgICAgICAgICAgIHJ1bmZldGNoY21kKGZldGNoY21kLCBk LCBxdWlldD1UcnVlKQorICAgICAgICAgICAgc2VsZi5fbHNyZW1vdGUodWQsIGQsICIiKQogICAg ICAgICAgICAgcmV0dXJuIFRydWUKICAgICAgICAgZXhjZXB0IEZldGNoRXJyb3I6CiAgICAgICAg ICAgICByZXR1cm4gRmFsc2UKLS0gCjEuNy45LjUKCg==