7627 2015-04-17 22:24:28 +0000 Kernel checkout requires master branch 2015-04-28 19:12:38 +0000 1 1 7 Build System, Metadata & Runtime OE-Core kernel unspecified x86 Multiple RESOLVED FIXED Undecided normal --- 1 steve bruce.ashfield bruce.ashfield tom.zanussi --- --- No (bug/feature does not impact docs) oldest_to_newest 50396 0 2480 steve 2015-04-17 22:24:28 +0000 Created attachment 2480 aforementioned patch http://cgit.openembedded.org/openembedded-core/commit/?id=2ffa3f8be6996877cd552ff22260de35c19c413d introduced a bug where a branch named "master" is required for a kernel checkout to succeed (while usually true, this isn't necessarily the case in all repositories). The logic seems to have been inverted. Attached is a patch that should address the situation. 50397 1 bruce.ashfield 2015-04-18 01:15:01 +0000 This is already fixed in master (as mentioned on the mailing list). The logic was inverted, but we'll now only fall back to master if the machine branch doesn't exist. 50398 2 bruce.ashfield 2015-04-18 01:17:06 +0000 In particular, I'm not all that concerned about working with repositories with no master. If we handled every single repository variant, the complexity becomes to much. Having a well known (and sane) fallback of master is appropriate in nearly every case. 50400 3 steve 2015-04-18 14:42:20 +0000 Ah. I didn't see af691920c0e289fd0eb13d94cad03c799375af21 as I was only looking on the dizzy branch. Is this a change that can make it to 1.7.2? Just leaving it be the "master" branch sounds good to me. 50401 4 bruce.ashfield 2015-04-19 03:59:53 +0000 I'll post the patch for a backport to stable. Thanks for working through this, and sorry for issues it may be causing for your builds! (In reply to comment #3) > Ah. I didn't see af691920c0e289fd0eb13d94cad03c799375af21 as I was only > looking on the dizzy branch. Is this a change that can make it to 1.7.2? > > Just leaving it be the "master" branch sounds good to me. 50510 5 bruce.ashfield 2015-04-24 20:03:36 +0000 send the patch to the list. 50580 6 bruce.ashfield 2015-04-28 19:12:38 +0000 Patch posted for backport. 2480 2015-04-17 22:24:28 +0000 2015-04-17 22:24:28 +0000 aforementioned patch 0001-Fixes-kernel-checkout-when-master-branch-is-missing.patch text/plain 1188 steve RnJvbSBmNmFhZDlhYWY5YWYyZjBmNWQ3MmE0ZTE4N2QwNjNlYzA4N2Q0NGE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGV2ZSBQb21lcm95IDxzdGV2ZXBAdGhlbGV2ZWx1cC5jb20+ CkRhdGU6IEZyaSwgMTcgQXByIDIwMTUgMTg6MTk6MzcgLTA0MDAKU3ViamVjdDogW1BBVENIXSBG aXhlcyBrZXJuZWwgY2hlY2tvdXQgd2hlbiAibWFzdGVyIiBicmFuY2ggaXMgbWlzc2luZwoKKiBG aXhlcyBpbnZlcnRlZCBicmFuY2ggY2hlY2tvdXQgbG9naWMuCiogTm90IGFsbCByZXBvc2l0b3Jp ZXMgaGF2ZSBhICJtYXN0ZXIiIGJyYW5jaCwgc28gdGhpcyByZXRyaWV2ZXMgdGhlIEhFQUQKICBy ZWZlcmVuY2UgYW5kIHVzZXMgdGhhdCBhcyBhIGZhbGxiYWNrLgotLS0KIG1ldGEvY2xhc3Nlcy9r ZXJuZWwteW9jdG8uYmJjbGFzcyB8ICAgIDUgKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbWV0YS9jbGFzc2VzL2tlcm5l bC15b2N0by5iYmNsYXNzIGIvbWV0YS9jbGFzc2VzL2tlcm5lbC15b2N0by5iYmNsYXNzCmluZGV4 IGY0MmE1YzIuLmEzMzI3NzQgMTAwNjQ0Ci0tLSBhL21ldGEvY2xhc3Nlcy9rZXJuZWwteW9jdG8u YmJjbGFzcworKysgYi9tZXRhL2NsYXNzZXMva2VybmVsLXlvY3RvLmJiY2xhc3MKQEAgLTIxMSw4 ICsyMTEsOSBAQCBkb19rZXJuZWxfY2hlY2tvdXQoKSB7CiAJIyBDcmVhdGUgYSB3b3JraW5nIHRy ZWUgY29weSBvZiB0aGUga2VybmVsIGJ5IGNoZWNraW5nIG91dCBhIGJyYW5jaAogCW1hY2hpbmVf YnJhbmNoPSIke0AgZ2V0X21hY2hpbmVfYnJhbmNoKGQsICIke0tCUkFOQ0h9IiApfSIKIAlnaXQg c2hvdy1yZWYgLS1xdWlldCAtLXZlcmlmeSAtLSAicmVmcy9oZWFkcy8ke21hY2hpbmVfYnJhbmNo fSIKLQlpZiBbICQ/IC1lcSAwIF07IHRoZW4KLQkJbWFjaGluZV9icmFuY2g9Im1hc3RlciIKKwlp ZiBbICQ/IC1uZSAwIF07IHRoZW4KKwkJIyBVc3VhbGx5IHRoaXMgaXMgdGhlICJtYXN0ZXIiIGJy YW5jaCwgYnV0IG5vdCBhbHdheXMuCisJCW1hY2hpbmVfYnJhbmNoPSIkKGdpdCBzeW1ib2xpYy1y ZWYgSEVBRCB8IHNlZCAncyUuKi9cKFteL10qXCkkJVwxJScpIgogCWZpCiAKIAkjIGNoZWNrb3V0 IGFuZCBjbG9iYmVyIGFueSB1bmltcG9ydGFudCBmaWxlcwotLSAKMS43LjkuNQoK