7630 2015-04-20 12:32:34 +0000 Provide some hint for the "textrel" QA issue 2015-04-27 17:09:41 +0000 1 1 9 Documentation Reference handbook unspecified x86 Multiple RESOLVED FIXED 27 April 2015: RESOLVED Undecided enhancement 1.9 M1 1 lpapp srifenbark bluelightning poky.doc.watcher poky.watcher srifenbark --- --- Done (doc changes complete) oldest_to_newest 50409 0 lpapp 2015-04-20 12:32:34 +0000 The documentation (*) writes: ELF binary '<file>' has relocations in .text [textrel] ¶ The specified ELF binary contains relocations in its .text sections. This situation can result in a performance impact at runtime. A hint could be added that the fix is likely to assign -fPIC/-fpic to gcc. This could spare some investigation time for the casual reader. * http://www.yoctoproject.org/docs/current/ref-manual/ref-manual.html#qa-issue-textrel 50410 1 bluelightning 2015-04-20 12:35:04 +0000 I agree we should extend this entry as currently it is a bit sparse. It could also be worth linking to this page for further information: http://www.akkadia.org/drepper/textrelocs.html 50416 2 srifenbark 2015-04-20 14:42:40 +0000 Hi, I have made a couple changes in the ref-manual. This bit about runtime performance issues appears in two different places. Please look at the following sections and give me your feedback: * http://www.yoctoproject.org/docs/1.9/ref-manual/ref-manual.html#ref-classes-insane - see the "textrel" bullet item. * http://www.yoctoproject.org/docs/1.9/ref-manual/ref-manual.html#qa-issue-textrel Thanks, Scott 50418 3 bluelightning 2015-04-20 14:56:09 +0000 "If you do experience performance issues.." isn't really correct, it's a suggested resolution to the general issue. Also "assign -fPIC to gcc" isn't really something the user can action. 50420 4 srifenbark 2015-04-20 15:14:48 +0000 Paul, I need more information to reword this. How does the developer determine if they are having performance issues due to text relocation? Are they able to isolate slowdowns to this particular issue? Would it be better to just say "For runtime performance issues, ..."? Also, if the user cannot assign "-fPIC to gcc" as a workaround, how does this workaround get applied? Is there a workaround? Thanks, Scott 50421 5 bluelightning 2015-04-20 15:23:04 +0000 That's just it - -fPIC isn't a workaround, it's the proper way to fix it. My issue was mainly in the way you're stating it - it's not that the user should go and check if there are performance issues, they should just fix it and then both the warning and any potential performance issues go away. The problem with "assign -fPIC to gcc" is it doesn't sufficiently explain what to do. Rather than having this as a "Tip" box I would suggest simply having the following sentence at the end of the first paragraph: 'Typically the way to solve this is by adding -fPIC to the compiler command line options, for example where the software you are building reads CFLAGS from the environment adding the following to the recipe should fix it: CFLAGS_append = " -fPIC " ' 50423 6 srifenbark 2015-04-20 15:45:27 +0000 Paul, Check out the latest at http://www.yoctoproject.org/docs/1.9/ref-manual/ref-manual.html#qa-issue-textrel and let me know. I did some rewriting on your original text. Scott 50514 7 bluelightning 2015-04-27 10:15:14 +0000 Looks good to me. 50525 8 srifenbark 2015-04-27 15:38:54 +0000 Thanks Paul... I will leave this in IN PROGRESS REVIEW until I either hear from Laszlo or a reasonable time passes without further comments. Scott 50526 9 lpapp 2015-04-27 15:44:12 +0000 Looks good, thank you for your help! I would personally suggest a minor improvement to the text, but it is not strictly necessary: "Typically, the way to solve this performance issue is to add "-fPIC" *or "-fpic"* to the compiler command-line option" -fpic might be preferred on embedded systems with minimal requirements, so it is good to be aware of, even though -fPIC is much more common. 50538 10 srifenbark 2015-04-27 17:09:41 +0000 Laszlo... .thanks for the additional suggestion. I have added that to the text. I am marking the bug RESOLVED and setting the doc flag to "Done." Change can be viewed at http://www.yoctoproject.org/docs/1.9/ref-manual/ref-manual.html#qa-issue-textrel Thanks, Scott