<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>7633</bug_id>
          
          <creation_ts>2015-04-20 14:51:59 +0000</creation_ts>
          <short_desc>Parser does not error out on unclosed function</short_desc>
          <delta_ts>2015-06-25 10:43:54 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>BitBake</product>
          <component>bitbake</component>
          <version>1.7</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.9 M1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Paul Eggleton">bluelightning</reporter>
          <assigned_to name="Richard Purdie">richard.purdie</assigned_to>
          <cc>alexandru.c.georgescu</cc>
    
    <cc>cristina-danielax.agurida</cc>
    
    <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
          
          <qa_contact name="Cristina Agurida">cristina-danielax.agurida</qa_contact>
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>50417</commentid>
    <comment_count>0</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2015-04-20 14:51:59 +0000</bug_when>
    <thetext>If you have a recipe with an unclosed function before EOF then you&apos;d expect an error, but you don&apos;t get one - here&apos;s a trivial reproducer:

-------- snip ---------
LICENSE = &quot;CLOSED&quot;
SRC_URI = &quot;&quot;

do_install() {
        echo &quot;hello&quot;

inherit autotools gettext
-------- snip ---------

This recipe builds without error. It seems the do_install function isn&apos;t even used, the default implementation is used instead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>50952</commentid>
    <comment_count>1</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2015-05-13 09:21:54 +0000</bug_when>
    <thetext>A related issue I just discovered - apparently if your closing } is not the first character on the line it also triggers the same behaviour (the function definition is completely ignored).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>51090</commentid>
    <comment_count>2</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2015-05-18 16:35:02 +0000</bug_when>
    <thetext>http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=fd731142e9e6d31c6735228c67ae0e87b6d4d239
along with a test:
http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=2a56445b9bb46357187425def7adc9ddc240b60a
http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=bc162d21dd148252efcf3ed771e04c791ef4d869</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>51921</commentid>
    <comment_count>3</comment_count>
    <who name="Cristina Agurida">cristina-danielax.agurida</who>
    <bug_when>2015-06-25 10:43:54 +0000</bug_when>
    <thetext>Verified on master: 8ef99a00dc75c6eed87aa1bc1528614a2a27eddf</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>