7740 2015-05-12 11:44:45 +0000 Explain better what Toaster does in the layer checkout directory 2015-09-10 08:46:51 +0000 1 1 7 Build System, Metadata & Runtime Toaster toaster 1.8 x86 Multiple VERIFIED FIXED Medium enhancement 1.9 M3 1 belen.barros.pena belen.barros.pena alexandru.damian belen.barros.pena bluelightning bogdanx.a.voiculescu brian.avery cristiana.voicu jessica.zhang randy.e.witt srifenbark alexandru.costinx.roman --- --- No (bug/feature does not impact docs) oldest_to_newest 50913 0 belen.barros.pena 2015-05-12 11:44:45 +0000 Currently, the Toaster set up script asks users to define the layer checkout directory using this text: -- Validation: The checkout directory must be set Toaster needs to know in which directory it should check out the layers that will be needed for your builds. Toaster suggests "/home/yocto". If you select this directory, a layer like "meta-intel" will end up in "/home/yocto/meta-intel". Press enter to select "home/yocto" or type the full path to a different directory (must be a parent of current checkout directory): We should make a bit more clear that the checkout directory should be a parent of the directory where you have cloned the sources you are using to run Toaster. Maybe we could say something like: -- Validation: Please set the layers checkout directory This is the directory where Toaster will checkout the source code of the layers you will build. To keep clean the clone you are using to run Toaster, the layers checkout directory should be a parent of such clone directory. Toaster suggests you use "home/yocto" as your layers checkout directory. Press enter to select "home/yocto" or type the full path to a different directory (remember, it must be a parent of the directory where you cloned the sources you are using to run Toaster): 50914 1 belen.barros.pena 2015-05-12 11:45:42 +0000 Forgot to say: Randy, Scott, if you have any suggestions on how to improve on what I just wrote, please comment. Thanks! 50915 2 srifenbark 2015-05-12 12:25:47 +0000 (In reply to comment #0) > Currently, the Toaster set up script asks users to define the layer checkout > directory using this text: > > -- Validation: The checkout directory must be set > Toaster needs to know in which directory it should check out the layers that > will be needed for your builds. > Toaster suggests "/home/yocto". If you select this directory, a layer like > "meta-intel" will end up in "/home/yocto/meta-intel". > Press enter to select "home/yocto" or type the full path to a different > directory (must be a parent of current checkout directory): > > We should make a bit more clear that the checkout directory should be a > parent of the directory where you have cloned the sources you are using to > run Toaster. Maybe we could say something like: > > -- Validation: Please set the layers checkout directory I would end the above sentence with a period. > > This is the directory where Toaster will checkout the source code of the > layers you will build. You might consider this - "This is the directory Toaster uses to checkout the source code of the layers you will build." > > To keep clean the clone you are using to run Toaster, the layers checkout > directory should be a parent of such clone directory. You might consider this - "To keep the clone you are using to run Toaster clean, the layers directory should be a parent of the clone directory." > > Toaster suggests you use "home/yocto" as your layers checkout directory. > Press enter to select "home/yocto" or type the full path to a different > directory (remember, it must be a parent of the directory where you cloned > the sources you are using to run Toaster): You might consider this - "Toaster suggests you use "home/yocto" as your layers checkout directory. Press enter to select "home/yocto" or type the full path to a different directory. If you provide your own directory, it must be a parent of the cloned directory for the sources you are using to run Toaster." 50953 3 belen.barros.pena 2015-05-13 09:38:38 +0000 The confusion was this one: "it wasn’t clear that toaster wouldn’t make changes to the existing layers already in my “src” directory and would instead create a subdirectory and do its own checkouts." 52227 4 brian.avery 2015-07-08 22:34:00 +0000 What is forcing the requirement that it be the parent of the current directory? For example, here is my directory structure when building stuff w/ Yocto as I always prefer shadow builds to in-place builds: ~/src/yocto-poky/master/poky/GIT_CHECKOUT ~/src/yocto-poky/fido/poky/GIT_CHECKOUT ~/src/yocto-layers/master ~/src/yocto-layers/fido ~/src/yocto-builds/toaster-master ~/src/yocto-builds/toaster-fido ~/src/yocto-builds/arm-fido ~/src/yocto-builds/qemu-fido My preference would probably be to put the layers toaster is checking out in either ~/src/yocto-layers/toaster or ~/src/yocto-builds/toaster-master/layerdir The first is not a parent, the second choice would be a child. In either case, it seems odd to limit the destination directory for a git checkout assuming it is 1) accessible 2) not already a git tree. --- For reference, by hand I start builds as : ~/src/yocto-builds/arm-fido$>../../yocto-poky/master/poky/oe-init-build-env cd build bitbake core-image-minimal 53315 5 belen.barros.pena 2015-08-21 10:41:01 +0000 (In reply to comment #4) > What is forcing the requirement that it be the parent of the current > directory? We have an enhancement open to remove this requirement (bug 7742), currently unassigned and set to 2.1 Until we get that done, I will update the text in the Toaster setup script to improve clarity. 53320 6 belen.barros.pena 2015-08-21 12:54:15 +0000 Patch submitted for review https://lists.yoctoproject.org/pipermail/toaster/2015-August/002596.html 53826 7 belen.barros.pena 2015-09-08 09:10:49 +0000 merged to master http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=ccc1d9ac0c7a0e1768fdfc043da106d144029f3c 53905 8 alexandru.costinx.roman 2015-09-10 08:46:35 +0000 Verified on master: d4585fa23d56a58c583ee33db067a23177a936b1 53906 9 alexandru.costinx.roman 2015-09-10 08:46:51 +0000 Verified on master: d4585fa23d56a58c583ee33db067a23177a936b1