<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>7813</bug_id>
          
          <creation_ts>2015-05-28 04:43:45 +0000</creation_ts>
          <short_desc>Whitespace problem with externalsrc lock</short_desc>
          <delta_ts>2016-01-22 06:43:32 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>devtools / tool chain</component>
          <version>1.7.1</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.9 M1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ola Nilsson">ola.x.nilsson</reporter>
          <assigned_to name="Paul Eggleton">bluelightning</assigned_to>
          <cc>bogdanx.a.voiculescu</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
          
          <qa_contact name="Bogdan Alexandru Voiculescu">bogdanx.a.voiculescu</qa_contact>
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>51316</commentid>
    <comment_count>0</comment_count>
    <who name="Ola Nilsson">ola.x.nilsson</who>
    <bug_when>2015-05-28 04:43:45 +0000</bug_when>
    <thetext>The line 

d.appendVarFlag(task, &quot;lockfiles&quot;, &quot;${S}/singletask.lock&quot;)

should be 

d.appendVarFlag(task, &quot;lockfiles&quot;, &quot; ${S}/singletask.lock&quot;)

to avoid problems when a task already have a file listed in lockfiles.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>51317</commentid>
    <comment_count>1</comment_count>
    <who name="Ola Nilsson">ola.x.nilsson</who>
    <bug_when>2015-05-28 04:56:54 +0000</bug_when>
    <thetext>So if a task already have

do_foo[lockfiles] = &quot;${SOMEDIR}/foo.lock&quot;

externalsrc will change the lockfiles varflag to

&quot;${SOMEDIR}/foo.lock${S}/singletask.lock&quot;

When a tack using this lockfile has run and the lockfile has been removed it still leaves &quot;${SOMEDIR}/foo.lock${S}&quot; behind.  This will cause the foo task in a recipe not usein gexternalsrc to stall waiting for &quot;${SOMEDIR}/foo.lock&quot; - which is now actually a directory.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>51318</commentid>
    <comment_count>2</comment_count>
    <who name="Ola Nilsson">ola.x.nilsson</who>
    <bug_when>2015-05-28 05:11:20 +0000</bug_when>
    <thetext>Trying to fix this on master I found it was already fixed in 7b73473bc9d19331a103cf4958059d3ceb84b486.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>51320</commentid>
    <comment_count>3</comment_count>
    <who name="Ola Nilsson">ola.x.nilsson</who>
    <bug_when>2015-05-28 11:29:11 +0000</bug_when>
    <thetext>I was wrong, it was not fixed.  Sorry about that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>51783</commentid>
    <comment_count>4</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2015-06-18 11:03:12 +0000</bug_when>
    <thetext>Fix merged to master:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=0899d9af1da320a857c4dd65db279b0173ad803a

This is probably a candidate for fido as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>58117</commentid>
    <comment_count>5</comment_count>
    <who name="Bogdan Alexandru Voiculescu">bogdanx.a.voiculescu</who>
    <bug_when>2016-01-22 06:43:32 +0000</bug_when>
    <thetext>Verified on jethro: 8c8c4ede3ff5ac8ca739020d9efed91159acccc1</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>