<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>8055</bug_id>
          
          <creation_ts>2015-07-27 15:17:08 +0000</creation_ts>
          <short_desc>Failures in INCOMPATIBLE_LICENSE</short_desc>
          <delta_ts>2015-10-01 13:57:09 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>1.7.3</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>High</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.9 M2</target_milestone>
          <dependson>8080</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Beth Flanagan">elizabeth.flanagan</reporter>
          <assigned_to name="Beth Flanagan">elizabeth.flanagan</assigned_to>
          <cc>alexandru.c.georgescu</cc>
    
    <cc>bluelightning</cc>
    
    <cc>elizabeth.flanagan</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
          
          <qa_contact name="Daniel Istrate">daniel.alexandrux.istrate</qa_contact>
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>52630</commentid>
    <comment_count>0</comment_count>
    <who name="Beth Flanagan">elizabeth.flanagan</who>
    <bug_when>2015-07-27 15:17:08 +0000</bug_when>
    <thetext>Example: core-image-full-cmdline with INCOMPATIBLE_LICENSE = &quot;GPLv3&quot;

gnutls-bin which is GPLv3 is added to the image. This shouldn&apos;t happen and doesn&apos;t in master. My guess is that there is a patch to the package.bbclass logic that should be backported to fix this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>52726</commentid>
    <comment_count>1</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2015-07-30 14:44:25 +0000</bug_when>
    <thetext>Beth, could you also please add an oe-selftest test as part of this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>52728</commentid>
    <comment_count>2</comment_count>
    <who name="Beth Flanagan">elizabeth.flanagan</who>
    <bug_when>2015-07-30 15:38:23 +0000</bug_when>
    <thetext>So, a few things on this.

1. base.py:

We check to see if pn is in the WHITELISTs. Why we&apos;re seeing these is because in default-distrovars.inc we have:

WHITELIST_GPL-3.0 ?= &quot;less&quot;
LGPLv2_WHITELIST_GPL-3.0 ?= &quot;libassuan gnutls libtasn1 libidn&quot;

We should probably override these on a non-GPLv3 autobuilder build.

So those packages are getting added to the system and we should test that they shouldn&apos;t be.

2. incompatible_license in license.bbclass is parsing bitor licenses wrong.


Example. We shouldn&apos;t need to whitelist &apos;less&apos;:

LICENSE = &quot;GPLv3+ | BSD-2-Clause&quot;

However incompatible_license should give us BSD, but it doesn&apos;t seem to be.

So, the original bug here is somewhat a false positive, BUT, we still have some somewhat minor issue in license we should be looking at.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>52731</commentid>
    <comment_count>3</comment_count>
    <who name="Beth Flanagan">elizabeth.flanagan</who>
    <bug_when>2015-07-30 17:22:08 +0000</bug_when>
    <thetext>Actually, correction. 

We check to see if pn is in the WHITELISTs. Why we&apos;re seeing these is because in default-distrovars.inc we have:

WHITELIST_GPL-3.0 ?= &quot;less&quot;
LGPLv2_WHITELIST_GPL-3.0 ?= &quot;libassuan gnutls libtasn1 libidn&quot;

This is perfectly correct behaviour. HOWEVER, we need to warn people about this in the logs and make it clear what is happening.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>52733</commentid>
    <comment_count>4</comment_count>
    <who name="Beth Flanagan">elizabeth.flanagan</who>
    <bug_when>2015-07-30 17:27:32 +0000</bug_when>
    <thetext>Actually, correction. 

We check to see if pn is in the WHITELISTs. Why we&apos;re seeing these is because in default-distrovars.inc we have:

WHITELIST_GPL-3.0 ?= &quot;less&quot;
LGPLv2_WHITELIST_GPL-3.0 ?= &quot;libassuan gnutls libtasn1 libidn&quot;

This is perfectly correct behaviour. HOWEVER, we need to warn people about this in the logs and make it clear what is happening.

I&apos;m splitting out the issue with incompatible_license returning the wrong license and making this bug depend on it since this is actually two issues.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>52794</commentid>
    <comment_count>5</comment_count>
    <who name="Beth Flanagan">elizabeth.flanagan</who>
    <bug_when>2015-08-03 18:05:19 +0000</bug_when>
    <thetext>http://permalink.gmane.org/gmane.comp.handhelds.openembedded.core/67023</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>52855</commentid>
    <comment_count>6</comment_count>
    <who name="Beth Flanagan">elizabeth.flanagan</who>
    <bug_when>2015-08-06 12:56:20 +0000</bug_when>
    <thetext>http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=5c76072804bfb1c7ea9f62b99d91ac6d76118ee4</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>54876</commentid>
    <comment_count>7</comment_count>
    <who name="Daniel Istrate">daniel.alexandrux.istrate</who>
    <bug_when>2015-10-01 13:57:09 +0000</bug_when>
    <thetext>Verified on master: 979de7703cf3e468aa2923da1445138e1c93d234

Steps to verify:
1. Add to local.conf --&gt; INCOMPATIBLE_LICENSE = &quot;GPLv3&quot;
2. bitbake -e core-image-full-cmdline | grep LGPLv2_WHITELIST_GPL-3.0= --&gt; LGPLv2_WHITELIST_GPL-3.0=&quot;libassuan gnutls libtasn1 libidn&quot;
   bitbake -e core-image-full-cmdline | egrep ^WHITELIST_GPL-3.0 --&gt; WHITELIST_GPL-3.0=&quot;less&quot;

3. bitbake core-image-full-cmdline

[daniel@fedora-ws poky-build-M3]$ bitbake core-image-full-cmdline
NOTE: INCLUDING libidn as buildable despite INCOMPATIBLE_LICENSE because it has been whitelisted      | ETA:  00:00:11
NOTE: INCLUDING libidn as buildable despite INCOMPATIBLE_LICENSE because it has been whitelisted
NOTE: INCLUDING less as buildable despite INCOMPATIBLE_LICENSE because it has been whitelisted        | ETA:  00:00:10
NOTE: INCLUDING libassuan as buildable despite INCOMPATIBLE_LICENSE because it has been whitelisted   | ETA:  00:00:01
NOTE: INCLUDING gnutls as buildable despite INCOMPATIBLE_LICENSE because it has been whitelisted      | ETA:  00:00:01
NOTE: INCLUDING libtasn1 as buildable despite INCOMPATIBLE_LICENSE because it has been whitelisted
Parsing recipes: 100% |###############################################################################| Time: 00:00:14
Parsing of 898 .bb files complete (0 cached, 898 parsed). 1328 targets, 90 skipped, 0 masked, 0 errors.
NOTE: Resolving any missing task queue dependencies

Build Configuration:
BB_VERSION        = &quot;1.27.1&quot;
BUILD_SYS         = &quot;x86_64-linux&quot;
NATIVELSBSTRING   = &quot;Fedora-21&quot;
TARGET_SYS        = &quot;i586-poky-linux&quot;
MACHINE           = &quot;qemux86&quot;
DISTRO            = &quot;poky&quot;
DISTRO_VERSION    = &quot;1.8+snapshot-20151001&quot;
TUNE_FEATURES     = &quot;m32 i586&quot;
TARGET_FPU        = &quot;&quot;
meta              
meta-yocto        
meta-yocto-bsp    = &quot;master:979de7703cf3e468aa2923da1445138e1c93d234&quot;

NOTE: Preparing RunQueue
NOTE: Executing SetScene Tasks
NOTE: Executing RunQueue Tasks
WARNING: QA Issue: gcc-runtime-dbg has an incompatible license. Excluding from packaging. [incompatible-license]
WARNING: QA Issue: libgomp has an incompatible license. Excluding from packaging. [incompatible-license]
WARNING: QA Issue: libgomp-dev has an incompatible license. Excluding from packaging. [incompatible-license]
WARNING: QA Issue: libgomp-staticdev has an incompatible license. Excluding from packaging. [incompatible-license]
NOTE: Tasks Summary: Attempted 2791 tasks of which 1207 didn&apos;t need to be rerun and all succeeded.

Summary: There were 4 WARNING messages shown.
[daniel@fedora-ws poky-build-M3]

It builds successfully and whitelists only the mentioned packages in step 2.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>