8087 2015-08-02 02:32:41 +0000 Bug in resolv patch 2017-07-31 17:01:11 +0000 1 1 7 Build System, Metadata & Runtime OE-Core devtools / tool chain unspecified x86 Multiple RESOLVED FIXED Medium normal 2.4 1 honey raj.khem alexandru.c.georgescu meta.mr.watcher meta.watcher raj.khem rongqing.li ross.burton --- --- No (bug/feature does not impact docs) oldest_to_newest 52762 0 honey 2015-08-02 02:32:41 +0000 The patch here: http://cgit.openembedded.org/openembedded/plain/recipes/glibc/files/glibc-2.5-local-dynamic-resolvconf.patch contains the bug described here: https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1432378 Perhaps worth looking into removing it in oe. Thanks 53065 1 rongqing.li 2015-08-13 02:16:48 +0000 Joshua Rogers: I see you suggest a fix for this patch, to replace __res_vinit() with res_query() , does it merged into ubuntu, or acceptable? 53067 2 2663 honey 2015-08-13 04:32:01 +0000 Created attachment 2663 Bug fix 53068 3 honey 2015-08-13 04:33:11 +0000 Hi, My fixis to, inside the res_init() function, replace the call to __res_vinit with __res_maybe_init, while setting something that ensures that __res_maybe_init will always init. As it is, res_init() is only called in two places within the eglibc code. Once in a memory leak test, http://www.eglibc.org/cgi-bin/viewvc.cgi/trunk/libc/resolv/tst-leaks2.c?annotate=24942#l31 and in the local_hostname_function, http://www.eglibc.org/cgi-bin/viewvc.cgi/trunk/libc/resolv/res_data.c?annotate=23297#l311 Other than that, res_init is a dead function, other than at the user-level. The manual says to use res_init(), and not __res_maybe_init()[which I assume wouldn't work at user-level anyways], making it a problem. I also have just now noticed that the mtime is not set unless (resp->options & RES_INIT) is true, so I've added the appropriate code to res_libc.c too. res_init() in res_data.c file is only used if _LIBC is not defined. But I added a fix for that too. Funnily enough, in res_libc.c's res_init() function, it does this: atomicinclock (lock); /* Request all threads to re-initialize their resolver states, resolv.conf might have changed. */ atomicinc (__res_initstamp); atomicincunlock (lock); however that would only do something, if __res_maybe_init was called, and (resp->options & RES_INIT) was true. So really, there's 2 bugs in 1. Anyways, let me know what you think of the patch. If you think it is OK, I'll submit to to Ubuntu/Debian too. Noting however, that eglibc is EOL'd, and Ubuntu has stopped using it in 15.04. It is still being used in 14.04.1 LTS, which is set to EOL April 2019. Likewise, Ubuntu 12.04.5 is set to EOL in April 2017, and it uses it too. Thanks, I've attached my suggestion patch. 68417 4 raj.khem 2016-11-17 17:11:31 +0000 Do you still see this bug with glibc 2.24 ? eglibc is dead now. 68646 5 raj.khem 2016-11-28 19:52:41 +0000 I think I am in favor of removing this patch. 69936 6 ross.burton 2017-01-19 15:54:42 +0000 Update: we still have this in glibc 2.5. Khem, can you look at it again and either upstream or remove it? 73328 7 sjolley.yp.pm 2017-05-18 15:16:58 +0000 See Ross' question 74336 8 raj.khem 2017-06-19 17:14:46 +0000 so far it seems we still need it. 74526 9 sjolley.yp.pm 2017-06-23 19:31:05 +0000 It appears the question has been answered. 74795 10 raj.khem 2017-07-06 05:15:42 +0000 upcoming glibc 2.26 has reworked resolv code a bit and specifically addressed this issue https://sourceware.org/bugzilla/show_bug.cgi?id=984 which was long standing in glibc. We will have glibc 2.26 in 2.4 release. 75507 11 raj.khem 2017-07-31 17:01:11 +0000 glibc 2.26 rc has landed in master 2663 2015-08-13 04:32:01 +0000 2015-08-13 04:32:01 +0000 Bug fix res.patch text/plain 2517 honey ZGlmZiAtLWdpdCBhL3Jlc29sdi9yZXNfZGF0YS5jIGIvcmVzb2x2L3Jlc19kYXRhLmMKaW5kZXgg ODFjOWFlNS4uZjU1Y2FkNCAxMDA2NDQKLS0tIGEvcmVzb2x2L3Jlc19kYXRhLmMKKysrIGIvcmVz b2x2L3Jlc19kYXRhLmMKQEAgLTEyNiw3ICsxMjYsMzIgQEAgcmVzX2luaXQodm9pZCkgewogCWlm ICghX3Jlcy5pZCkKIAkJX3Jlcy5pZCA9IHJlc19yYW5kb21pZCgpOwogCi0JcmV0dXJuIChfX3Jl c192aW5pdCgmX3JlcywgMSkpOworCS8qCisJICogU2luY2UgX19yZXNfbWF5YmVfaW5pdCgpIGlz IHVzZWQgZm9yIGludGVybmFsIGdsaWJjIGZ1bmN0aW9ucywgYW5kCisJICogd2lsbCBjYWxsIF9f cmVzX3Zpbml0KCkgaWYgdGhlIGxhc3QgbW9kaWZpY2F0aW9uIGRhdGUgb2Ygb3VyCisJICogaG9z dGZpbGUocykgaXMgbm90IHNldCBvciBkaWZmZXJzIGZyb20gdGhlIHByZXZpb3VzIGNhbGwsIGFu ZAorCSAqIF9fcmVzX3Zpbml0KCkgaXRzZWxmIGRvZXMgbm90IHNldCB0aGUgbW9kaWZpY2F0aW9u IGRhdGUsIHdlCisJICogc2hvdWxkbid0IHVzZSBfX3Jlc192aW5pdCgpIGZvciByZXNfaW5pdCgp LCBhcyB0aGUgZmlyc3QgY2FsbCB0bworCSAqIF9fcmVzX21heWJlX2luaXQoKSB3aWxsIGNhbGwg X19yZXNfdmluaXQoKSwgdGh1cyBvdmVyd3JpdGluZyBjaGFuZ2VzCisJICogbWFkZSBhZnRlciB0 aGUgZmlyc3QgcmVzX2luaXQoKSBjYWxsLCBhbmQgYmVmb3JlIHRoZSBmaXJzdCBmdW5jdGlvbgor CSAqIHRoYXQgY2FsbHMgX19yZXNfbWF5YmVfaW5pdCgpIChlLmcuIHJlc19xdWVyeS4pCisJICoK KwkgKiBJbnN0ZWFkLCB3ZSBzaG91bGQgY2FsbCBfX3Jlc19tYXliZV9pbml0KCkgaW4gYSB3YXkg dGhhdCBlbnN1cmVzCisJICogaXQgd2lsbCBhbHdheXMgY2FsbCBfX3Jlc192aW5pdCgpLgorCSAq CisJICogQnkgY2FsbGluZyBfX3Jlc19tYXliZV9pbml0KCkgd2l0aCAncHJlaW5pdCcgc2V0IHRv IDEsIGFuZCBzZXR0aW5nCisJICogX3Jlcy0+b3B0aW9ucycgUkVTX0lOSVQgYml0IG9mZiwgX19y ZXNfdmluaXQoKSB3aWxsIGFsd2F5cyBiZQorCSAqIGNhbGxlZCwgYW5kIHdpbGwgc2V0IHRoZSBt b2RpZmljYXRpb24gZGF0ZS4KKwkgKgorCSAqIFRPRE86IE91ciBzZXR0aW5nIG9mIGRlZmF1bHRz IGFzIGRvbmUgYmVmb3JlIHRoaXMsCisJICogcmV0cmFucywgcmV0cnksIHJlc19vcHRpb25zLCBh bmQgaWQsIGlzIGFsc28gcGVyZm9ybWVkIGluCisJICogX19yZXNfbWF5YmVfaW5pdCgpLCBpZiBw cmVpbml0IGlzIDEuIFJlbW92ZSBmcm9tIHRoaXMgZnVuY3Rpb24sCisJICogYW5kIGFkZCB0aGUg Y29tbWVudHMgdG8gdGhlIG90aGVyIGZ1bmN0aW9uLgorCSAqLworCisJX3Jlcy0+b3B0aW9ucyAm PSB+KDEgPDwgUkVTX0lOSVQpOworCisJcmV0dXJuIChfX3Jlc19tYXliZV9pbml0KCZfcmVzLCAx KSk7CiB9CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvcmVzb2x2L3Jlc19saWJjLmMgYi9yZXNvbHYv cmVzX2xpYmMuYwppbmRleCAyOWUyMzQwLi5hZWY5MmUzIDEwMDY0NAotLS0gYS9yZXNvbHYvcmVz X2xpYmMuYworKysgYi9yZXNvbHYvcmVzX2xpYmMuYwpAQCAtODYsNyArODYsNyBAQCByZXNfaW5p dCh2b2lkKSB7CiAJYXRvbWljaW5jIChfX3Jlc19pbml0c3RhbXApOwogCWF0b21pY2luY3VubG9j ayAobG9jayk7CiAKLQlyZXR1cm4gKF9fcmVzX3Zpbml0KCZfcmVzLCAxKSk7CisJcmV0dXJuIChf X3Jlc19tYXliZV9pbml0KCZfcmVzLCAxKSk7CiB9CiAKIC8qIEluaXRpYWxpemUgcmVzcCBpZiBS RVNfSU5JVCBpcyBub3QgeWV0IHNldCBvciBpZiByZXNfaW5pdCBpbiBzb21lIG90aGVyCkBAIC0x MTMsNiArMTEzLDE0IEBAIF9fcmVzX21heWJlX2luaXQgKHJlc19zdGF0ZSByZXNwLCBpbnQgcHJl aW5pdCkKIAkJfQogCQlyZXR1cm4gMDsKIAl9IGVsc2UgaWYgKHByZWluaXQpIHsKKwkJcmV0ID0g c3RhdCAoX1BBVEhfUkVTQ09ORiwgJnN0YXRidWYpOworCQlfX2xpYmNfbG9ja19sb2NrIChsb2Nr KTsKKwkJaWYgKChyZXQgPT0gMCkgJiYgKGxhc3RfbXRpbWUgIT0gc3RhdGJ1Zi5zdF9tdGltZSkp IHsKKwkJCWxhc3RfbXRpbWUgPSBzdGF0YnVmLnN0X210aW1lOworCQkJYXRvbWljaW5jIChfX3Jl c19pbml0c3RhbXApOworCQl9CisJCV9fbGliY19sb2NrX3VubG9jayAobG9jayk7CisKIAkJaWYg KCFyZXNwLT5yZXRyYW5zKQogCQkJcmVzcC0+cmV0cmFucyA9IFJFU19USU1FT1VUOwogCQlpZiAo IXJlc3AtPnJldHJ5KQpAQCAtMTIwLDYgKzEyOCw5IEBAIF9fcmVzX21heWJlX2luaXQgKHJlc19z dGF0ZSByZXNwLCBpbnQgcHJlaW5pdCkKIAkJcmVzcC0+b3B0aW9ucyA9IFJFU19ERUZBVUxUOwog CQlpZiAoIXJlc3AtPmlkKQogCQkJcmVzcC0+aWQgPSByZXNfcmFuZG9taWQgKCk7CisJCWlmIChy ZXNwLT5uc2NvdW50ID4gMCkKKwkJCV9fcmVzX2ljbG9zZSAocmVzcCwgdHJ1ZSk7CisKIAkJcmV0 dXJuIF9fcmVzX3Zpbml0IChyZXNwLCAxKTsKIAl9IGVsc2UKIAkJcmV0dXJuIF9fcmVzX25pbml0 IChyZXNwKTsK