<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>8356</bug_id>
          
          <creation_ts>2015-09-21 01:18:47 +0000</creation_ts>
          <short_desc>Opkg flag always returns success</short_desc>
          <delta_ts>2016-12-08 22:21:13 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>opkg</product>
          <component>opkg</component>
          <version>0.3.0</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Undecided</priority>
          <bug_severity>minor</bug_severity>
          <target_milestone>0.4.0</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alejandro del Castillo">alejandro.delcastillo</reporter>
          <assigned_to name="Alejandro del Castillo">alejandro.delcastillo</assigned_to>
          
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>54335</commentid>
    <comment_count>0</comment_count>
    <who name="Alejandro del Castillo">alejandro.delcastillo</who>
    <bug_when>2015-09-21 01:18:47 +0000</bug_when>
    <thetext>What steps will reproduce the problem?
1.Run opkg flag with an invalid flag
   opkg flag badflag A
2.Opkg will return no error (0) and a misleading message that makes you think the operation succeeded
   
&quot;Setting flags for package A to badflag.&quot;

Package A will remain unchanged.

What is the expected output? What do you see instead?

Opkg flag only supports the following flags = hold|noprune|user|ok|installed|unpacked

It should validate the input and report an error if invalid.

Originally reported by alejandro.delcastill, Jun 23, 2015
-----------------------------------------------------------------------------</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68614</commentid>
    <comment_count>1</comment_count>
      <attachid>3547</attachid>
    <who name="Oleg Gashev">oleg</who>
    <bug_when>2016-11-26 12:46:52 +0000</bug_when>
    <thetext>Created attachment 3547
[PATCH] Added flag validation to opkg flag call.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68964</commentid>
    <comment_count>2</comment_count>
    <who name="Alejandro del Castillo">alejandro.delcastillo</who>
    <bug_when>2016-12-08 22:21:13 +0000</bug_when>
    <thetext>Commited (14429c593c6ee593da937b859967b645174a730f)

thanks Oleg!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>3547</attachid>
            <date>2016-11-26 12:46:52 +0000</date>
            <delta_ts>2016-11-26 12:46:52 +0000</delta_ts>
            <desc>[PATCH] Added flag validation to opkg flag call.</desc>
            <filename>0001-Added-flag-validation-to-opkg-flag-call.patch</filename>
            <type>text/plain</type>
            <size>2702</size>
            <attacher name="Oleg Gashev">oleg</attacher>
            
              <data encoding="base64">RnJvbSA5YTBhMjYyMGVlNjYxMDMxYjVhOTRhMGRiYzc5Zjk2NzM0OTQ4ODZiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBPbGVnIEdhc2hldiA8b2xlZ0BnYXNoZXYubmV0PgpEYXRlOiBT
YXQsIDI2IE5vdiAyMDE2IDA4OjU0OjI2ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gQWRkZWQgZmxh
ZyB2YWxpZGF0aW9uIHRvIG9wa2cgZmxhZyBjYWxsLgoKRml4ZXMgODM1Ni4KClNpZ25lZC1vZmYt
Ynk6IE9sZWcgR2FzaGV2IDxvbGVnQGdhc2hldi5uZXQ+Ci0tLQogbGlib3BrZy9vcGtnX2NtZC5j
IHwgNDMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQogMSBmaWxl
IGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv
bGlib3BrZy9vcGtnX2NtZC5jIGIvbGlib3BrZy9vcGtnX2NtZC5jCmluZGV4IDU1NGU2YjYuLjMw
YWY4N2UgMTAwNjQ0Ci0tLSBhL2xpYm9wa2cvb3BrZ19jbWQuYworKysgYi9saWJvcGtnL29wa2df
Y21kLmMKQEAgLTY5NCwxMiArNjk0LDQ4IEBAIHN0YXRpYyBpbnQgb3BrZ19yZW1vdmVfY21kKGlu
dCBhcmdjLCBjaGFyICoqYXJndikKICAgICByZXR1cm4gZXJyOwogfQogCisvKiogXGJyaWVmIG9w
a2dfaXNfc3RhdGVfZmxhZzogdGVsbHMgd2hldGhlciB0aGUgZmxhZyBpcyBzdGF0ZSBmbGFnCisg
KgorICogXHBhcmFtIGZsYWcKKyAqIFxyZXR1cm4gMSBpcyBzdWNjZXNzLCAwIG90aGVyd2lzZQor
ICovCitzdGF0aWMgaW50IG9wa2dfaXNfc3RhdGVfZmxhZyhjb25zdCBjaGFyKiBmbGFnKQorewor
ICAgIHJldHVybiAoCisgICAgICAgIChzdHJjbXAoZmxhZywgImhvbGQiKSA9PSAwKSB8fAorICAg
ICAgICAoc3RyY21wKGZsYWcsICJub3BydW5lIikgPT0gMCkgfHwKKyAgICAgICAgKHN0cmNtcChm
bGFnLCAib2siKSA9PSAwKSB8fAorICAgICAgICAoc3RyY21wKGZsYWcsICJ1c2VyIikgPT0gMCkK
KyAgICApOworfQorCisvKiogXGJyaWVmIG9wa2dfaXNfc3RhdGVfc3RhdHVzX2ZsYWc6IHRlbGxz
IHdoZXRoZXIgdGhlIGZsYWcgaXMgc3RhdHVzIGZsYWcKKyAqCisgKiBccGFyYW0gZmxhZworICog
XHJldHVybiAxIGlzIHN1Y2Nlc3MsIDAgb3RoZXJ3aXNlCisgKi8KK3N0YXRpYyBpbnQgb3BrZ19p
c19zdGF0ZV9zdGF0dXNfZmxhZyhjb25zdCBjaGFyKiBmbGFnKQoreworICAgIHJldHVybiAoCisg
ICAgICAgIChzdHJjbXAoZmxhZywgImluc3RhbGxlZCIpID09IDApIHx8CisgICAgICAgIChzdHJj
bXAoZmxhZywgInVucGFja2VkIikgPT0gMCkKKyAgICApOworfQorCiBzdGF0aWMgaW50IG9wa2df
ZmxhZ19jbWQoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogewogICAgIGludCBpOwogICAgIHBrZ190
ICpwa2c7CiAgICAgY29uc3QgY2hhciAqZmxhZ3MgPSBhcmd2WzBdOwogCisgICAgaW50IGlzX3N0
YXRlX2ZsYWcgPSBvcGtnX2lzX3N0YXRlX2ZsYWcoZmxhZ3MpOworICAgIGludCBpc19zdGF0ZV9z
dGF0dXNfZmxhZyA9IG9wa2dfaXNfc3RhdGVfc3RhdHVzX2ZsYWcoZmxhZ3MpOworCisgICAgaWYg
KCghaXNfc3RhdGVfZmxhZykgJiYgKCFpc19zdGF0ZV9zdGF0dXNfZmxhZykpIHsKKyAgICAgICAg
b3BrZ19tc2coRVJST1IsICJJbnZhbGlkIGZsYWc6ICVzLlxuIiwgZmxhZ3MpOworICAgICAgICBy
ZXR1cm4gLTE7CisgICAgfQorCiAgICAgc2lnbmFsKFNJR0lOVCwgc2lnaW50X2hhbmRsZXIpOwog
CiAgICAgZm9yIChpID0gMTsgaSA8IGFyZ2M7IGkrKykgewpAQCAtNzE0LDggKzc1MCw3IEBAIHN0
YXRpYyBpbnQgb3BrZ19mbGFnX2NtZChpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAgICAgICAgICAg
ICBvcGtnX21zZyhFUlJPUiwgIlBhY2thZ2UgJXMgaXMgbm90IGluc3RhbGxlZC5cbiIsIGFyZ3Zb
aV0pOwogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIH0KLSAgICAgICAgaW50IGlzX3N0
YXRlX2ZsYWcgPSAoKHN0cmNtcChmbGFncywgImhvbGQiKSA9PSAwKSB8fCAoc3RyY21wKGZsYWdz
LCAibm9wcnVuZSIpID09IDApCi0gICAgICAgICAgICAgICAgfHwgKHN0cmNtcChmbGFncywgInVz
ZXIiKSA9PSAwKSB8fCAoc3RyY21wKGZsYWdzLCAib2siKSA9PSAwKSk7CisKICAgICAgICAgaWYg
KGlzX3N0YXRlX2ZsYWcpIHsKICAgICAgICAgICAgIHBrZy0+c3RhdGVfZmxhZyA9IHBrZ19zdGF0
ZV9mbGFnX2Zyb21fc3RyKGZsYWdzKTsKICAgICAgICAgfQpAQCAtNzI0LDkgKzc1OSw3IEBAIHN0
YXRpYyBpbnQgb3BrZ19mbGFnX2NtZChpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAgICAgICAgICAq
IFVzZWZ1bCBpZiBhIHBhY2thZ2UgaXMgaW5zdGFsbGVkIGluIGFuIG9mZmxpbmVfcm9vdCwgYW5k
CiAgICAgICAgICAqIHNob3VsZCBiZSBjb25maWd1cmVkIGJ5IG9wa2cgY29uZmlndXJlIGF0IGEg
bGF0ZXIgZGF0ZS4KICAgICAgICAgICovCi0gICAgICAgIGludCBpc19zdGF0ZV9zdGF0dXMgPSAo
KHN0cmNtcChmbGFncywgImluc3RhbGxlZCIpID09IDApCi0gICAgICAgICAgICAgICAgfHwgKHN0
cmNtcChmbGFncywgInVucGFja2VkIikgPT0gMCkpOwotICAgICAgICBpZiAoaXNfc3RhdGVfc3Rh
dHVzKSB7CisgICAgICAgIGlmIChpc19zdGF0ZV9zdGF0dXNfZmxhZykgewogICAgICAgICAgICAg
cGtnLT5zdGF0ZV9zdGF0dXMgPSBwa2dfc3RhdGVfc3RhdHVzX2Zyb21fc3RyKGZsYWdzKTsKICAg
ICAgICAgfQogCi0tIAoxLjguMy4xCgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>