<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>8451</bug_id>
          
          <creation_ts>2015-10-06 15:10:51 +0000</creation_ts>
          <short_desc>readline: apply missing upstream patches</short_desc>
          <delta_ts>2016-01-12 16:39:26 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Petter">petter</reporter>
          <assigned_to name="Petter">petter</assigned_to>
          <cc>bogdanx.a.voiculescu</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
          
          <qa_contact name="Bogdan Alexandru Voiculescu">bogdanx.a.voiculescu</qa_contact>
          <cf_os>---</cf_os>
          <cf_regression_type>Unknown (Hard to categorize)</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>54996</commentid>
    <comment_count>0</comment_count>
    <who name="Petter">petter</who>
    <bug_when>2015-10-06 15:10:51 +0000</bug_when>
    <thetext>There are a number of missing patches from upstream that isn&apos;t applied for readline 6.3 (see http://ftp.gnu.org/gnu/readline/readline-6.3-patches/ for available 6.3 patches). Ensure that they are applied and also consider adding missing patches for readline 5.2.

See the discussion in http://lists.openembedded.org/pipermail/openembedded-core/2015-October/111321.html for some background.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>54997</commentid>
    <comment_count>1</comment_count>
    <who name="Petter">petter</who>
    <bug_when>2015-10-06 15:13:45 +0000</bug_when>
    <thetext>Fixing this in 2.0 scope has to much impact, so aim for fixing it in 2.1 instead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>55098</commentid>
    <comment_count>2</comment_count>
    <who name="Petter">petter</who>
    <bug_when>2015-10-09 07:01:07 +0000</bug_when>
    <thetext>After input from Marko my suggestion is that we continue to use the strategy Marko has used for readline 5.2 and fetch the patches directly from upstream. See below mail discussion for further info.

http://lists.openembedded.org/pipermail/openembedded-core/2015-October/111353.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>56574</commentid>
    <comment_count>3</comment_count>
    <who name="Petter">petter</who>
    <bug_when>2015-11-18 11:43:28 +0000</bug_when>
    <thetext>I have started to work with this bug report and will send something up when I have been able to verify the new patches.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>56575</commentid>
    <comment_count>4</comment_count>
    <who name="Petter">petter</who>
    <bug_when>2015-11-18 12:23:13 +0000</bug_when>
    <thetext>Work-in-progress fixes can be found at:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=petmab/bug_8451

Note that the patches are not fully verified yet. When it comes to readline-5.2 no new upstream patches exists so will leave it as is (as expected).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>56729</commentid>
    <comment_count>5</comment_count>
    <who name="Petter">petter</who>
    <bug_when>2015-11-24 10:14:51 +0000</bug_when>
    <thetext>verification:

run below for qemux86-64:
$ bitbake world
$ bitbake core-image-minimal
$ bitbake core-image-sato
$ bitbake readline [ -c &lt;relevant tasks&gt; ]

Enable TEST_IMAGE for sato image and all tests passed.

Tested basic readline functionality with an internal test tool that creates a promt using readline() and add commands to history etc..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>57392</commentid>
    <comment_count>6</comment_count>
    <who name="Petter">petter</who>
    <bug_when>2015-12-18 17:08:11 +0000</bug_when>
    <thetext>Merge into &apos;master&apos; :

7e3474c readline: apply missing upstream patches
99b9d52 readline: prepare for readline6.3 upstream patches</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>57755</commentid>
    <comment_count>7</comment_count>
    <who name="Bogdan Alexandru Voiculescu">bogdanx.a.voiculescu</who>
    <bug_when>2016-01-12 16:39:26 +0000</bug_when>
    <thetext>Verified on master: no errors. 
Build Configuration:
BB_VERSION        = &quot;1.28.0&quot;
BUILD_SYS         = &quot;x86_64-linux&quot;
NATIVELSBSTRING   = &quot;Ubuntu-14.04&quot;
TARGET_SYS        = &quot;x86_64-poky-linux&quot;
MACHINE           = &quot;qemux86-64&quot;
DISTRO            = &quot;poky&quot;
DISTRO_VERSION    = &quot;2.0+snapshot-20160112&quot;
TUNE_FEATURES     = &quot;m64 core2&quot;
TARGET_FPU        = &quot;&quot;
meta
meta-yocto
meta-yocto-bsp    = &quot;master:1724ffd32d1c169a2de66f2cb88ba18c56da6146&quot;

NOTE: Preparing RunQueue
NOTE: Executing SetScene Tasks
NOTE: Executing RunQueue Tasks
core-image-sato - Ran 43 tests in 1079.564s
core-image-sato - OK - All required tests passed
NOTE: Tasks Summary: Attempted 274 tasks of which 273 didn&apos;t need to be rerun and all succeeded.
NOTE: Writing buildhistory</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>