<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>846</bug_id>
          
          <creation_ts>2011-03-10 18:03:47 +0000</creation_ts>
          <short_desc>Bitbake: provide more information for COMMERCIAL_LICENSE recipes</short_desc>
          <delta_ts>2011-08-25 03:05:26 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>BitBake</product>
          <component>bitbake</component>
          <version>1.0</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Low</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>1.1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ke Yu">ke.yu</reporter>
          <assigned_to name="Paul Eggleton">bluelightning</assigned_to>
          <cc>bluelightning</cc>
    
    <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
    
    <cc>sgw</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>---</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>12469</commentid>
    <comment_count>0</comment_count>
    <who name="Ke Yu">ke.yu</who>
    <bug_when>2011-03-10 18:03:47 +0000</bug_when>
    <thetext>When user bitbake recipe under COMMERCIAL_LICENSE, bitbake simply output 
&quot;&quot;ERROR: Nothing PROVIDES &apos;xxxxx&apos;&quot;. this is not that helpful to user.

it would be better that bitbake output info like &quot;xxxxxx is disabled due to COMMERCIAL_LICENSE&quot;

Reproduce step:

# bitbake lame

ERROR: Nothing PROVIDES &apos;lame&apos;
ERROR: Command execution failed: Traceback (most recent call last):
  File &quot;/home/kyu3/src/poky/bitbake/lib/bb/command.py&quot;, line 102, in runAsyncCommand
    commandmethod(self.cmds_async, self, options)
  File &quot;/home/kyu3/src/poky/bitbake/lib/bb/command.py&quot;, line 200, in buildTargets
    command.cooker.buildTargets(pkgs_to_build, task)
  File &quot;/home/kyu3/src/poky/bitbake/lib/bb/cooker.py&quot;, line 824, in buildTargets
    taskdata.add_provider(localdata, self.status, k)
  File &quot;/home/kyu3/src/poky/bitbake/lib/bb/taskdata.py&quot;, line 353, in add_provider
    self.add_provider_internal(cfgData, dataCache, item)
  File &quot;/home/kyu3/src/poky/bitbake/lib/bb/taskdata.py&quot;, line 373, in add_provider_internal
    raise bb.providers.NoProvider(item)
NoProvider: lame</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>15068</commentid>
    <comment_count>1</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2011-07-28 08:35:39 +0000</bug_when>
    <thetext>We now output the following:

------- snip --------
ERROR: Nothing PROVIDES &apos;lame&apos;
ERROR: lame was skipped: because it requires commercial license to ship product
ERROR: Command execution failed: Traceback (most recent call last):
  File &quot;/home/paul/poky/poky/bitbake/lib/bb/command.py&quot;, line 102, in runAsyncCommand
    commandmethod(self.cmds_async, self, options)
  File &quot;/home/paul/poky/poky/bitbake/lib/bb/command.py&quot;, line 200, in buildTargets
    command.cooker.buildTargets(pkgs_to_build, task)
  File &quot;/home/paul/poky/poky/bitbake/lib/bb/cooker.py&quot;, line 1069, in buildTargets
    taskdata.add_provider(localdata, self.status, k)
  File &quot;/home/paul/poky/poky/bitbake/lib/bb/taskdata.py&quot;, line 371, in add_provider
    self.add_provider_internal(cfgData, dataCache, item)
  File &quot;/home/paul/poky/poky/bitbake/lib/bb/taskdata.py&quot;, line 391, in add_provider_internal
    raise bb.providers.NoProvider(item)
NoProvider: lame
------- snip --------

Is this enough or do we need to alter the reason message? (The backtrace is a separate issue)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>15535</commentid>
    <comment_count>2</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2011-08-17 16:38:10 +0000</bug_when>
    <thetext>Any answer for the above comment?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>15538</commentid>
    <comment_count>3</comment_count>
    <who name="Ke Yu">ke.yu</who>
    <bug_when>2011-08-17 17:38:14 +0000</bug_when>
    <thetext>yes, i think it is enough, as it show the reason of commercial license. it would even better if we show &quot;COMMERCIAL_LICENSE&quot; keyword in the message, so that user can grep it and know where to fix it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>15750</commentid>
    <comment_count>4</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2011-08-25 03:05:26 +0000</bug_when>
    <thetext>Reason now displayed as of http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=daed107ce188c6ae53a3d612de58885f23b7257e

Extended the reason to mention COMMERCIAL_LICENSE explicitly in http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=5f6dcb2bc2c5cb157e95e97a6fc7c5197a96419a

Marking as resolved.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>