<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>8511</bug_id>
          
          <creation_ts>2015-10-14 12:51:52 +0000</creation_ts>
          <short_desc>Import layer page, &quot;Add layer&quot; button remains enabled when layer text input is empty</short_desc>
          <delta_ts>2016-05-10 21:42:40 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>Toaster</product>
          <component>toaster</component>
          <version>2.1</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Low</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Elliot Smith">elliot.smith</reporter>
          <assigned_to name="Elliot Smith">elliot.smith</assigned_to>
          <cc>belen.barros.pena</cc>
    
    <cc>jessica.zhang</cc>
    
    <cc>stanciux.mihail</cc>
          
          <qa_contact name="Libertad">libertad.gonzalez.de.la.cruz</qa_contact>
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>55292</commentid>
    <comment_count>0</comment_count>
    <who name="Elliot Smith">elliot.smith</who>
    <bug_when>2015-10-14 12:51:52 +0000</bug_when>
    <thetext>The &quot;Add layer&quot; button on the Import layer page remains enabled even if the text input is empty. This could result in a user accidentally adding the wrong layer to their project.

To reproduce:

1. Start Toaster and create a new project.
2. Go to the dashboard for that project (click on the project&apos;s name in the All projects table).
3. Open the &quot;Import layer&quot; tab for the project.
4. Scroll down to the &quot;Layer dependencies&quot; section. Note that the &quot;Add layer&quot; button is disabled.
5. Start typing a layer name into the text input, e.g. &quot;e100&quot;. Some typeahead entries should be shown, including e100-bsp. Click on that to select it. The &quot;Add layer&quot; button becomes enabled.
6. Delete all of the &quot;e100-bsp&quot; text from the text input by selecting it and pressing Backspace.

Expected:

The &quot;Add layer&quot; button is disabled, as there is no layer name in the text input any more.

Actual:

The &quot;Add layer&quot; button remains active. Clicking on it adds the last-selected layer (e100-bsp in this case).


Note that this is similar to bug 8449 and probably has a similar root.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>60472</commentid>
    <comment_count>1</comment_count>
    <who name="Elliot Smith">elliot.smith</who>
    <bug_when>2016-03-29 10:11:32 +0000</bug_when>
    <thetext>Tested on toaster-next, and this bug is still present.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>60903</commentid>
    <comment_count>2</comment_count>
    <who name="Elliot Smith">elliot.smith</who>
    <bug_when>2016-04-07 13:22:08 +0000</bug_when>
    <thetext>Implemented fix; review request at https://lists.yoctoproject.org/pipermail/toaster/2016-March/004335.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>61389</commentid>
    <comment_count>3</comment_count>
    <who name="Elliot Smith">elliot.smith</who>
    <bug_when>2016-04-19 11:11:50 +0000</bug_when>
    <thetext>Now that the Bootstrap 3 work has been put aside momentarily, I sent a reminder to review this:
https://lists.yoctoproject.org/pipermail/toaster/2016-April/004468.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>61482</commentid>
    <comment_count>4</comment_count>
    <who name="Elliot Smith">elliot.smith</who>
    <bug_when>2016-04-21 11:05:55 +0000</bug_when>
    <thetext>Now in bitbake master.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>62079</commentid>
    <comment_count>5</comment_count>
    <who name="Libertad">libertad.gonzalez.de.la.cruz</who>
    <bug_when>2016-05-10 21:42:40 +0000</bug_when>
    <thetext>This was verified in 2.1-M4-RC2</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>