<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>8676</bug_id>
          
          <creation_ts>2015-11-11 15:36:13 +0000</creation_ts>
          <short_desc>QA: devtool: extend oe-selftest testing for devtool upgrade</short_desc>
          <delta_ts>2020-01-09 16:43:59 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>devtools / tool chain</component>
          <version>5.99</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>Future</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Paul Eggleton">bluelightning</reporter>
          <assigned_to name="Unassigned">unassigned</assigned_to>
          <cc>akuster</cc>
    
    <cc>benjamin.esquivel</cc>
    
    <cc>joshuagloe</cc>
    
    <cc>juan.m.cruz.alcaraz</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>richard.purdie</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>56384</commentid>
    <comment_count>0</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2015-11-11 15:36:13 +0000</bug_when>
    <thetext>The current &quot;devtool upgrade&quot; test in meta/lib/oeqa/selftest/devtool.py only does a basic test that upgrading a recipe with local source files works, which is not a common use case. We need to also test:

1) Upgrading a recipe pointing to a remote tarball (part of this will be verifying that the checksums get updated)

2) Upgrading a git recipe

As part of these We should also validate that only relevant variables in the recipe get modified (and that they are modified appropriately)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>61707</commentid>
    <comment_count>1</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2016-04-27 03:50:10 +0000</bug_when>
    <thetext>For 2.1 the existing test was reworked to test upgrading a recipe pointing to a remote file and do more validation, plus an additional test to upgrade a recipe pointing to a git repository. We should look to see if there are any code paths not tested by these current tests and add tests to cover them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>61720</commentid>
    <comment_count>2</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2016-04-27 13:42:10 +0000</bug_when>
    <thetext>(In reply to comment #1)
&gt; For 2.1 the existing test was reworked to test upgrading a recipe pointing
&gt; to a remote file and do more validation, plus an additional test to upgrade
&gt; a recipe pointing to a git repository. We should look to see if there are
&gt; any code paths not tested by these current tests and add tests to cover them.

Thanks for the update. I will review latest code and cover it with tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>74433</commentid>
    <comment_count>3</comment_count>
    <who name="Jose Perez C">jose.perez.carranza</who>
    <bug_when>2017-06-21 15:46:03 +0000</bug_when>
    <thetext>currently the test for devtool upgrade are covering :

- test_devtool_upgrade
- test_devtool_upgrade_git
- test_devtool_finish_upgrade_origlayer
- test_devtool_finish_upgrade_otherlayer

I is there any missing scenario that you identify that need to be tested ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>74951</commentid>
    <comment_count>4</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2017-07-12 12:09:08 +0000</bug_when>
    <thetext>I would like to see what the coverage of the upgrade module (scripts/lib/devtool/upgrade.py) is - Jose is that something you have easily available?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75009</commentid>
    <comment_count>5</comment_count>
    <who name="Jose Perez C">jose.perez.carranza</who>
    <bug_when>2017-07-13 16:04:40 +0000</bug_when>
    <thetext>(In reply to comment #4)
&gt; I would like to see what the coverage of the upgrade module
&gt; (scripts/lib/devtool/upgrade.py) is - Jose is that something you have easily
&gt; available?

Unfortunately coverage option is not working on new framework (Bug 11582), I will do some tests on pyro and get back to you with the results.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75010</commentid>
    <comment_count>6</comment_count>
    <who name="Jose Perez C">jose.perez.carranza</who>
    <bug_when>2017-07-13 16:05:19 +0000</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; I would like to see what the coverage of the upgrade module
&gt; &gt; (scripts/lib/devtool/upgrade.py) is - Jose is that something you have easily
&gt; &gt; available?
&gt; 
&gt; Unfortunately coverage option is not working on new framework (Bug 11582), I
&gt; will do some tests on pyro and get back to you with the results.

Unfortunately coverage option is not working on new framework (Bug 11582), I will do some tests on pyro and get back to you with the results.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75020</commentid>
    <comment_count>7</comment_count>
    <who name="Jose Perez C">jose.perez.carranza</who>
    <bug_when>2017-07-13 21:07:03 +0000</bug_when>
    <thetext>(In reply to comment #6)
&gt; (In reply to comment #5)
&gt; &gt; (In reply to comment #4)
&gt; &gt; &gt; I would like to see what the coverage of the upgrade module
&gt; &gt; &gt; (scripts/lib/devtool/upgrade.py) is - Jose is that something you have easily
&gt; &gt; &gt; available?
&gt; &gt; 
&gt; &gt; Unfortunately coverage option is not working on new framework (Bug 11582), I
&gt; &gt; will do some tests on pyro and get back to you with the results.
&gt; 
&gt; Unfortunately coverage option is not working on new framework (Bug 11582), I
&gt; will do some tests on pyro and get back to you with the results.

A Bug 11786 was opened due coverage is not working properly on pyro, util that is resolved I will not be able to check what is the current coverage.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>76341</commentid>
    <comment_count>8</comment_count>
    <who name="Jose Perez C">jose.perez.carranza</who>
    <bug_when>2017-08-30 15:49:38 +0000</bug_when>
    <thetext>Moved to 2.5 due resources constraint</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>85909</commentid>
    <comment_count>9</comment_count>
    <who name="Armin Kuster">akuster</who>
    <bug_when>2019-12-22 19:22:03 +0000</bug_when>
    <thetext>this still seems reasonable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86012</commentid>
    <comment_count>10</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2020-01-09 16:43:59 +0000</bug_when>
    <thetext>devtool upgrade tests were added. The remaining question here was about code coverage. I don&apos;t believe we ever figured out correct tools for code coverage of that they are practical with the system so closing the original issue a resolved. If anyone identifies areas needing further testing we will add them.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>