<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>8848</bug_id>
          
          <creation_ts>2015-12-22 09:57:47 +0000</creation_ts>
          <short_desc>Would like to be able to share a single Kickstart partition layout definition (.wks) between several images</short_desc>
          <delta_ts>2016-02-17 16:01:25 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>Scripts and Tools</component>
          <version>2.0</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>2.1 M3</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Joshua Lock">joshuagloe</reporter>
          <assigned_to name="Ed Bartosh">eduard.bartosh</assigned_to>
          <cc>alexandru.c.georgescu</cc>
    
    <cc>ross.burton</cc>
          
          <qa_contact name="Daniel Istrate">daniel.alexandrux.istrate</qa_contact>
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Yes (doc changes required)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>57423</commentid>
    <comment_count>0</comment_count>
    <who name="Joshua Lock">joshuagloe</who>
    <bug_when>2015-12-22 09:57:47 +0000</bug_when>
    <thetext>We&apos;re building several images which share a standard parition layout defined in a .wks file and built through the IMAGE_CMD_wic function defined in image_types.bbclass.

Because that function looks for ${IMAGE_BASENAME}.${MACHINE}.wks and ${IMAGE_BASENAME}.wks we have to symlink our base .wks to the appropriate IMAGE_BASENAME&apos;s for the other images.

This is even messier for multiple layers that build on a shared base layer and each define images.

It would be really nice if we could define a variable, i.e. in our shared image class, that tells the image generation code where to load a shared .wks file from.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>57959</commentid>
    <comment_count>1</comment_count>
    <who name="Ed Bartosh">eduard.bartosh</who>
    <bug_when>2016-01-19 17:37:38 +0000</bug_when>
    <thetext>Sent implementation for review: http://lists.openembedded.org/pipermail/openembedded-core/2016-January/115798.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>57966</commentid>
    <comment_count>2</comment_count>
    <who name="Ed Bartosh">eduard.bartosh</who>
    <bug_when>2016-01-19 18:55:45 +0000</bug_when>
    <thetext>Sent v2: http://lists.openembedded.org/pipermail/openembedded-core/2016-January/115808.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>58129</commentid>
    <comment_count>3</comment_count>
    <who name="Ed Bartosh">eduard.bartosh</who>
    <bug_when>2016-01-22 10:24:15 +0000</bug_when>
    <thetext>the implementation of wks &apos;include&apos; statement was accepted to master:
http://cgit.openembedded.org/openembedded-core/commit/?id=3695962ba4b685f304f1039978cec60d1b1712e3</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>59156</commentid>
    <comment_count>4</comment_count>
    <who name="Daniel Istrate">daniel.alexandrux.istrate</who>
    <bug_when>2016-02-17 16:01:25 +0000</bug_when>
    <thetext>Verified on master: 152914f2983c5d69001de1d46ce99547fa1e75fe

The directdisk.wks , directdisk-bootloader-config.wks and qemux86-directdisk.wks are including the common.wks.inc.

Building directdisk, directdisk-bootloader-config and qemux86-directdisk works as before.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>