<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>8851</bug_id>
          
          <creation_ts>2015-12-22 19:35:14 +0000</creation_ts>
          <short_desc>Add bashism checks for shell script functions</short_desc>
          <delta_ts>2017-12-06 16:51:21 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>2.0</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>2.2 M4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Paul Eggleton">bluelightning</reporter>
          <assigned_to name="Ross Burton">ross.burton</assigned_to>
          <cc>jose.perez.carranza</cc>
    
    <cc>junhuix.zhang</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>richard.purdie</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Yes (doc changes required)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>57437</commentid>
    <comment_count>0</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2015-12-22 19:35:14 +0000</bug_when>
    <thetext>Seeing as we often have the issue of bashisms turning up in shell functions and therefore failing on Ubuntu, we should add some kind of check for these if it&apos;s practical to do so. Presumably this would use checkbashisms. 

I don&apos;t know if it will be practical to do this as a normal QA check; if we have to do it externally that would be acceptable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>57628</commentid>
    <comment_count>1</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2016-01-07 15:47:38 +0000</bug_when>
    <thetext>Since we parse the shell functions, could the parser check for these?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>57901</commentid>
    <comment_count>2</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2016-01-17 22:21:51 +0000</bug_when>
    <thetext>*** Bug 8932 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>58878</commentid>
    <comment_count>3</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2016-02-11 12:07:40 +0000</bug_when>
    <thetext>checkbashisms is 26k of perl, so I don&apos;t fancy reimplementing that in Python to be honest!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>58879</commentid>
    <comment_count>4</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2016-02-11 12:08:49 +0000</bug_when>
    <thetext>I&apos;m thinking a bit of tooling to extract all the shell scripts from the metadata and run it through checkbashisms would be more practical that verifying on every parse.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>58937</commentid>
    <comment_count>5</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2016-02-11 23:26:47 +0000</bug_when>
    <thetext>Well I&apos;ve made a prototype and it bloody well works!  checkbashism is far too slow to do on parse.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>66310</commentid>
    <comment_count>6</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2016-09-19 12:42:14 +0000</bug_when>
    <thetext>Merge in oe-core d77fe838ab7631a19e90ff4226f0712e54aa4e22.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>