8854 2015-12-22 21:43:26 +0000 wic rawcopy plugin consumes source, doesn't copy (or the case of files going missing from my deploy dir…) 2016-02-08 16:14:35 +0000 1 1 7 Build System, Metadata & Runtime OE-Core Scripts and Tools 2.0 x86 Multiple RESOLVED FIXED Medium normal 2.1 1 joshuagloe eduard.bartosh bogdanx.a.voiculescu ross.burton daniel.alexandrux.istrate --- --- No (bug/feature does not impact docs) oldest_to_newest 57442 0 joshuagloe 2015-12-22 21:43:26 +0000 After switching to using wic (and the image_types.bbclass function IMAGE_CMD_wic) I noticed that the source file I pass to the rawcopy plugin keeps going missing after the image is constructed. This is because: - if 'skip' isn't in the source parameters the partition source_file is set to the 'file' parameter in rawcopy.py's do_prepare_partition() method - during the assemble() method of partitionedfs.py each partition source is renamed to ${OUTDIR}/${IMAGE_FILENAME}.p${PART_NUM} after it has been installed into the image - after the image is assembled and copied to the deploy directory the IMAGE_CMD_wic removes the wic output directory, deleting all of the partition sources The end result here is that a source passed to the rawcopy plugin is moved (pretty bad) and possibly deleted (very bad) depending on how wic is used. 57462 1 2912 eduard.bartosh 2015-12-23 12:27:23 +0000 Created attachment 2912 possible fix I've attached slightly modified change made by Noor Ahsan http://lists.openembedded.org/pipermail/openembedded-core/2015-October/111831.html Can you please check if it fixes the issue? 57463 2 2913 eduard.bartosh 2015-12-23 12:32:05 +0000 Created attachment 2913 possible fix v.2 Attached slightly modified patch. 57465 3 joshuagloe 2015-12-23 13:59:07 +0000 Hi Ed, This patch does seem to work I've just tested this patch. I have built two images in a row and the source file of the rawcopy remains in my DEPLOY_IMAGE_DIR. Regards, Joshua 57466 4 eduard.bartosh 2015-12-23 14:23:57 +0000 Hi Joshua, Thank you for testing the patch! I've just sent it for review: http://lists.openembedded.org/pipermail/openembedded-core/2015-December/114602.html 57669 5 eduard.bartosh 2016-01-08 11:19:14 +0000 The fix has been merged to master: http://cgit.openembedded.org/openembedded-core/commit/?id=33c52b1f2d39feb641465bf42e8b16d0ab22a316 2912 2015-12-23 12:27:23 +0000 2015-12-23 12:32:05 +0000 possible fix file_8854.txt text/plain 790 eduard.bartosh LS0tIGEvc2NyaXB0cy9saWIvd2ljL3BsdWdpbnMvc291cmNlL3Jhd2NvcHkucHkNCisrKyBiL3Nj cmlwdHMvbGliL3dpYy9wbHVnaW5zL3NvdXJjZS9yYXdjb3B5LnB5DQpAQCAtNjcsMTMgKzY3LDE1 IEBAIGNsYXNzIFJhd0NvcHlQbHVnaW4oU291cmNlUGx1Z2luKToNCiAgICAgICAgICAgICByZXR1 cm4NCg0KICAgICAgICAgc3JjID0gb3MucGF0aC5qb2luKGJvb3RpbWdfZGlyLCBzb3VyY2VfcGFy YW1zWydmaWxlJ10pDQotICAgICAgICBkc3QgPSBzcmMNCisgICAgICAgIGRzdCA9IG9zLnBhdGgu am9pbihjcl93b3JrZGlyLCBzb3VyY2VfcGFyYW1zWydmaWxlJ10pDQoNCiAgICAgICAgIGlmICdz a2lwJyBpbiBzb3VyY2VfcGFyYW1zOg0KLSAgICAgICAgICAgIGRzdCA9IG9zLnBhdGguam9pbihj cl93b3JrZGlyLCBzb3VyY2VfcGFyYW1zWydmaWxlJ10pDQogICAgICAgICAgICAgZGRfY21kID0g ImRkIGlmPSVzIG9mPSVzIGlicz0lcyBza2lwPTEgY29udj1ub3RydW5jIiAlIFwNCiAgICAgICAg ICAgICAgICAgICAgIChzcmMsIGRzdCwgc291cmNlX3BhcmFtc1snc2tpcCddKQ0KICAgICAgICAg ICAgIGV4ZWNfY21kKGRkX2NtZCkNCisgICAgICAgIGVsc2U6DQorICAgICAgICAgICAgZGRfY21k ID0gImNwICVzICVzIiAlIChzcmMsIGRzdCkNCisgICAgICAgICAgICBleGVjX2NtZChkZF9jbWQp DQoNCiAgICAgICAgICMgZ2V0IHRoZSBzaXplIGluIHRoZSByaWdodCB1bml0cyBmb3Iga2lja3N0 YXJ0IChrQikNCiAgICAgICAgIGR1X2NtZCA9ICJkdSAtTGJrcyAlcyIgJSBkc3QNCg== 2913 2015-12-23 12:32:05 +0000 2015-12-23 12:32:05 +0000 possible fix v.2 file_8854.txt text/plain 786 eduard.bartosh LS0tIGEvc2NyaXB0cy9saWIvd2ljL3BsdWdpbnMvc291cmNlL3Jhd2NvcHkucHkNCisrKyBiL3Nj cmlwdHMvbGliL3dpYy9wbHVnaW5zL3NvdXJjZS9yYXdjb3B5LnB5DQpAQCAtNjcsMTMgKzY3LDE0 IEBAIGNsYXNzIFJhd0NvcHlQbHVnaW4oU291cmNlUGx1Z2luKToNCiAgICAgICAgICAgICByZXR1 cm4NCg0KICAgICAgICAgc3JjID0gb3MucGF0aC5qb2luKGJvb3RpbWdfZGlyLCBzb3VyY2VfcGFy YW1zWydmaWxlJ10pDQotICAgICAgICBkc3QgPSBzcmMNCisgICAgICAgIGRzdCA9IG9zLnBhdGgu am9pbihjcl93b3JrZGlyLCBzb3VyY2VfcGFyYW1zWydmaWxlJ10pDQoNCiAgICAgICAgIGlmICdz a2lwJyBpbiBzb3VyY2VfcGFyYW1zOg0KLSAgICAgICAgICAgIGRzdCA9IG9zLnBhdGguam9pbihj cl93b3JrZGlyLCBzb3VyY2VfcGFyYW1zWydmaWxlJ10pDQogICAgICAgICAgICAgZGRfY21kID0g ImRkIGlmPSVzIG9mPSVzIGlicz0lcyBza2lwPTEgY29udj1ub3RydW5jIiAlIFwNCiAgICAgICAg ICAgICAgICAgICAgIChzcmMsIGRzdCwgc291cmNlX3BhcmFtc1snc2tpcCddKQ0KLSAgICAgICAg ICAgIGV4ZWNfY21kKGRkX2NtZCkNCisgICAgICAgIGVsc2U6DQorICAgICAgICAgICAgZGRfY21k ID0gImNwICVzICVzIiAlIChzcmMsIGRzdCkNCisgICAgICAgIGV4ZWNfY21kKGRkX2NtZCkNCg0K ICAgICAgICAgIyBnZXQgdGhlIHNpemUgaW4gdGhlIHJpZ2h0IHVuaXRzIGZvciBraWNrc3RhcnQg KGtCKQ0KICAgICAgICAgZHVfY21kID0gImR1IC1MYmtzICVzIiAlIGRzdA0K