8866 2016-01-04 11:48:07 +0000 Home-brew JSON encoding is ad hoc and incomplete 2023-12-14 04:24:42 +0000 1 1 7 Build System, Metadata & Runtime Toaster toaster 2.1 x86 Multiple NEW Medium enhancement Future 1 elliot.smith toaster belen.barros.pena david.reyna jessica.zhang jose.perez.carranza stanciux.mihail --- --- No (bug/feature does not impact docs) oldest_to_newest 57503 0 elliot.smith 2016-01-04 11:48:07 +0000 The JSON encoder used to convert querysets to JSON responses is hand-cranked and incomplete. It recently caused an issue where we had a decimal field in a queryset and our encoder didn't know what to do with it, so it failed with a mostly incomprehensible error. objtojson() in toastergui/views.py is the main offender, closely followed by the code locations which call that function. Rather than use objtojson() and friends, we should use the Django JSON encoder as far as possible, and maybe even the Django JSON HTTP response classes when encoding the body of a response.