<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>9001</bug_id>
          
          <creation_ts>2016-01-26 10:32:43 +0000</creation_ts>
          <short_desc>bootimg.bbclass does not document GRUB boot lodader support</short_desc>
          <delta_ts>2017-05-13 04:17:30 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>9</classification_id>
          <classification>Documentation</classification>
          <product>Mega Manual</product>
          <component>mega-manual</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard>12 May 2017: RESOLVED</status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.3 M4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gatis Paeglis">gatis.paeglis</reporter>
          <assigned_to name="Scott Rifenbark">srifenbark</assigned_to>
          <cc>bluelightning</cc>
    
    <cc>california.l.sullivan</cc>
    
    <cc>srifenbark</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Done (doc changes complete)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>58222</commentid>
    <comment_count>0</comment_count>
    <who name="Gatis Paeglis">gatis.paeglis</who>
    <bug_when>2016-01-26 10:32:43 +0000</bug_when>
    <thetext>http://www.yoctoproject.org/docs/2.0/mega-manual/mega-manual.html#ref-classes-bootimg

This class has support for creating bootable GRUB based images, but the feature is not documented.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>58287</commentid>
    <comment_count>1</comment_count>
    <who name="Scott Rifenbark">srifenbark</who>
    <bug_when>2016-01-27 23:55:01 +0000</bug_when>
    <thetext>Hi, 

If you look at http://www.yoctoproject.org/docs/2.1/ref-manual/ref-manual.html#ref-classes-bootimg you will see the bootimg class description in the ref-manual.  If it supports GRUB-based images, then I presume we need to add that to the list that currently shows only .hddimg and .iso.  

I probably need some information from you to create a new list item as I don&apos;t know any of the details for documenting this new support.  Could you provide me with some further information?

Thanks,
Scott</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>58291</commentid>
    <comment_count>2</comment_count>
    <who name="Gatis Paeglis">gatis.paeglis</who>
    <bug_when>2016-01-28 10:58:07 +0000</bug_when>
    <thetext>&gt; I presume we need to add that to the list that currently shows only .hddimg and .iso.

This list is complete. There can be for example *.iso image with syslinux boot loader and with grub boot loader. So it is still *.iso image, only the type of boot loader changes.

The issue is that this class documents only the syslinux:

&quot;The bootimg class creates a bootable image using SYSLINUX&quot;

&gt; I probably need some information from you to create a new list item as I don&apos;t know any of the details for documenting this new support.  Could you provide me with some further information?

You can check git history &quot;gitk bootimg.bbclass&quot; and send an email to the person who added grub support. He should know better what to document.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>58292</commentid>
    <comment_count>3</comment_count>
    <who name="Gatis Paeglis">gatis.paeglis</who>
    <bug_when>2016-01-28 10:58:42 +0000</bug_when>
    <thetext>updating status &quot;new more info&quot; -&gt; &quot;new&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>67561</commentid>
    <comment_count>4</comment_count>
    <who name="Scott Rifenbark">srifenbark</who>
    <bug_when>2016-10-25 20:13:40 +0000</bug_when>
    <thetext>Moving to 2.3 M2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70285</commentid>
    <comment_count>5</comment_count>
    <who name="Scott Rifenbark">srifenbark</who>
    <bug_when>2017-01-31 16:26:48 +0000</bug_when>
    <thetext>Moved to 2.3 M3.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>71478</commentid>
    <comment_count>6</comment_count>
    <who name="Scott Rifenbark">srifenbark</who>
    <bug_when>2017-03-20 18:35:21 +0000</bug_when>
    <thetext>OK - My bad on letting this bug languish for so long...

I have investigated this a bit and it appears the bootimg.bbclass class was merged into the image-live.bbclass for YP 2.1 release.  My question is does this bug still apply?  The latest information for image-live.bbclass is here - http://www.yoctoproject.org/docs/2.3/ref-manual/ref-manual.html#ref-classes-image-live.  The information in question does not appear here in this class description.  Was the functionality dropped from the code?  Or did I just drop it in the docs?  Let me know if we need to update the image-live.bbclass description.

Thanks, 
Scott</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73050</commentid>
    <comment_count>7</comment_count>
    <who name="Stephen K Jolley">sjolley.yp.pm</who>
    <bug_when>2017-05-04 15:17:36 +0000</bug_when>
    <thetext>Cal,

Can you review Scott&apos;s documentation?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73223</commentid>
    <comment_count>8</comment_count>
    <who name="California Sullivan">california.l.sullivan</who>
    <bug_when>2017-05-11 23:43:31 +0000</bug_when>
    <thetext>I think the image-live.bbclass documentation should say plainly that it is used for .iso and .hddimg images, rather than only the iso example. Also, it should mention that these live images contain syslinux for legacy boot, and the bootloader specified by EFI_PROVIDER if &quot;efi&quot; is in MACHINE_FEATURES. This would be closer to what I imagine:

This class controls building HDDIMG and ISO images. Use this class by adding &quot;live&quot; to IMAGE_FSTYPES. You can selectively build just one of these types through the NOHDD and NOISO variables. Live images contain syslinux for legacy booting, as well as the bootloader specified by EFI_PROVIDER if MACHINE_FEATURES contains &quot;efi&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73241</commentid>
    <comment_count>9</comment_count>
    <who name="Stephen K Jolley">sjolley.yp.pm</who>
    <bug_when>2017-05-12 17:37:58 +0000</bug_when>
    <thetext>It appears you have gotten feedback.  Removing NEEDINFO.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73246</commentid>
    <comment_count>10</comment_count>
    <who name="Scott Rifenbark">srifenbark</who>
    <bug_when>2017-05-12 18:31:57 +0000</bug_when>
    <thetext>Here are some changes to deal with this doc issue.  Let me know if they are okay.

 * image-live.bbclass reference section - http://www.yoctoproject.org/docs/2.3/ref-manual/ref-manual.html#ref-classes-image-live

 * EFI_PROVIDER glossary description.  I added a cross-referencing link back to the image-live.bbclass section - http://www.yoctoproject.org/docs/2.3/ref-manual/ref-manual.html#var-EFI_PROVIDER

Thanks, 
Scott</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73247</commentid>
    <comment_count>11</comment_count>
    <who name="California Sullivan">california.l.sullivan</who>
    <bug_when>2017-05-12 19:31:54 +0000</bug_when>
    <thetext>Looks good to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73248</commentid>
    <comment_count>12</comment_count>
    <who name="Scott Rifenbark">srifenbark</who>
    <bug_when>2017-05-12 19:55:50 +0000</bug_when>
    <thetext>Thanks Cal, 

I am RESOLVING and putting the doc flag to &quot;done.&quot;

Scott</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>