9036 2016-02-02 13:47:15 +0000 bitbake-prserv should not force umask in daemon mode 2016-02-11 20:59:24 +0000 1 1 7 Build System, Metadata & Runtime BitBake bitbake 2.0.2 x86 Multiple RESOLVED FIXED Medium normal 2.1 M3 1 Diego.SantaCruz richard.purdie poky.bs.watcher poky.watcher --- --- No (bug/feature does not impact docs) oldest_to_newest 58446 0 2964 Diego.SantaCruz 2016-02-02 13:47:15 +0000 Created attachment 2964 Do not clear umask of the PR Service in daemon mode The current bitbake-prserv forces the umask to 0 when daemonizing. I think his should not be done, as it will make all files be created with permissions 0777 (world writable!) by default. For instance, the PID file (/tmp/PRServer_*.pid) is created with permissions 0777 on my system (CentOS 7.2.1511). It would be better to leave the umask unchanged, so whoever is starting bitbake-preserv gets to choose the umask it wants to use. The attached patch does exactly this. 58924 1 richard.purdie 2016-02-11 20:59:24 +0000 Thanks for the patches! http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=56454f6fb2aed2bbfd6e1c1759f15d97db086d90 2964 2016-02-02 13:47:15 +0000 2016-02-02 13:47:15 +0000 Do not clear umask of the PR Service in daemon mode 0001-bitbake-prserv-do-not-clear-umask-when-daemonizing.patch text/plain 1115 Diego.SantaCruz RnJvbSAyNGY2NTEwOTVhZWIzMDA3OGVjZWRiNmI2MWViMTdiMDhkYjhhMzM4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBTYW50YSBDcnV6IDxEaWVnby5TYW50YUNydXpAc3Bp bmV0aXguY29tPgpEYXRlOiBUdWUsIDIgRmViIDIwMTYgMTM6MDg6MDUgKzAxMDAKU3ViamVjdDog W1BBVENIXSBiaXRiYWtlOiBwcnNlcnY6IGRvIG5vdCBjbGVhciB1bWFzayB3aGVuIGRhZW1vbml6 aW5nCgpDbGVhcmluZyB0aGUgdW1hc2sgd2hlbiBkYWVtb25pemluZyBpcyBub3QgdGhlIGNvcnJl Y3QgdGhpbmcKdG8gZG8sIGFzIGl0IHdpbGwgY3JlYXRlIGZpbGVzIHdyaXRhYmxlIGJ5IGFueW9u ZSBieSBkZWZhdWx0LgpGb3IgaW5zdGFuY2UgdGhlIHBpZCBmaWxlIHdhcyBiZWluZyBjcmVhdGVk IHdpdGggbW9kZSA3NzcuClRoaXMgY291bGQgYWxzbyBwb3RlbnRpYWxseSBhZmZlY3QgdGhlIHNx bGl0ZSBkYXRhYmFzZS4KQmV0dGVyIGxldCB0aGUgY2FsbGluZyBwcm9jZXNzIGRlY2lkZSBvbiB0 aGUgdW1hc2suCgpTaWduZWQtb2ZmLWJ5OiBEaWVnbyBTYW50YSBDcnV6IDxEaWVnby5TYW50YUNy dXpAc3BpbmV0aXguY29tPgotLS0KIGJpdGJha2UvbGliL3Byc2Vydi9zZXJ2LnB5IHwgMSAtCiAx IGZpbGUgY2hhbmdlZCwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2JpdGJha2UvbGliL3By c2Vydi9zZXJ2LnB5IGIvYml0YmFrZS9saWIvcHJzZXJ2L3NlcnYucHkKaW5kZXggMWRlMzdjZi4u ZjZmNTBlZSAxMDA2NDQKLS0tIGEvYml0YmFrZS9saWIvcHJzZXJ2L3NlcnYucHkKKysrIGIvYml0 YmFrZS9saWIvcHJzZXJ2L3NlcnYucHkKQEAgLTIxMiw3ICsyMTIsNiBAQCBjbGFzcyBQUlNlcnZl cihTaW1wbGVYTUxSUENTZXJ2ZXIpOgogICAgIGRlZiBjbGVhbnVwX2hhbmRsZXMoc2VsZik6CiAg ICAgICAgIHNpZ25hbC5zaWduYWwoc2lnbmFsLlNJR0lOVCwgc2VsZi5zaWdpbnRfaGFuZGxlcikK ICAgICAgICAgc2lnbmFsLnNpZ25hbChzaWduYWwuU0lHVEVSTSwgc2VsZi5zaWd0ZXJtX2hhbmRs ZXIpCi0gICAgICAgIG9zLnVtYXNrKDApCiAgICAgICAgIG9zLmNoZGlyKCIvIikKIAogICAgICAg ICBzeXMuc3Rkb3V0LmZsdXNoKCkKLS0gCjEuOS40Cgo=