9342 2016-03-24 14:29:03 +0000 Vet subprocess calls 2017-07-11 17:38:44 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core 2.1 All Multiple VERIFIED FIXED https://bugzilla.yoctoproject.org/show_bug.cgi?id=10383 Medium+ enhancement 2.3 M1 1 ross.burton stephano benjamin.esquivel jose.perez.carranza joshuagloe meta.mr.watcher meta.watcher richard.purdie sgw juan.fernandox.ramos.frayle --- --- No (bug/feature does not impact docs) oldest_to_newest 60389 0 ross.burton 2016-03-24 14:29:03 +0000 We should vet all users of subprocess, as unless you pass stderr=subprocess.STDOUT then stderr will disappear and this may mean errors are unreported. 63584 1 joshuagloe 2016-07-01 15:46:39 +0000 We should also vet oe.path.check_output() calls 63585 2 ross.burton 2016-07-01 15:53:45 +0000 This is a proper yak shaver * Review bb.process in light of Python 3.4's subprocess implementation, in particular some of the issues in py2 have been fixed so some cruft can likely be removed * Note that Python 3.5 has a subprocess.run() convenience function that does all sorts of useful magic. Maybe it would be sensible to clone that API in bb.process() for consistency and the ability to just use subprocess.run() in the future * Review subprocess calls, moving as much as possible to lists instead of strings with shell=True, and show stderr on error. 63586 3 ross.burton 2016-07-01 15:59:56 +0000 There were just two callers of oe.path.check_output, so I just sent a patch to use subprocess directly. 63959 4 ross.burton 2016-07-14 00:03:21 +0000 Stephano, I appreciate this bug is rather vague, hopefully comment #2 makes some sense. Feel free to talk to me if you're not sure about anything! 64262 5 ross.burton 2016-07-21 14:35:33 +0000 oe.utils.getstatusoutput() is a wrapper around subprocess.getstatusouput() in Py3, which is basically deprecated and behaves almost entirely unlike run(). This also should be gutted. 66661 6 stephano 2016-09-27 23:39:11 +0000 Cleaned up sub.call and sub.check_output calls in meta/lib/oe/. Looking at Popen calls next. 66976 7 stephano 2016-10-06 04:06:40 +0000 As I slowly pull apart all the strings, pipes, and redirects in package_manager.py, I am reminded of a rat infested spool of razorwire surrounded by bees. With any luck this should be done tomorrow. 67025 8 stephano 2016-10-07 03:36:12 +0000 Checked in the needed changes. 74932 9 juan.fernandox.ramos.frayle 2017-07-11 17:38:44 +0000 According to Stephano, any test of the “package” and “package_manager” features in OE will test the changes. Since these are present in nightly test, Im changing this to verified.