9430 2016-04-11 02:52:51 +0000 fixup_perms fails when both /var/run and /var/lock present 2016-04-21 15:28:08 +0000 1 1 7 Build System, Metadata & Runtime OE-Core configuration unspecified x86 Multiple RESOLVED FIXED Medium+ normal 2.1 M4 1 denis bill.randle bill.randle dan.mcgregor richard.purdie --- --- No (bug/feature does not impact docs) oldest_to_newest 61001 0 denis 2016-04-11 02:52:51 +0000 The file meta/files/fs-perms.txt contains this: # Items from base-files # Links ${localstatedir}/run link /run ${localstatedir}/log link volatile/log ${localstatedir}/lock link /run/lock ${localstatedir}/tmp link volatile/tmp Now, when a recipe installs both /var/run and /var/lock, the fixup_perms function of do_package does create /run/lock and symlinks /var/lock into it, but then fails to symlink the actual /var/run into /run with the following error: ERROR: recipename do_package: QA Issue: Fixup Perms: Unable to correct directory link, target already exists: /var/run -> /run [perm-link] 61060 1 3118 bill.randle 2016-04-12 00:22:50 +0000 Created attachment 3118 Proposed patch When processing links, the directories are processed in unsorted order which can result in cases like /var/lock -> /run/lock handled before /var/run -> /run throwing an error for /var/run because /run already exists. Change the link processing to ensure links are processed in sorted order of the destination. 61101 2 denis 2016-04-12 16:51:09 +0000 Seems to resolve the issue for me. 61174 3 dan.mcgregor 2016-04-13 18:54:04 +0000 The version in master introduces a new problem. The old code would process the permissions table in order, and later entries would override the first entries. This made overriding parts of the permissions file possible. As an example, putting: FILESYSTEM_PERMS_TABLES = "files/fs-perms.txt files/fs-perms-override.txt" into conf/local.conf, where files/fs-perms.txt is the default from openembedded-core and files/fs-perms-override.txt contains: # Override OE-core: ${localstatedir}/log 0755 root root false - - - ${localstatedir}/tmp 01777 root root false - - - ${sysconfdir}/mtab link /proc/self/mounts ${ROOT_HOME} 0700 root root false - - - would allow ${localstatedir}/log and ${localstatedir}/tmp to be a real directories. To demonstrate this, an append on base-files will suffice, so base-files_%.bbappend containing: volatiles_remove = "log tmp" dirs755 += "${localstatedir}/log" dirs1777 += "${localstatedir}/tmp" produces: ERROR: base-files-3.0.14-r89 do_package: QA Issue: Fixup Perms: Unable to correct directory link, target already exists: /var/log -> /var/volatile/log [perm-link] ERROR: base-files-3.0.14-r89 do_package: QA Issue: Fixup Perms: Unable to correct directory link, target already exists: /var/tmp -> /var/volatile/tmp [perm-link] The same configuration, prior to the version currently in master created /var/log and /var/tmp as real directories. 61510 4 richard.purdie 2016-04-21 15:28:08 +0000 http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=9262d2ff39f898605fe6f4224a4684e782439497 3118 2016-04-12 00:22:50 +0000 2016-04-12 00:22:50 +0000 Proposed patch 0001-package.bbclass-handle-links-in-sorted-order.patch text/plain 2772 bill.randle RnJvbSAxOTNjOTIzZTQyYjRhYzBiODQwY2MyODkwYzc5ZGVkYTVkZmMxNTAzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCaWxsIFJhbmRsZSA8d2lsbGlhbS5jLnJhbmRsZUBpbnRlbC5j b20+CkRhdGU6IE1vbiwgMTEgQXByIDIwMTYgMTc6MTE6MjEgLTA3MDAKU3ViamVjdDogW1BBVENI XSBwYWNrYWdlLmJiY2xhc3M6IGhhbmRsZSBsaW5rcyBpbiBzb3J0ZWQgb3JkZXIKCldoZW4gcHJv Y2Vzc2luZyBsaW5rcywgdGhlIGRpcmVjdG9yaWVzIGFyZSBwcm9jZXNzZWQgaW4gdW5zb3J0ZWQg b3JkZXIKd2hpY2ggY2FuIHJlc3VsdCBpbiBjYXNlcyBsaWtlIC92YXIvbG9jayAtPiAvcnVuL2xv Y2sgaGFuZGxlZCBiZWZvcmUKL3Zhci9ydW4gLT4gL3J1biB0aHJvd2luZyBhbiBlcnJvciBmb3Ig L3Zhci9ydW4gYmVjYXVzZSAvcnVuIGFscmVhZHkgZXhpc3RzLgpDaGFuZ2UgdGhlIGxpbmsgcHJv Y2Vzc2luZyB0byBlbnN1cmUgbGlua3MgYXJlIHByb2Nlc3NlZCBpbiBzb3J0ZWQgb3JkZXIgb2YK dGhlIGRlc3RpbmF0aW9uLgoKW1lPQ1RPICM5NDMwXQoKU2lnbmVkLW9mZi1ieTogQmlsbCBSYW5k bGUgPHdpbGxpYW0uYy5yYW5kbGVAaW50ZWwuY29tPgotLS0KIG1ldGEvY2xhc3Nlcy9wYWNrYWdl LmJiY2xhc3MgfCAxOSArKysrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTAgaW5z ZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9tZXRhL2NsYXNzZXMvcGFj a2FnZS5iYmNsYXNzIGIvbWV0YS9jbGFzc2VzL3BhY2thZ2UuYmJjbGFzcwppbmRleCA0NDUyZTJm Li44OTRiNzI5IDEwMDY0NAotLS0gYS9tZXRhL2NsYXNzZXMvcGFja2FnZS5iYmNsYXNzCisrKyBi L21ldGEvY2xhc3Nlcy9wYWNrYWdlLmJiY2xhc3MKQEAgLTcyNyw2ICs3MjcsNyBAQCBweXRob24g Zml4dXBfcGVybXMgKCkgewogICAgIGR2YXIgPSBkLmdldFZhcignUEtHRCcsIFRydWUpCiAKICAg ICBmc19wZXJtc190YWJsZSA9IHt9CisgICAgZnNfbGlua190YWJsZSA9IHt9CiAKICAgICAjIEJ5 IGRlZmF1bHQgYWxsIG9mIHRoZSBzdGFuZGFyZCBkaXJlY3RvcmllcyBzcGVjaWZpZWQgaW4KICAg ICAjIGJpdGJha2UuY29uZiB3aWxsIGdldCAwNzU1IHJvb3Q6cm9vdC4KQEAgLTc3MywyNCArNzc0 LDI3IEBAIHB5dGhvbiBmaXh1cF9wZXJtcyAoKSB7CiAgICAgICAgICAgICAgICAgICAgIGNvbnRp bnVlCiAgICAgICAgICAgICAgICAgZW50cnkgPSBmc19wZXJtc19lbnRyeShkLmV4cGFuZChsaW5l KSkKICAgICAgICAgICAgICAgICBpZiBlbnRyeSBhbmQgZW50cnkucGF0aDoKLSAgICAgICAgICAg ICAgICAgICAgZnNfcGVybXNfdGFibGVbZW50cnkucGF0aF0gPSBlbnRyeQorICAgICAgICAgICAg ICAgICAgICBpZiBlbnRyeS5saW5rOgorICAgICAgICAgICAgICAgICAgICAgICAgZnNfbGlua190 YWJsZVtlbnRyeS5saW5rXSA9IGVudHJ5CisgICAgICAgICAgICAgICAgICAgIGVsc2U6CisgICAg ICAgICAgICAgICAgICAgICAgICBmc19wZXJtc190YWJsZVtlbnRyeS5wYXRoXSA9IGVudHJ5CiAg ICAgICAgICAgICBmLmNsb3NlKCkKIAogICAgICMgRGVidWcgLS0gbGlzdCBvdXQgaW4tbWVtb3J5 IHRhYmxlCiAgICAgI2ZvciBkaXIgaW4gZnNfcGVybXNfdGFibGU6CiAgICAgIyAgICBiYi5ub3Rl KCJGaXh1cCBQZXJtczogJXM6ICVzIiAlIChkaXIsIHN0cihmc19wZXJtc190YWJsZVtkaXJdKSkp CisgICAgI2ZvciBsaW5rIGluIGZzX2xpbmtfdGFibGU6CisgICAgIyAgICBiYi5ub3RlKCJGaXh1 cCBQZXJtczogJXM6ICVzIiAlIChsaW5rLCBzdHIoZnNfbGlua190YWJsZVtsaW5rXSkpKQogCiAg ICAgIyBXZSBwcm9jZXNzIGxpbmtzIGZpcnN0LCBzbyB3ZSBjYW4gZ28gYmFjayBhbmQgZml4dXAg ZGlyZWN0b3J5IG93bmVyc2hpcAogICAgICMgZm9yIGFueSBuZXdseSBjcmVhdGVkIGRpcmVjdG9y aWVzCi0gICAgZm9yIGRpciBpbiBmc19wZXJtc190YWJsZToKLSAgICAgICAgaWYgbm90IGZzX3Bl cm1zX3RhYmxlW2Rpcl0ubGluazoKLSAgICAgICAgICAgIGNvbnRpbnVlCi0KKyAgICAjIFByb2Nl c3MgaW4gc29ydGVkIG9yZGVyIHNvIC9ydW4gZ2V0cyBjcmVhdGVkIGJlZm9yZSAvcnVuL2xvY2ss IGV0Yy4KKyAgICBmb3IgbGluayBpbiBzb3J0ZWQoZnNfbGlua190YWJsZSk6CisgICAgICAgIGRp ciA9IGZzX2xpbmtfdGFibGVbbGlua10ucGF0aAogICAgICAgICBvcmlnaW4gPSBkdmFyICsgZGly CiAgICAgICAgIGlmIG5vdCAoY3BhdGguZXhpc3RzKG9yaWdpbikgYW5kIGNwYXRoLmlzZGlyKG9y aWdpbikgYW5kIG5vdCBjcGF0aC5pc2xpbmsob3JpZ2luKSk6CiAgICAgICAgICAgICBjb250aW51 ZQogCi0gICAgICAgIGxpbmsgPSBmc19wZXJtc190YWJsZVtkaXJdLmxpbmsKICAgICAgICAgaWYg bGlua1swXSA9PSAiLyI6CiAgICAgICAgICAgICB0YXJnZXQgPSBkdmFyICsgbGluawogICAgICAg ICAgICAgcHRhcmdldCA9IGxpbmsKQEAgLTgxMCw5ICs4MTQsNiBAQCBweXRob24gZml4dXBfcGVy bXMgKCkgewogICAgICAgICBvcy5zeW1saW5rKGxpbmssIG9yaWdpbikKIAogICAgIGZvciBkaXIg aW4gZnNfcGVybXNfdGFibGU6Ci0gICAgICAgIGlmIGZzX3Blcm1zX3RhYmxlW2Rpcl0ubGluazoK LSAgICAgICAgICAgIGNvbnRpbnVlCi0KICAgICAgICAgb3JpZ2luID0gZHZhciArIGRpcgogICAg ICAgICBpZiBub3QgKGNwYXRoLmV4aXN0cyhvcmlnaW4pIGFuZCBjcGF0aC5pc2RpcihvcmlnaW4p KToKICAgICAgICAgICAgIGNvbnRpbnVlCi0tIAoyLjUuMAoK