9611 2016-05-09 23:00:13 +0000 Under Project->Bitbake variable, We disallow variables with a '/' in them 2016-09-19 12:49:14 +0000 1 1 7 Build System, Metadata & Runtime Toaster toaster 2.0 x86 Multiple RESOLVED FIXED Medium normal 2.2 M4 1 brian.avery belen.barros.pena belen.barros.pena bluelightning jessica.zhang ross.burton stanciux.mihail libertad.gonzalez.de.la.cruz --- --- Yes (doc changes required) oldest_to_newest 62057 0 brian.avery 2016-05-09 23:00:13 +0000 an example of such a variable that we might want to set is PREFERRED_PROVIDER_virtual/java2-runtime to openjdk-7-jre. Our javascript checker says: 'A valid variable name can only include letters, numbers, underscores, and dashes' 62136 1 bluelightning 2016-05-12 03:59:18 +0000 + is allowed and used in recipe names, so it needs to be allowed in variable names here too (since it can therefore appear in a valid _pn- override). 62144 2 belen.barros.pena 2016-05-12 14:34:04 +0000 so, it's / and + so far. Any other special character we ought to allow? 62163 3 brian.avery 2016-05-12 17:30:48 +0000 What about not restricting the inputs? If they put in an unparseable variable, the error message should be clear, I would think. 62171 4 belen.barros.pena 2016-05-13 09:38:54 +0000 (In reply to comment #3) > What about not restricting the inputs? If they put in an unparseable > variable, the error message should be clear, I would think. mmm, personally I don't like the approach. The CLI already let's you shoot yourself in the foot: we don't need the GUI to do that too. Most special characters are probably not allowed in OE variables (or so I was told when I designed that page). If that's the case, let's validate user input, as good web forms should. Turns out there is an answer to this in BitBake http://git.openembedded.org/bitbake/tree/lib/bb/parse/parse_py/ConfHandler.py#n33 According to RP, (?P<var>[a-zA-Z0-9\-~_+.${}/]+?) is the key bit. It implies a-zA-Z0-9\-~_+.${}/ are all acceptable So here is our answer: those are the special characters the validation should allow. 62200 5 brian.avery 2016-05-13 21:23:46 +0000 Agreed. Your's is better. 65798 6 belen.barros.pena 2016-09-05 11:06:11 +0000 Patch submitted to the mailing list https://lists.yoctoproject.org/pipermail/toaster/2016-September/005164.html 66322 7 ross.burton 2016-09-19 12:49:14 +0000 Merged in bitbake 146f6f95a8753308edb31e952d7c440c8de11870.