<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>9622</bug_id>
          
          <creation_ts>2016-05-11 16:18:56 +0000</creation_ts>
          <short_desc>build.sh: error trying to generate doc for adt-manual</short_desc>
          <delta_ts>2016-06-13 18:06:00 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>Eclipse Plugin</product>
          <component>eclipse-plugin</component>
          <version>2.2</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.2</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Humberto Ibarra">humberto.ibarra.lopez</reporter>
          <assigned_to name="Tim Orling">tim.orling</assigned_to>
          <cc>ioanax.grigoropol</cc>
    
    <cc>yp.ep.watcher</cc>
    
    <cc>yp.watcher</cc>
          
          <qa_contact name="Libertad">libertad.gonzalez.de.la.cruz</qa_contact>
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>62107</commentid>
    <comment_count>0</comment_count>
    <who name="Humberto Ibarra">humberto.ibarra.lopez</who>
    <bug_when>2016-05-11 16:18:56 +0000</bug_when>
    <thetext>I ran the build.sh to create the plugin and in the first lines I saw an error with generating the adt-manual documentation:

$ ECLIPSE_HOME=/home/humberto/eclipse-poky/scripts/eclipse ./build.sh -l master master master 2&gt;&amp;1 | tee -a build.log
Cloning into &apos;/home/humberto/eclipse-poky/scripts/master_build_201605111108/src&apos;...

Checking out master

Already on &apos;master&apos;
Your branch is up-to-date with &apos;origin/master&apos;.

Generate Yocto documentation

Cloning into &apos;/home/humberto/eclipse-poky/scripts/master_build_201605111108/src/docs&apos;...
Already on &apos;master&apos;
Your branch is up-to-date with &apos;origin/master&apos;.
 
******** Building eclipse help of yocto-project-qs
 
cd yocto-project-qs &amp;&amp; \
	xsltproc --xinclude \
			--stringparam base.dir &apos;html/yocto-project-qs/&apos; \
			-o eclipse/yocto-project-qs.html \
			yocto-project-qs-eclipse-customization.xsl yocto-project-qs.xml &amp;&amp; \
	mv eclipse/toc.xml eclipse/yocto-project-qs-toc.xml &amp;&amp; \
	cp -rf figures eclipse/html/yocto-project-qs/ &amp;&amp; \
	cd ..;
 
******** Using eclipse-help.sed to process external links
 
 
ERROR: You can only create eclipse documentation
       of the following documentation parts:
       - sdk-manual
       - bsp-guide
       - dev-manual
       - kernel-dev
       - profile-manual
       - ref-manual
       - yocto-project-qs
 
 
******** Using eclipse-help.sed to process external links
 
cp: cannot stat ‘adt-manual/eclipse/html/*’: No such file or directory
cp: cannot stat ‘adt-manual/eclipse/adt-manual-toc.xml’: No such file or directory

.
.
.


Checked a bit into this and seems like the generate-doc.sh script is explicitly trying to generate the docs:

DOCS=&quot;yocto-project-qs adt-manual kernel-dev \
      bsp-guide ref-manual dev-manual profile-manual&quot;

Even so, the docs have stopped supporting the adt-manual documentation with commit 	d2084cc95ac185d7e4e19b633739c8ea27cd268a. The make file for the docs no longer includes adt-manual.

This specific error can be fixed, but some other similar errors might come out later. It seems to me that the best way to go would be for generate-docs.sh to dynamically retrieve the available docs, and only attempt to make those documentations that are available in the documentation branch given.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>62492</commentid>
    <comment_count>1</comment_count>
    <who name="Tim Orling">tim.orling</who>
    <bug_when>2016-05-26 23:09:36 +0000</bug_when>
    <thetext>In addition, the generate-doc.sh script should be building sdk-manual now (since commit ab591831a97a97d405d13ed75e9fb01e0452c292)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>62493</commentid>
    <comment_count>2</comment_count>
    <who name="Tim Orling">tim.orling</who>
    <bug_when>2016-05-27 00:22:39 +0000</bug_when>
    <thetext>The references to &quot;adt-manual&quot; in plugins/org.yocto.doc.user/plugin.xml, toc.xml and about.html.in will also have be changed. This means we will have to change those files before the plugin is built. Luckily generate-doc.sh runs at the right time for this. For older releases, generate-doc.sh will need to patch the files. The default for &quot;master&quot;, &quot;krogoth&quot; and &quot;yocto-2.1&quot; (planned) branches/tags will be sdk-manual.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>62571</commentid>
    <comment_count>3</comment_count>
    <who name="Tim Orling">tim.orling</who>
    <bug_when>2016-06-01 17:21:09 +0000</bug_when>
    <thetext>This approach of whitelisting the branches/tags which build sdk-manual is brittle. Every time a new tag or branch for yocto-docs is created the check would have to be updated. If we only had branches to worry about, we could &apos;git branch -r --contains &lt;commitish&gt;&apos;, but this won&apos;t be valid for tags or cherry-picks. Humberto&apos;s original idea of checking the output of the make command probably makes the most sense, assuming the check in the Makefile exists of course.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>62933</commentid>
    <comment_count>4</comment_count>
    <who name="Tim Orling">tim.orling</who>
    <bug_when>2016-06-13 18:05:30 +0000</bug_when>
    <thetext>Patch:
https://lists.yoctoproject.org/pipermail/yocto/2016-June/030385.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>62934</commentid>
    <comment_count>5</comment_count>
    <who name="Tim Orling">tim.orling</who>
    <bug_when>2016-06-13 18:06:00 +0000</bug_when>
    <thetext>Merged.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>