<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>9665</bug_id>
          
          <creation_ts>2016-05-23 22:20:42 +0000</creation_ts>
          <short_desc>quoting bug in poky/scripts/contrib/mkefidisk.sh</short_desc>
          <delta_ts>2017-07-18 22:32:14 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>11</classification_id>
          <classification>Runtime</classification>
          <product>General Runtime</product>
          <component>General Runtime</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugzilla.yoctoproject.org/show_bug.cgi?id=10451</see_also>
    
    <see_also>https://bugzilla.yoctoproject.org/show_bug.cgi?id=10468</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.2.2</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Troy D. Hanson">troy.hanson</reporter>
          <assigned_to name="Saul Wold">sgw</assigned_to>
          <cc>akuster</cc>
    
    <cc>sgw</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>62401</commentid>
    <comment_count>0</comment_count>
      <attachid>3185</attachid>
    <who name="Troy D. Hanson">troy.hanson</who>
    <bug_when>2016-05-23 22:20:42 +0000</bug_when>
    <thetext>Created attachment 3185
Patch for mkefidisk.sh

The attached patch corrects a quoting bug in mkefidisk.sh. The bug writes a startup.nsh with embedded control characters. This happens because \b etc are control sequences to the shell echo command. The resulting startup.nsh causes the bootup to fail, and the user is dropped into the EFI shell to manually run startup.nsh.

People following the Yocto Quick Start Guide following the Minnowboard Max example encounter the effect of this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>62405</commentid>
    <comment_count>1</comment_count>
      <attachid>3186</attachid>
    <who name="Troy D. Hanson">troy.hanson</who>
    <bug_when>2016-05-23 23:39:26 +0000</bug_when>
    <thetext>Created attachment 3186
Corrected patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>62442</commentid>
    <comment_count>2</comment_count>
    <who name="Saul Wold">sgw</who>
    <bug_when>2016-05-25 14:43:42 +0000</bug_when>
    <thetext>Troy, could you please send this patch to the openembedded-core@lists.openembedded.org mailing list?  Add your comment below as the commit message.

If you are not able please assign the bug back to me and I will do it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>67420</commentid>
    <comment_count>3</comment_count>
    <who name="Benjamin Esquivel">benjamin.esquivel</who>
    <bug_when>2016-10-20 15:03:13 +0000</bug_when>
    <thetext>if bug 10468 deprecates mkefidisk.sh then this change would be valid just for pre 2.3 point releases.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>74643</commentid>
    <comment_count>4</comment_count>
    <who name="Saul Wold">sgw</who>
    <bug_when>2017-06-29 15:06:48 +0000</bug_when>
    <thetext>So this is not really in a newer release yet, so a patch to master is needed first, will be provided shortly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75123</commentid>
    <comment_count>5</comment_count>
    <who name="Saul Wold">sgw</who>
    <bug_when>2017-07-18 22:32:14 +0000</bug_when>
    <thetext>Pyro: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=pyro&amp;id=1382d6cccea3a23f04c08a7803022c5d96ee4ab7

Master: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=7fd1491d2f07c4a6b5dda78a92c1c17f544d642d</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>3185</attachid>
            <date>2016-05-23 22:20:42 +0000</date>
            <delta_ts>2016-05-23 23:39:26 +0000</delta_ts>
            <desc>Patch for mkefidisk.sh</desc>
            <filename>mkefidisk.sh.patch</filename>
            <type>application/octet-stream</type>
            <size>475</size>
            <attacher name="Troy D. Hanson">troy.hanson</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL3NjcmlwdHMvY29udHJpYi9ta2VmaWRpc2suc2ggYi9zY3JpcHRzL2NvbnRy
aWIvbWtlZmlkaXNrLnNoCmluZGV4IDMzMzI4NGYuLmUwZDAwYTUgMTAwNzU1Ci0tLSBhL3Njcmlw
dHMvY29udHJpYi9ta2VmaWRpc2suc2gKKysrIGIvc2NyaXB0cy9jb250cmliL21rZWZpZGlzay5z
aApAQCAtNDM5LDcgKzQzOSw3IEBAIGlmIFsgLWQgJFJPT1RGU19NTlQvZXRjL3VkZXYvIF0gOyB0
aGVuCiBmaQogCiAjIEFkZCBzdGFydHVwLm5zaCBzY3JpcHQgZm9yIGF1dG9tYXRlZCBib290Ci1l
Y2hvICJmczA6XEVGSVxCT09UXGJvb3R4NjQuZWZpIiA+ICRCT09URlNfTU5UL3N0YXJ0dXAubnNo
CitlY2hvICdmczA6XEVGSVxCT09UXGJvb3R4NjQuZWZpJyA+ICRCT09URlNfTU5UL3N0YXJ0dXAu
bnNoCiAKIAogIyBDYWxsIGNsZWFudXAgdG8gdW5tb3VudCBkZXZpY2VzIGFuZCBpbWFnZXMgYW5k
IHJlbW92ZSB0aGUgVE1QRElSCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>3186</attachid>
            <date>2016-05-23 23:39:26 +0000</date>
            <delta_ts>2016-05-23 23:39:26 +0000</delta_ts>
            <desc>Corrected patch</desc>
            <filename>mkefidisk.sh.patch-corrected</filename>
            <type>text/plain</type>
            <size>478</size>
            <attacher name="Troy D. Hanson">troy.hanson</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL3NjcmlwdHMvY29udHJpYi9ta2VmaWRpc2suc2ggYi9zY3JpcHRzL2NvbnRy
aWIvbWtlZmlkaXNrLnNoCmluZGV4IDMzMzI4NGYuLmE3YjE3ZDkgMTAwNzU1Ci0tLSBhL3Njcmlw
dHMvY29udHJpYi9ta2VmaWRpc2suc2gKKysrIGIvc2NyaXB0cy9jb250cmliL21rZWZpZGlzay5z
aApAQCAtNDM5LDcgKzQzOSw3IEBAIGlmIFsgLWQgJFJPT1RGU19NTlQvZXRjL3VkZXYvIF0gOyB0
aGVuCiBmaQogCiAjIEFkZCBzdGFydHVwLm5zaCBzY3JpcHQgZm9yIGF1dG9tYXRlZCBib290Ci1l
Y2hvICJmczA6XEVGSVxCT09UXGJvb3R4NjQuZWZpIiA+ICRCT09URlNfTU5UL3N0YXJ0dXAubnNo
CitlY2hvICdmczA6XFxFRklcXEJPT1RcXGJvb3R4NjQuZWZpJyA+ICRCT09URlNfTU5UL3N0YXJ0
dXAubnNoCiAKIAogIyBDYWxsIGNsZWFudXAgdG8gdW5tb3VudCBkZXZpY2VzIGFuZCBpbWFnZXMg
YW5kIHJlbW92ZSB0aGUgVE1QRElSCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>